From: Hemanth Selam <hemanth.selam@gmail.com>
To: Josh Juran <jjuran@gmail.com>
Cc: John Paul Adrian Glaubitz <glaubitz@physik.fu-berlin.de>,
Greg Ungerer <gerg@linux-m68k.org>,
Geert Uytterhoeven <geert@linux-m68k.org>,
linux-kernel@vger.kernel.org, linux-m68k@lists.linux-m68k.org
Subject: Re: [PATCH] m68k: coldfire: fix typo "reseting" in comment
Date: Mon, 7 Sep 2026 14:45:44 +0530 [thread overview]
Message-ID: <20260907091544.36558-1-hemanth.selam@gmail.com> (raw)
In-Reply-To: <C901AA86-8D21-4E1E-A2E5-A6D99CDBD705@gmail.com>
On Sun, Sep 06, 2026 at 02:46:04AM -0400, Josh Juran wrote:
> What about the human reviewing its output? Or am I misunderstanding
> the meaning of "Signed-off-by"?
You are not misunderstanding it. My Signed-off-by certifies the DCO,
but sending the patch also means I am answerable for what is in it, and
on this one I did not look hard enough.
The patch came out of a mechanical sweep: checkpatch.pl flags words
listed in scripts/spelling.txt, "reseting" is in that list and
"ColdFure" is not, so nothing pointed at it. That explains why the
tool stopped there. It does not explain why I did not, because the two
words are on the same line and reading the comment was my job.
You caught it, and the v2 fixes both words; Greg has since applied it.
The wider lesson I am taking from this is that a large series does not
get to be reviewed in bulk. Each patch has to be read on its own, in
context, before it goes out, and that is what I will be doing for the
rest of this work.
Thanks for pushing on it rather than letting it through.
Hemanth
prev parent reply other threads:[~2026-09-07 9:15 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-04 11:23 Hemanth Selam
2026-09-06 6:40 ` Josh Juran
2026-09-06 6:43 ` John Paul Adrian Glaubitz
2026-09-06 6:46 ` Josh Juran
2026-09-07 9:15 ` Hemanth Selam [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260907091544.36558-1-hemanth.selam@gmail.com \
--to=hemanth.selam@gmail.com \
--cc=geert@linux-m68k.org \
--cc=gerg@linux-m68k.org \
--cc=glaubitz@physik.fu-berlin.de \
--cc=jjuran@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-m68k@lists.linux-m68k.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®