From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E276938737B; Mon, 7 Sep 2026 09:20:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=148.163.156.1 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788772834; cv=none; b=Ao38EVabmIBBCtUwqPnwOMWOnGn/OQz/07FCIcBeUF5sfcq9CnrDMnYmgqjV0tsfcN4isI8a18+uZhn6VjA+nzXREScQchnfugRiUjl//5opLyAx3J0wL57TXm8r7B1bn/ZhEnSTaQbQBFX9QBGwHdRzqgHTTug90fz3qNUX+NE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788772834; c=relaxed/simple; bh=J+I9qFj4O9CekHQyz47pF5PbYfexT9x4gQ7LrE4OhWg=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=ne9sPEz9OXpjAhXbkzwppHfR6MuBFskh2rcq9u7kXDbxy2/17I8lEk6TA5MS9bsPFMt/jN6JzW0rK93invArrLnffREhDVOKHoIyCivYh4FJjRDpx9dWlYaL5DDk5HgrUWks7OcOcu0eRggwGxHeEV0qFyWL3WJkaVzxmk6WgQ4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.ibm.com; spf=pass smtp.mailfrom=linux.ibm.com; dkim=pass (2048-bit key) header.d=ibm.com header.i=@ibm.com header.b=YODo+Nh2; arc=none smtp.client-ip=148.163.156.1 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.ibm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.ibm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ibm.com header.i=@ibm.com header.b="YODo+Nh2" Received: from pps.filterd (m0356517.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 6877VXRa1287232; Mon, 7 Sep 2026 09:20:20 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=cc :content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=pp1; bh=ueaPeZ QkPkdRMMtS6Hq/G5/R0qfzGyg4XdsGhINvZlo=; b=YODo+Nh27/cMnhiWTMYzPd done4NP91hp2t7CIwVinx4ARi2S6WXalh2H++NRiIOYmz9a/VnKmib7a5KWqaVKI jylE/wftW5Jl/KK4Mij0HkV3/ocai2WuzzK7fI45GeYwvYeT1uaPSpfYYJFiYDDX 4gISF5LhDp5N6+l2v2SWumfRzcvKW7TuMUjRl2rr3V/mk7V5U5EZPbwWc50F7o3Q LSPkS29L/gIueiwRfAmBNPTQuhLxwiT6uqMVRA3+E842oCj/epGXabjfra5DYUwA nLFeZ20uOkOcLkxXBoDU3eBZV63z+P+LvRq3BFY8aXvRvB3gKXqLj1Kccpmtfq6w == Received: from ppma11.dal12v.mail.ibm.com (db.9e.1632.ip4.static.sl-reverse.com [50.22.158.219]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 4ggbhkftfy-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 07 Sep 2026 09:20:19 +0000 (GMT) Received: from pps.filterd (ppma11.dal12v.mail.ibm.com [127.0.0.1]) by ppma11.dal12v.mail.ibm.com (8.18.1.7/8.18.1.7) with ESMTP id 6879BCfw026602; Mon, 7 Sep 2026 09:20:18 GMT Received: from smtprelay03.fra02v.mail.ibm.com ([9.218.2.224]) by ppma11.dal12v.mail.ibm.com (PPS) with ESMTPS id 4gh03y4u75-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 07 Sep 2026 09:20:18 +0000 (GMT) Received: from smtpav04.fra02v.mail.ibm.com (smtpav04.fra02v.mail.ibm.com [10.20.54.103]) by smtprelay03.fra02v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 6879KGSP42926574 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 7 Sep 2026 09:20:16 GMT Received: from smtpav04.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 9B58D20040; Mon, 7 Sep 2026 09:20:16 +0000 (GMT) Received: from smtpav04.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id F08B120043; Mon, 7 Sep 2026 09:20:14 +0000 (GMT) Received: from fedora (unknown [9.5.7.39]) by smtpav04.fra02v.mail.ibm.com (Postfix) with ESMTPS; Mon, 7 Sep 2026 09:20:14 +0000 (GMT) Date: Mon, 7 Sep 2026 14:57:59 +0530 From: Amit Machhiwal To: nhuquynh@tutamail.com Cc: Maddy , Npiggin , Mpe , Chleroy , Linuxppc Dev , Kvm , Linux Kernel Subject: Re: [PATCH] KVM: PPC: Fix callback check in kvmppc_gsm_refresh_info Message-ID: <20260907145626.7675e892-56-amachhiw@linux.ibm.com> Mail-Followup-To: nhuquynh@tutamail.com, Maddy , Npiggin , Mpe , Chleroy , Linuxppc Dev , Kvm , Linux Kernel References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-TM-AS-GCONF: 00 X-Proofpoint-Reinject: loops=2 maxloops=12 X-Proofpoint-Spam-Info: AW1haW4tMjYwOTA3MDA5OCBTYWx0ZWRfX6NYsgGxbe258 +pv0Ph3Zjx+4VoSNg12L6lCM6gjybGIRGj4SkX4SmNlmzPxakR8ytO/jx5iovv1EHBX9i+BjgEE ZEQSRgppplKyQ9ZMbc2TC1esUJB/mVk= X-Proofpoint-ORIG-GUID: IhqbsV6MnVA-fzWJ51WRt5D96PYvxuHI X-Authority-Analysis: v=2.4 cv=NMDlPU6g c=1 sm=1 tr=0 ts=6a9e81d3 cx=c_pps a=aDMHemPKRhS1OARIsFnwRA==:117 a=aDMHemPKRhS1OARIsFnwRA==:17 a=IkcTkHD0fZMA:10 a=VdqzKS8jKosA:10 a=VkNPw1HP01LnGYTKEx00:22 a=RnoormkPH1_aCDwRdu11:22 a=U7nrCbtTmkRpXpFmAIza:22 a=opkI-JdcAAAA:8 a=-UEHelddAeA3dXerUxoA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=Ww8VKtPN2Pdc02dhIGwG:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwOTA3MDA5OCBTYWx0ZWRfX+NgpwHfYXw/p MK+Q/UIxmcMjf0I/PJgOdml1csucA2tJBKr1O3KT8dRaO7Wx597NK9jErIMgkagbcjcB/J8mCxL ZWOkv0Gg0cMNHM3gc1+92YMsCIX4ACYPTC9IAYImUHjoOBKd2m+V5CwHtFj5Mw/Nz+J5/hVGB8G o0LdTRJdbMsWvOOVt+UnbzKGn1XoiHGQUGy0uGSM1uG2xSlje+unFrNvuReyfkiBzg6F0GZ9zRN kSLZGuhkxomexMxixtDAOouohfK1ox/mzKUh+hLMBRVimKceKEd8ybg/LCw+R3/Lv6FG85UCQZA XGwhhguBw2OryS9ftdrX5pgSm9VpsGqhUYkk2+in2dfWEIVG9BTmLPRWOwyYMLDYnuxo54ZtJ7T j8kGfNh2RGqcdstVBVuOm3vyDvQDrrrZ1DXGstfqGVBzR0OJFrnelCDF1bF+MhUHQptoJACj2jj +g/+6JNFFJTRFUwLQUw== X-Proofpoint-GUID: QRy2YXKzGrWjbDLPtMGAmhfUddVY4Pu9 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-09-07_02,2026-09-03_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 spamscore=0 lowpriorityscore=0 clxscore=1011 adultscore=0 impostorscore=0 bulkscore=0 malwarescore=0 priorityscore=1501 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2609070098 On 2026/09/01 03:26 PM, nhuquynh@tutamail.com wrote: > From 80fd05e6d156d5a90d4908f2498bf6cc7acbdefd Mon Sep 17 00:00:00 2001 > From: Bui Nguyen Nhu Quynh > Date: Tue, 1 Sep 2026 19:39:49 +0700 > Subject: [PATCH] KVM: PPC: Fix callback check in kvmppc_gsm_refresh_info > > The kvmppc_gsm_refresh_info() function incorrectly checks for the > presence of the fill_info callback instead of refresh_info. > > This can lead to: > - NULL pointer dereference if refresh_info is NULL but fill_info is present > - EINVAL return if refresh_info is present but fill_info is NULL > > Fix this by checking the correct callback. > > Fixes: 6ccbbc33f06ad ("KVM: PPC: Add helper library for Guest State Buffers") > Signed-off-by: Bui Nguyen Nhu Quynh > --- > arch/powerpc/kvm/guest-state-buffer.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/powerpc/kvm/guest-state-buffer.c b/arch/powerpc/kvm/guest-state-buffer.c > index 42843eca6727..aeb586ba4523 100644 > --- a/arch/powerpc/kvm/guest-state-buffer.c > +++ b/arch/powerpc/kvm/guest-state-buffer.c > @@ -598,7 +598,7 @@ EXPORT_SYMBOL_GPL(kvmppc_gsm_fill_info); > int kvmppc_gsm_refresh_info(struct kvmppc_gs_msg *gsm, >     struct kvmppc_gs_buff *gsb) > { > - if (!gsm->ops->fill_info) > + if (!gsm->ops->refresh_info) > return -EINVAL; Thanks for catching this. The patch appears corrupted by your email client (whitespace mangling / quoted-printable encoding). ❯ git apply ./20260901_nhuquynh_kvm_ppc_fix_callback_check_in_kvmppc_gsm_refresh_info.mbx error: corrupt patch at line 30 Please consider configuring and using git send-email to submit v2. Thanks, Amit >   > return gsm->ops->refresh_info(gsm, gsb); > --  > 2.54.0