From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-yw1-f171.google.com (mail-yw1-f171.google.com [209.85.128.171]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7E51D442B3B for ; Mon, 7 Sep 2026 21:54:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.171 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788818097; cv=none; b=j0j2LzMYNWVN1TqgbSYE6vTkOytPSHNjHUZgJogq4zdS1efoBA1i98HqSra+GxkPffkR0PaJK25lzxkrM4e6mGVDL6tYhW5TE2SEFYr39Ud/JbSPmBtgzEStUHhpY+/6bctJ1fyr8i8FJ7Oo4Ep96A4oqZ4Vqujd8R9Oh+ztIhg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788818097; c=relaxed/simple; bh=UueUMpeCwNeGVdy3GJf5lm29xyeCkwc/aGA+P30mwdU=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=fa1M29MSqTAhFEWRASAwECtsL3RP8h18S3VtXwo/A3T9j+FhUBGi6JgXEPZii/KJfh2m8NfeMuuZp2EMhBuxpaue7Fx6WJKeacP3X7aaW0VARM1leJSl399MYeIGOVL5rMF31MS1/KYf68Wd82kN8SNc2mXVqlcjrliRZxS6Yjs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=j73ZnSGr; arc=none smtp.client-ip=209.85.128.171 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="j73ZnSGr" Received: by mail-yw1-f171.google.com with SMTP id 00721157ae682-8726acc5eadso26726087b3.0 for ; Mon, 07 Sep 2026 14:54:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1788818089; x=1789422889; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=8dBsS+uIQswAO+1Zq7ZFjEaF0vj6TxYTsi3HHjhGAsc=; b=j73ZnSGrWL60KlmfspddoXdvmb153n0+llSPhJJy5CQ5dPoVj7T90b0b0Ifx/3GKQa 7wbdHTPJ+HpGPwa8scBxlsxEctTL81MSiLHMQ3aD5s5mGxIuRAiNHaIDVSMmfn/G3Y2f EulYrEOSlZ4XO+zfRFhYfT54W+pDT0OrUtzOfHukN11SbDrhcs1FLl7kPxZC2aws8v04 PpUqkZMsm6yfx03LRUUABGR1g7deHfHKierqt3ertUQTVeZwzJFQ66tZ3ByF2VJPHv4z +XV8VaiW23XsFrQTGNWmkl/xBGJe5cy6WMVJeX04vwJwgTgT0u5CFLu/LQyWRdECsIjz 392w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1788818089; x=1789422889; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=8dBsS+uIQswAO+1Zq7ZFjEaF0vj6TxYTsi3HHjhGAsc=; b=I6v7ruNoesFLZvZFoa98dnh2kmqwjITdckFKtM/uKKwxpMZyTQQ+LwlKmxG39oap4t E0XvKFvHrI0g7gCUeLY/UawHDhlQfPX4nGCVcjGuMhcTzKD4+gn3kTTqf7vcF6hxbFvD JcDEqE4XdzZvgK0ZCo9yD+zJJumfiTr3LA0ejhVWbJZWodhS0HWpWadRpl/bDFw5NM5f /px2/MF3eG9FyqYYtJf0JH01q6pTLnuhgj32+gv0XrzCnc2PCn8WItqTdOEE9zD9Ng35 Tm3/ArvwbvHf+S+59MqcquIhNJj7qreyfdDVUf9yzG0WxYEXiKD9DQ1+Yv6/9DhMWXUJ zGqQ== X-Forwarded-Encrypted: i=1; AKwUvBwaf8U0TdOrlSEckvx53jOtMuNZLYdibTzGujFlGV9G1Fooq3nVc57l/uMWiO9NbjLqWWaoYzHUaQ1/MM0=@vger.kernel.org X-Gm-Message-State: AFuF++kxmJ+vi/PLkZCSHhNCzV9HCoI/V+dSJEmxhyr+WhiQBxzAfl7z ojWFvUfuZ3jACL0hkVBb3XSckYEdqeooWwCtigh9cAEjk9ELUzDY946D X-Gm-Gg: AYBFou2uJvJHGqny/30PZdb3n0wDr/QFoHtvn78SAMyxr0U3XEwmaq4zux2GgqJfsKX lUrDS4cwJRmD6fy83eEhsP3uZHqwNQMlPacdwgIBBdmUe4lEI6E4EgDSAISQ0OZBo9uuHg1Qjk/ 8Ckd+Sfh92OmbmjL0d74otPJS4IF4eKYKnufrKhV3CtTdJ7HXAGLYbHWW2hOFduo+bM8NCPndtE avulwSjaJmEEIcgB6VWuDyTNrWBszbYKzO7919qMa5xkY0tItvlu356Plm2ZMv74LKplnLnZ6+U C2GjNM3fX81oxlvnwMtz65ewM8Yy566hHlmAH7bRoQWEnv9tQsxT1G6x9b0wBnu/LYMxqtjyr3h xBpFeTYUFZerinFjMHNbnD9oUM/vQjkOomPFI3PgyX9g1itYKJhZ3gLUkkzgqX03ISEI69L2DXu 5WekNjO6Tu7ABUx5Dq4tqI4sL0H5XWOy5fEnPBHwHihgsTxTwdzzXFbdXKojA3AIb/qi/IoygCt OKUze1UKJ3AXVohY7dPA+PPz8Zc X-Received: by 2002:a05:690c:c4fa:b0:866:e57f:58db with SMTP id 00721157ae682-8711ec239e9mr98053137b3.0.1788818088629; Mon, 07 Sep 2026 14:54:48 -0700 (PDT) Received: from localhost (c-73-105-0-191.hsd1.fl.comcast.net. [73.105.0.191]) by smtp.gmail.com with ESMTPSA id 00721157ae682-8714c1e1eacsm78453177b3.49.2026.09.07.14.54.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 07 Sep 2026 14:54:48 -0700 (PDT) From: Yury Norov X-Google-Original-From: Yury Norov To: Andrew Lunn , Heiner Kallweit , Russell King , Raju Rangoju , Prashanth Kumar K R , Tony Nguyen , Przemek Kitszel , Jian Shen , Jijie Shao , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , linux-kernel@vger.kernel.org, netdev@vger.kernel.org, intel-wired-lan@lists.osuosl.org, linux-usb@vger.kernel.org Cc: Yury Norov , Yury Norov , Rasmus Villemoes , Andrew Morton Subject: [PATCH 8/9] r8152: use linkmode_and_and() in EEE checks Date: Mon, 7 Sep 2026 17:54:37 -0400 Message-ID: <20260907215439.409858-9-ynorov@nvidia.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260907215439.409858-1-ynorov@nvidia.com> References: <20260907215439.409858-1-ynorov@nvidia.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Combine the three link mode masks in a single operation and use its return value to determine whether EEE is active. Signed-off-by: Yury Norov --- drivers/net/usb/r8152.c | 10 ++++------ include/linux/linkmode.h | 8 ++++++++ 2 files changed, 12 insertions(+), 6 deletions(-) diff --git a/drivers/net/usb/r8152.c b/drivers/net/usb/r8152.c index f61686433031..75f0574fe1d4 100644 --- a/drivers/net/usb/r8152.c +++ b/drivers/net/usb/r8152.c @@ -9149,9 +9149,8 @@ static int r8152_get_eee(struct r8152 *tp, struct ethtool_keee *eee) if (speed & _100bps) linkmode_set_bit(ETHTOOL_LINK_MODE_100baseT_Full_BIT, common); - linkmode_and(common, common, eee->advertised); - linkmode_and(common, common, eee->lp_advertised); - eee->eee_active = !linkmode_empty(common); + eee->eee_active = linkmode_and_and(common, common, eee->advertised, + eee->lp_advertised); return 0; } @@ -9222,9 +9221,8 @@ static int r8153_get_eee(struct r8152 *tp, struct ethtool_keee *eee) if (speed & _100bps) linkmode_set_bit(ETHTOOL_LINK_MODE_100baseT_Full_BIT, common); - linkmode_and(common, common, eee->advertised); - linkmode_and(common, common, eee->lp_advertised); - eee->eee_active = !linkmode_empty(common); + eee->eee_active = linkmode_and_and(common, common, eee->advertised, + eee->lp_advertised); return 0; } diff --git a/include/linux/linkmode.h b/include/linux/linkmode.h index 49587a2e0f69..efd392dc62ae 100644 --- a/include/linux/linkmode.h +++ b/include/linux/linkmode.h @@ -26,6 +26,14 @@ static inline bool linkmode_and(unsigned long *dst, const unsigned long *a, return bitmap_and(dst, a, b, __ETHTOOL_LINK_MODE_MASK_NBITS); } +static inline bool linkmode_and_and(unsigned long *dst, + const unsigned long *a, + const unsigned long *b, + const unsigned long *c) +{ + return bitmap_and_and(dst, a, b, c, __ETHTOOL_LINK_MODE_MASK_NBITS); +} + static inline bool linkmode_and_andnot(unsigned long *dst, const unsigned long *a, const unsigned long *b, -- 2.53.0