From: Sophie D <patches@scd31.com>
To: rubenru09@aol.com
Cc: tzimmermann@suse.de, dri-devel@lists.freedesktop.org,
linux-kernel@vger.kernel.org, stable@vger.kernel.org,
Sophie D <patches@scd31.com>
Subject: [PATCH] drm/gud: Merge damage clips in full update mode
Date: Mon, 7 Sep 2026 19:08:49 -0400 [thread overview]
Message-ID: <20260907230849.31032-1-patches@scd31.com> (raw)
When running in full update mode, previously small updates (such as
moving the mouse across the screen) would cause many full frames to be
generated. This would bog down the bus and lower the effective framerate
significantly - I was seeing a drop from 60 FPS to 2 FPS.
This patch fixes the bug by merging damage clips together.
Fixes: 73cfd166e045 ("drm/gud: Replace simple display pipe with DRM atomic helpers")
Cc: <stable@vger.kernel.org> # 6.18.x
Signed-off-by: Sophie D <patches@scd31.com>
---
drivers/gpu/drm/gud/gud_pipe.c | 11 ++++++++---
1 file changed, 8 insertions(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/gud/gud_pipe.c b/drivers/gpu/drm/gud/gud_pipe.c
index 5ef887d84..20418bf81 100644
--- a/drivers/gpu/drm/gud/gud_pipe.c
+++ b/drivers/gpu/drm/gud/gud_pipe.c
@@ -647,9 +647,14 @@ void gud_plane_atomic_update(struct drm_plane *plane,
if (ret)
goto out;
- drm_atomic_helper_damage_iter_init(&iter, old_state, new_state);
- drm_atomic_for_each_plane_damage(&iter, &damage)
- gud_fb_handle_damage(gdrm, fb, &shadow_plane_state->data[0], &damage);
+ if (gdrm->flags & GUD_DISPLAY_FLAG_FULL_UPDATE) {
+ if (drm_atomic_helper_damage_merged(old_state, new_state, &damage))
+ gud_fb_handle_damage(gdrm, fb, &shadow_plane_state->data[0], &damage);
+ } else {
+ drm_atomic_helper_damage_iter_init(&iter, old_state, new_state);
+ drm_atomic_for_each_plane_damage(&iter, &damage)
+ gud_fb_handle_damage(gdrm, fb, &shadow_plane_state->data[0], &damage);
+ }
drm_gem_fb_end_cpu_access(fb, DMA_FROM_DEVICE);
--
2.55.0
next reply other threads:[~2026-09-07 23:17 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-07 23:08 Sophie D [this message]
2026-09-08 6:32 ` Thomas Zimmermann
2026-09-10 1:59 ` Sophie D
2026-09-10 1:49 ` [PATCH v2] drm/gud: Ignore " Sophie D
2026-09-10 6:17 ` Thomas Zimmermann
2026-09-12 12:21 ` Ruben Wauters
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260907230849.31032-1-patches@scd31.com \
--to=patches@scd31.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rubenru09@aol.com \
--cc=stable@vger.kernel.org \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®