From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f51.google.com (mail-wm1-f51.google.com [209.85.128.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 79A163AA9E2 for ; Tue, 8 Sep 2026 20:24:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.51 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788899048; cv=none; b=jbhZ3gEkgTebh9vmXn9x83dyE/dTARIEIGICL0rG2ByNk23lplAxx7CCIVQRme2FGuUMxhatzqBQ/U+p/s38I4/w8EmC4fjyz01ea3s6D3wK9WjmtKpktpYhIUCHA9cnQrIr+sRp79uzaUhuLhzVUnciOqytbDCoeCsGVoDHTBY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788899048; c=relaxed/simple; bh=fHmN0IfbJYKRxXiKNbPwjI+pza8hAMD/vlghiSxGeGk=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:To:Cc; b=D8Mxf4+94Rxw8qSug2kEdnk7n2D2H0ONQ090UAl3GPQyHH9jwxzzSGqyWFRhHFc+NKOIt5F8uKivx6U4tr7ie2qPsCr+ACDOxgVScn8Pt/6vqch3jER3V15D4lUTc7j/8sQy7YwZIkKtDc1UeMblh+lqaHWQgjyqWYyI8EWFNbg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=XAcP3aMb; arc=none smtp.client-ip=209.85.128.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="XAcP3aMb" Received: by mail-wm1-f51.google.com with SMTP id 5b1f17b1804b1-49b392ccaacso74938355e9.2 for ; Tue, 08 Sep 2026 13:24:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1788899045; x=1789503845; darn=vger.kernel.org; h=cc:to:message-id:content-transfer-encoding:content-type :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to:content-type; bh=1MqNm2QyW+y3V2DcOMpwDww7mcE4W2SOM19bQm3wPcg=; b=XAcP3aMbFY0oqYaXg5+6JcijyGHd64C0DK2vHxUwVvBgXtcx5TONIhTDNewvy5eF9z 2sR5N50OpFDFwOV+onVm7Pn44Me1P8UFi/zh54NmUOSG/vyNab9enjOcqAw62qHz8GnT K8i4P4Bff/BZGwPGgQT9HONsdXvOtyms2tDjszAf+WOjhTWgvu1389E+bV+61Fx9Ehch eG4H/qNNsliMNG/Tib9LSy3ov3D7PmbvldQZIgNjmsIhKRhvXHGpMfwERhf2rjOBhNEm iZGoJyc86Zh8+I4TA63q2B2IW5VImh/6oYuNp6l+DCIIwkBxwLQgWkqO3cf9K574v7Ek C1zw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1788899045; x=1789503845; h=cc:to:message-id:content-transfer-encoding:content-type :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to:content-type; bh=1MqNm2QyW+y3V2DcOMpwDww7mcE4W2SOM19bQm3wPcg=; b=l+Tw+XYqWsh0DyVBHHi8HQnr6aU0K36aCk8nU0zLKyjhDQ87x9S7OFwDDgKWXAZ4H3 o8ljCu9RLD/bn1vWI8vVpiTz9iGGWrCvHMbhdpsXvzctwuWRJdIUKUSvFYg2K0RFCIrm l8JKONMRNo++WmvpO/pPf+gohuwH5x6Drt1xZ30h059E4w5NX1vTY4zlgb10V7zfQmq2 Gdkh8SV4zkCQY75kZU2OHaoJqTk7lbA4xLtSgGK6FrRkyfn2Hz2l09FMte4IQPBXon4H gAjy7ku0UTD00UMbFKKCqRYzPc2cYgoyoxMPsjXW69tPQKQqflovAX/hzhdXtv/R/HgA SV0g== X-Forwarded-Encrypted: i=1; AKwUvBxyr74n+fANC3wURiZSG6GUmDldFT9UlYKaMBfX5bM4CMfNftsst9/M9aiINVr+n3fboIOc5ThqWE2HJwM=@vger.kernel.org X-Gm-Message-State: AFuF++lN9Xuzp6aRtCwpnqcSoFEyW5AEmn1rpvcwdAchgx59F5OyVkaF MJEgMwN2qrKwBs6iB0vkwA5mbs/WWwRxav7Os3xEN25HPsMnWjptYavN X-Gm-Gg: AYBFou1UuspmD4JlHGiOzJx4SRrpqczx8EYdbal8OqjgH/4JsHsbU92BV4IBRSH6NtL MmxZqzNLUmfW8fMMiUzV7IJfkKnJstU4rXj3DHo9C+cVNyYAbiU48x3vupDZgDACthgoG5q0O3n 3oGtq2t/QkesrZmDnRKz/nY40KSIqnQPbC6a5pptKwZeywlNJ3pSVQtUsUT0LdYbVXSec0fYcGz x+lG7fc9vJoqZveA7CvbuKKyxgSa1WZuzJaECbR5kITBJ0JEtkq4Xy9qlvjAC/cfWI+sDVkvQfn UulO+EKEuG5EBs2x5xRYQ6cfzXFXkW8Dqh5MqylqykA7isOUaCqqjZh3gP3nlqPbogw/PpxWGBS aKu4u5BQwlBe0J3fhBKsA6VGHyEVUNWjQTKpU42qLLnSyWD3iDgD/KQBjbyE6NjXrdYhOmNzLId FUxfS7GWUxFDmZ7qdYJAz0aqry59vMJ0nqeonDbq97qft8JsG3x9WgtH8nA1AXKvyUICtHVmtM5 DeiACxgtSGI0yOPdBw+Nrya0/zC X-Received: by 2002:a05:600d:8498:20b0:49c:cee0:f383 with SMTP id 5b1f17b1804b1-49cf828c65amr222198055e9.16.1788899044466; Tue, 08 Sep 2026 13:24:04 -0700 (PDT) Received: from [192.168.0.253] (5403F394.catv.pool.telekom.hu. [84.3.243.148]) by smtp.googlemail.com with ESMTPSA id 5b1f17b1804b1-49cf7703cc7sm418324665e9.4.2026.09.08.13.24.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 08 Sep 2026 13:24:03 -0700 (PDT) From: Gabor Juhos Date: Tue, 08 Sep 2026 22:23:55 +0200 Subject: [PATCH] spi: spi-qpic-snand: remove interim 'dev_data' variable from qcom_spi_probe() Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20260908-qpic-snand-drop-dev_data-var-v1-1-147d3fab6c48@gmail.com> X-B4-Tracking: v=1; b=H4sIAAAAAAAC/x3MwQqDMAwA0F+RnBfIylC3XxljhCZqLrVLRxHEf 7d4fJe3Q1E3LfDqdnCtVmxNDfdbB3HhNCuaNEOg0NOTRvxli1gSJ0HxNaNo/Qr/GSs7Tr0OD4q RQhigFdl1su3q35/jOAFXsgszbgAAAA== X-Change-ID: 20260908-qpic-snand-drop-dev_data-var-f6e740cc0227 To: Mark Brown Cc: linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org, Gabor Juhos X-Mailer: b4 0.14.3 The dev_data variable in the qcom_spi_probe() function is only used to temporarily store a pointer of the device specific data before that value gets assigned to 'snandc->props'. Remove the interim variable and use 'snandc->props' directly instead in order to simplify the code. No functional changes. Signed-off-by: Gabor Juhos --- drivers/spi/spi-qpic-snand.c | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/drivers/spi/spi-qpic-snand.c b/drivers/spi/spi-qpic-snand.c index 61b1f2eb19ce..9eafaea74f6b 100644 --- a/drivers/spi/spi-qpic-snand.c +++ b/drivers/spi/spi-qpic-snand.c @@ -1585,7 +1585,6 @@ static int qcom_spi_probe(struct platform_device *pdev) struct qpic_spi_nand *qspi; struct qpic_ecc *ecc; struct resource *res; - const void *dev_data; int ret; ecc = devm_kzalloc(dev, sizeof(*ecc), GFP_KERNEL); @@ -1613,14 +1612,12 @@ static int qcom_spi_probe(struct platform_device *pdev) snandc->qspi->ctlr = ctlr; snandc->qspi->ecc = ecc; - dev_data = of_device_get_match_data(dev); - if (!dev_data) { + snandc->props = of_device_get_match_data(dev); + if (!snandc->props) { dev_err(&pdev->dev, "failed to get device data\n"); return -ENODEV; } - snandc->props = dev_data; - snandc->core_clk = devm_clk_get_enabled(dev, "core"); if (IS_ERR(snandc->core_clk)) return PTR_ERR(snandc->core_clk); --- base-commit: cb2ad3c020579bf51fb0d702db9cf64af9698377 change-id: 20260908-qpic-snand-drop-dev_data-var-f6e740cc0227 Best regards, -- Gabor Juhos