From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AA32E430CD9 for ; Mon, 7 Sep 2026 20:23:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788812629; cv=none; b=A4CRhKTXv/UIitg78bmym8spNrwYH6Wp1ntlBr1PxaBj+I9xX/44e3kbupIBStb2XgqUUfH4NscIt150GstTEcXoqNCu8qabFlHDCDnn4XYUwokNnQqBAtJ9b/WRUhde+sfv3T+q5Y8cyzsFVy/ULapBsq6AUr17HDkcdaAsHLE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788812629; c=relaxed/simple; bh=sCoXPX0Yq3nwo2KsW4jRgJUZwqT/+Xni0RoFlfYySqI=; h=From:Subject:Date:Message-Id:MIME-Version:Content-Type:To:Cc; b=IttfeJeNxKc/7Rl94/BQOVIafSSiNiMGOGXdEyfX5/GJ1k9c6pHdMg33teA0xQfJyuswNlDQwpmbL5xuxbzbg0Rh10zKB9iyu0s8GvUF+dxUCEXadntF1mTNyd/By+rU1uL6GQ51cylYJFBB2+G2wrj+37hzFnUCoh4GP5ar2xM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=UKNG4VVL; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=XcCVLBgW; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="UKNG4VVL"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="XcCVLBgW" Received: from pps.filterd (m0279868.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 687H8its416353 for ; Mon, 7 Sep 2026 20:23:46 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:message-id :mime-version:subject:to; s=qcppdkim1; bh=e5PAjbyonBBX8bCa9McFT9 c18q9TrMpdt4SO1ARd2xg=; b=UKNG4VVL9PcmSwbztCVmkPvy8YlAl72UQcaL9F 8rzc9blmq146RZrd2A/qvnRzMu81FBLzOdh8oTTr76IX58bQa6dG7hgwoman8E6M 8P5BG7pF/lMgV9FCA29bdfV9gU2i05WVIDrUSA7gjWwdVvmQrRSDnetlg4Nua73U v8K71Hk7TcZOkJ3l97bTJnLyjOuAXc8x/iRiPY66bdysQbpJ2M+YAPsq0/zu7PTn ld2wJIkP/XTzJ07b12Skvx2M3g7CaQbYlwhdDP5w3BesqnxdnCmUa6SjiLMFddiQ LATAZ2f7sptL6v/qRN0ad33O2gctUIEV13zcRDfEgea74hQw== Received: from mail-pl1-f199.google.com (mail-pl1-f199.google.com [209.85.214.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4ghsfyjju8-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 07 Sep 2026 20:23:46 +0000 (GMT) Received: by mail-pl1-f199.google.com with SMTP id d9443c01a7336-2d02df2bf09so32453025ad.0 for ; Mon, 07 Sep 2026 13:23:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1788812625; x=1789417425; darn=vger.kernel.org; h=cc:to:content-transfer-encoding:content-type:mime-version :message-id:date:subject:from:from:to:cc:subject:date:message-id :reply-to:content-type; bh=e5PAjbyonBBX8bCa9McFT9c18q9TrMpdt4SO1ARd2xg=; b=XcCVLBgW/6RK+gDaws6Uva70+GfiMptNlzLZV6kRKvWFlWQJu9FqbKb8bWWIiiGJRN UQg7kpclNJaiwdIkuSHNq/d0GJzySpGd04oCMUcb421HyhXGX5RWEEZ7Xq5OL8VEH0Fw 6eyEpA2v8piJZ8vEEMf4dIQoNbYfWkhJI6ozAcFxg8rMUqy3R94xqLhaqrEoztxmOnAU vVgIPcOIGORvVIJEmowJREFHFCsH2vZPUIG3rql/bxMvCIE+6UJVOjUU4DhJZCzmSRDf YoBrx/I4BPNUdQFrpkdZUjsmu89axmk85GzxES09NjWfYB3LMe03evyRzd0Znw13Kt91 FTew== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1788812625; x=1789417425; h=cc:to:content-transfer-encoding:content-type:mime-version :message-id:date:subject:from:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to:content-type; bh=e5PAjbyonBBX8bCa9McFT9c18q9TrMpdt4SO1ARd2xg=; b=EO7X//t5B94raSjVoZ3slLnCCGXYSvs7YY1jLNVaqcju67dCaTVxMFhTA9Nc1VMNHz TFUM3kIqaFpF8qGv6AULpdF1DrFqs3KjZwpE9pywOcazAlpQNUyGQ9P3s0jDcCCGr43C iqmSvVawchFCQaaUkcCLliMWsCOgqxekwXCe2+B5LblZxnUlPuXBLl7UnJ8YGc6BhoLB +mZSm73MQaDK+iFdqG4Z99aMKQX2yn30XWGDCDhac3U6pHenky37XGLsNCG2RdQEQ+Vs 19VQC0r4Zy1DoxejsaZHdbGxrYe5256ccmhMjoPYXMERqYlr6H88EINbfScxeZYhP2uU n5OQ== X-Forwarded-Encrypted: i=1; AKwUvBwCu3g0JKGCxoCPTD6C2o5OMKHhvhk1gIy5XoLrTS0XiiPsYEsjQZHysxelJNoXW6CnA/1dLtPWKwT7+aY=@vger.kernel.org X-Gm-Message-State: AFuF++lICSNw/5SD7DCCt+AwSDZaNu0jfwRvagU5dYpMWGKz/8mphoIg NN9PfFjd44Bd0NpElaMF2uiYc+2NY0OtMynhKyclX6sQfXRQSxA5jw6svBhmdByoSdB5ngbWaqs qPVQuDzoWFJCcXEZpir9DuNcvDD0FmbpJVsja3ZDhp6Rdhv2jMJSq/iNnC685Kt9g3Vo= X-Gm-Gg: AYBFou2XVnLLizQNFQNx52vQDz3F1LFSlasmg5HVwCYtRiIGlwAdwMYFsSkzPNO4IVh iNqnl4Yv8IIi2BmGceX86OX//KfFo7DnL7kFM09NdhkPePdrK23osmMQ/rLCvIW4Zf5FmKS4Ri2 eiW7381Jah0ohvvkBaKUC2cOMzBYhJlq9V/+skik5Ov1mJpNm8tjGSY/nkjoIusf6TVTBC4itKT bsHnyJ2gKjSMng24b2b4/vl4Q3tkesO9mhTOr+uq96ix75OpfchZIAuzDOekw269nR+D5tHgGzF 9NCHXcRBojAnpJyTrwin1GtrsuvdF6aJy5zFHGXe8WXTlEFrxfTHASjkpvNpMf/nWgMaylCsWD6 gWON4Pq9nab0Dj3mRyovrJnZMhQGxwA== X-Received: by 2002:a17:903:2acc:b0:2db:5f8c:b81c with SMTP id d9443c01a7336-2db5f8cca7emr98859705ad.19.1788812625366; Mon, 07 Sep 2026 13:23:45 -0700 (PDT) X-Received: by 2002:a17:903:2acc:b0:2db:5f8c:b81c with SMTP id d9443c01a7336-2db5f8cca7emr98859205ad.19.1788812624902; Mon, 07 Sep 2026 13:23:44 -0700 (PDT) Received: from hu-mohdayaa-hyd.qualcomm.com ([202.46.23.25]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-3339b314cfcsm30482259eec.19.2026.09.07.13.23.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 07 Sep 2026 13:23:44 -0700 (PDT) From: Mohd Ayaan Anwar Subject: [PATCH net-next v2 0/9] net: stmmac: qcom-ethqos: add Shikra EMAC support Date: Tue, 08 Sep 2026 01:53:12 +0530 Message-Id: <20260908-shikra_ethernet-v2-0-bbe3389d0652@oss.qualcomm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-B4-Tracking: v=1; b=H4sIADAdn2oC/2WNzQrCMBCEX6Xs2ZTtT1rryfeQIrGuJmgTzcZSK Xl3Y/HmZWCYmW8WYPKGGHbZAp4mw8bZZMpNBoNW9krCnJOHEssGO6wEa3Pz6khBk7cUhKL2RCR pizVBWj08Xcy8Eg/wLViaA/Qp0YaD8+/1airW/Eet/6hTIVAoiW0ju67BSu4dc/58qfvgxjFPA n2M8QPUp3oPvwAAAA== X-Change-ID: 20260903-shikra_ethernet-ae7bee5e804e To: Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Andrew Davis , Andrew Lunn , Heiner Kallweit , Russell King , Richard Cochran , Bjorn Andersson , Konrad Dybcio , Alexandre Torgue , Giuseppe Cavallaro , Jose Abreu , Maxime Chevallier , Maxime Coquelin Cc: netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, Mohd Ayaan Anwar X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1788812616; l=4796; i=mohd.anwar@oss.qualcomm.com; s=20250907; h=from:subject:message-id; bh=sCoXPX0Yq3nwo2KsW4jRgJUZwqT/+Xni0RoFlfYySqI=; b=QME481dA0bhoLDbSXBYvkMkG9PXW95sYcvKCvp0H/2aDSQm5oUiL0uE7DBoI9GRnvPX8bWmbQ AEBWe4ah61QBm6PRK35q5+XDrpbYYT+TVgR/wD3NFmzdc3094MQn8L8 X-Developer-Key: i=mohd.anwar@oss.qualcomm.com; a=ed25519; pk=7JNY72mz7r6hQstsamPYlUbLhQ5+W64pY4LgfSh9DJU= X-Proofpoint-ORIG-GUID: t5ZNF9l5MLJiJOcT54hlGvbZn1KGGrby X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwOTA3MDIyNCBTYWx0ZWRfXwbqk4W8EI+U0 rYYUKpmsSZ6lTh8Zsu267dKSJc1RooqKHrL5xwkYhUOkRi2pcY1dxBhlOWqkNoHaTGa+dNMYf4i q8t+M2NbQ0eCy6AxXhlZynB1w2Re3hDlZqybR81fNmaVJWcvkEYrGBk41AcO0ind7oWH+LUOhev WWfHr0R3nzmjOaf8fl5gBw7+DHcPOy9hgU9++tt3iasNc/zA/dMQGjKZLZoT/1ztQpyEMhlUuV4 rkJguwSuI/J1O1Naba6mTWzHLqFQR6symO2f2eSt94cQnkS18igJQaNQtww2oo7yZOaDZeQVvzh nyKONyMTrxXGNynftgp+PQ1qA4h9OfisbHYHi88CpoRcuP8wsTSP8SI9fFUF3mdkaah+eX/+J1Y EBNJPXS8hi8NMj1yAMl7rD2xOyabtGM4hcEbUnGVqEAPWE36aFoW41fOpnlPxM7yIEqRAh3dZKC J/tfyqRINz6k1en2UVQ== X-Proofpoint-GUID: t5ZNF9l5MLJiJOcT54hlGvbZn1KGGrby X-Proofpoint-Spam-Info: AW1haW4tMjYwOTA3MDIyNCBTYWx0ZWRfX09kDyf04RQTS zvXzQdaEIsy0KrT25Ayg08sdRgQeDfVz8DJX7ebRLao107W1Zi+KVjDxjCiFxfcrYt2uw+XfhI9 eUK2ya0+eBLBa7u30QPTWWk/jFrJgl4= X-Authority-Analysis: v=2.4 cv=AduB2XXG c=1 sm=1 tr=0 ts=6a9f1d52 cx=c_pps a=JL+w9abYAAE89/QcEU+0QA==:117 a=ZePRamnt/+rB5gQjfz0u9A==:17 a=IkcTkHD0fZMA:10 a=VdqzKS8jKosA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=ZpdpYltYx_vBUK5n70dp:22 a=VwQbUJbxAAAA:8 a=ee_2aqc6AAAA:8 a=EUspDBNiAAAA:8 a=ci5OYPSUn-HddWIvASoA:9 a=QEXdDO2ut3YA:10 a=324X-CrmTo6CU4MGRt3R:22 a=VOpmJXOdbJOWo2YY3GeN:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-09-07_05,2026-09-07_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 lowpriorityscore=0 spamscore=0 bulkscore=0 adultscore=0 phishscore=0 clxscore=1015 suspectscore=0 priorityscore=1501 malwarescore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2609070224 This series incorporates feedback from the RFC and adds the dt-bindings and driver changes required to enable Gigabit Ethernet support on the Qualcomm Shikra SoC. DTS changes will be sent out separately. The series has grown from the RFC and can be broadly divided into three areas: PHY power supply management, proper support for RGMII ID mode in the Qualcomm ETHQOS driver, and Shikra specific clock dependencies required for NOC access. 1. Shikra EVK boards use a GPIO-gated regulator for the DP83867 PHY power supply. Patches 1 and 2 add supply management to the DP83867 driver so the PHY driver holds the regulator vote at probe. These changes are largely inspired by similar work done for the QCA8081 PHY: https://lore.kernel.org/netdev/20260605010022.968612-3-elder@riscstar.com/ 2. The generic RGMII fixes from the RFC remain. As suggested, an additional patch now emits a warning (patch 6) when the legacy "rgmii" or "rgmii-txid" modes are detected. A new change (patch 7) now initialises the RGMII link clock at SPEED_10 on probe instead of SPEED_1000, dropping the unnecessary 250 MHz source before link up. 3. NOC clock voting (patch 8) now uses dev_pm_opp_set_rate() so the required VDD_CX performance state can be propagated through the clock controller. The Shikra binding (patch 3) is updated accordingly: an if/else block constrains Shikra to exactly six clocks and requires operating-points-v2. Testing: The following boards have been tested with this new (proper) handling for RGMII ID: - Shikra CQ/IQ variants (with the TI DP83867 PHY) - QCS615 Ride (with the Micrel KSZ9031 PHY) - Talos EVK (again with the Micrel KSZ9031 PHY) - Talos Lyra EVK (TI DP83867 PHY, this board also has a GPIO-gated regulator for the PHY power supply) Changes in v2: - Collected Maxime's Reviewed-by tags. - Updated Patch 9's commit message to explain the double enable vote on the "stmmaceth" clock. Open to discussion on how best to handle this. - Wrapped regulator vote for dp83867 inside an #ifdef CONFIG_OF check to avoid adding an unnecessary 200 ms delay on systems where devm_regulator_get_enable_optional() would return 0. The change now mirrors the QCA8081 patch -- Sashiko. - Fixed ethqos_set_clk_tx_rate() to double the rate for all PHY modes other than RGMII-ID -- Sashiko. - Moved warning about the use of non RGMII-ID mode to probe instead of fix_mac_speed to avoid spamming during each link up event -- Sashiko. - Fixed error unwind drops OPP before stopping link_clk -- Sashiko. - Fixed OPP vote set in probe not cleaned up on error -- Sashiko. - Link to v1: https://lore.kernel.org/netdev/20260904-shikra_ethernet-v1-0-a50765996035@oss.qualcomm.com/#t Changes since RFC: - Two new patches add supply management for the DP83867, replacing the gpio-hog approach for PHY power -- Konrad, Andrew. - Use dev_pm_opp_set_rate() for the NOC AXI clock and require operating-points-v2 for Shikra -- Konrad. - Warn on legacy "rgmii"/"rgmii-txid" to encourage DTB migration -- Andrew, Maxime. - Updated binding document for qcom,ethqos and snps,dwmac. - Drop the duplicate "axi" clock from Shikra's DT; use "axi-noc" and "pcie-tile-axi-noc" as the only additional clock-names. - Initialise RGMII link clock at SPEED_10 rather than SPEED_1000 on probe. - Link to RFC: https://lore.kernel.org/netdev/20260612-shikra_ethernet-v1-0-f0f4a1d19929@oss.qualcomm.com/ Signed-off-by: Mohd Ayaan Anwar --- Mohd Ayaan Anwar (9): dt-bindings: net: ti,dp83867: add supply properties net: phy: dp83867: add regulator supply management dt-bindings: net: qcom,ethqos: add qcom,shikra-ethqos compatible net: stmmac: qcom-ethqos: convert ethqos_rgmii_macro_init() to void net: stmmac: qcom-ethqos: fix RGMII_ID mode to use DLL bypass net: stmmac: qcom-ethqos: warn about legacy RGMII PHY modes net: stmmac: qcom-ethqos: set initial RGMII link clock to lowest speed net: stmmac: qcom-ethqos: add per-platform NOC clock voting net: stmmac: qcom-ethqos: add Shikra EMAC support .../devicetree/bindings/net/qcom,ethqos.yaml | 50 ++++- .../devicetree/bindings/net/snps,dwmac.yaml | 2 + .../devicetree/bindings/net/ti,dp83867.yaml | 14 ++ .../ethernet/stmicro/stmmac/dwmac-qcom-ethqos.c | 218 +++++++++++++++++++-- drivers/net/phy/dp83867.c | 33 ++++ 5 files changed, 300 insertions(+), 17 deletions(-) --- base-commit: 7042c8c193e5d634198b7c766bb3a01c8e3ee0e2 change-id: 20260903-shikra_ethernet-ae7bee5e804e Best regards, -- Mohd Ayaan Anwar