From: "Mario Limonciello (AMD)" <superm1@kernel.org>
To: K Prateek Nayak <kprateek.nayak@amd.com>
Cc: Perry Yuan <perry.yuan@amd.com>,
linux-kernel@vger.kernel.org (open list:X86 ARCHITECTURE (32-BIT
AND 64-BIT)),
linux-pm@vger.kernel.org (open list:CPU FREQUENCY SCALING
FRAMEWORK), Vishal Badole <Vishal.Badole@amd.com>,
Richard Gong <Richard.Gong@amd.com>,
"Mario Limonciello (AMD)" <superm1@kernel.org>,
Christian Ludloff <ludloff@gmail.com>
Subject: [PATCH v2 3/3] cpufreq/amd-pstate: Show a warning if missing EPP tunings
Date: Mon, 7 Sep 2026 23:19:35 -0500 [thread overview]
Message-ID: <20260908041935.402116-4-superm1@kernel.org> (raw)
In-Reply-To: <20260908041935.402116-1-superm1@kernel.org>
EPP tunings are going to be more important going forward. Show a warning
if on a heterogenous platform without them.
Suggested-by: Christian Ludloff <ludloff@gmail.com>
Signed-off-by: Mario Limonciello (AMD) <superm1@kernel.org>
---
drivers/cpufreq/amd-pstate.c | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/drivers/cpufreq/amd-pstate.c b/drivers/cpufreq/amd-pstate.c
index 543ec143efc94..7c1f8ca7b7f72 100644
--- a/drivers/cpufreq/amd-pstate.c
+++ b/drivers/cpufreq/amd-pstate.c
@@ -2390,8 +2390,12 @@ static void __init amd_pstate_init_epp_values(void)
const struct x86_cpu_id *id = x86_match_cpu(amd_pstate_epp_soc_ids);
const struct amd_pstate_epp_soc *soc;
- if (!id || !id->driver_data)
+ if (!id || !id->driver_data) {
+ if (cpu_feature_enabled(X86_FEATURE_ZEN6) &&
+ cpu_feature_enabled(X86_FEATURE_AMD_HTR_CORES))
+ pr_warn_once("No EPP tunings found for platform\n");
return;
+ }
soc = (const struct amd_pstate_epp_soc *)id->driver_data;
--
2.43.0
prev parent reply other threads:[~2026-09-08 4:19 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-08 4:19 [PATCH v2 0/3] Add support for Zen 6 client " Mario Limonciello (AMD)
2026-09-08 4:19 ` [PATCH v2 1/3] cpufreq/amd-pstate: Add per SoC and per core type EPP tuning values Mario Limonciello (AMD)
2026-09-08 6:19 ` K Prateek Nayak
2026-09-08 19:38 ` Mario Limonciello
2026-09-08 4:19 ` [PATCH v2 2/3] cpufreq/amd-pstate: Add EPP tunings for Zen6 client platforms Mario Limonciello (AMD)
2026-09-08 4:19 ` Mario Limonciello (AMD) [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260908041935.402116-4-superm1@kernel.org \
--to=superm1@kernel.org \
--cc=Richard.Gong@amd.com \
--cc=Vishal.Badole@amd.com \
--cc=kprateek.nayak@amd.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=ludloff@gmail.com \
--cc=perry.yuan@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®