From: Zenghui Yu <zenghui.yu@linux.dev>
To: linux-mm@kvack.org, linux-kselftest@vger.kernel.org,
linux-kernel@vger.kernel.org
Cc: akpm@linux-foundation.org, david@kernel.org, ljs@kernel.org,
liam@infradead.org, vbabka@kernel.org, rppt@kernel.org,
surenb@google.com, mhocko@suse.com, shuah@kernel.org,
gourry@gourry.net, "Zenghui Yu (Huawei)" <zenghui.yu@linux.dev>
Subject: [PATCH v2 3/3] selftests/mm: init page sizes early in pagemap_ioctl test
Date: Tue, 8 Sep 2026 21:44:05 +0800 [thread overview]
Message-ID: <20260908134405.84448-1-zenghui.yu@linux.dev> (raw)
In-Reply-To: <20260908134117.84405-1-zenghui.yu@linux.dev>
From: "Zenghui Yu (Huawei)" <zenghui.yu@linux.dev>
Initialize page_size and hpage_size before calling init_uffd(),
hugetlb_setup_default(), etc. That won't fix anything, but it is safer and
saner to get these globals set up before doing other things.
While at it, drop the page_size parameter of transact_test(), which is
actually unnecessary.
Suggested-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Zenghui Yu (Huawei) <zenghui.yu@linux.dev>
---
tools/testing/selftests/mm/pagemap_ioctl.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/tools/testing/selftests/mm/pagemap_ioctl.c b/tools/testing/selftests/mm/pagemap_ioctl.c
index 1a87b7483316..d9a4fb782ecf 100644
--- a/tools/testing/selftests/mm/pagemap_ioctl.c
+++ b/tools/testing/selftests/mm/pagemap_ioctl.c
@@ -1489,7 +1489,7 @@ static void *thread_proc(void *mem)
return NULL;
}
-static void transact_test(int page_size)
+static void transact_test(void)
{
unsigned int i, count, extra_pages;
unsigned int c;
@@ -1653,6 +1653,9 @@ int main(int __attribute__((unused)) argc, char *argv[])
ksft_print_header();
+ page_size = getpagesize();
+ hpage_size = read_pmd_pagesize();
+
if (init_uffd())
ksft_exit_skip("Failed to initialize userfaultfd\n");
@@ -1661,9 +1664,6 @@ int main(int __attribute__((unused)) argc, char *argv[])
ksft_set_plan(119);
- page_size = getpagesize();
- hpage_size = read_pmd_pagesize();
-
pagemap_fd = open(PAGEMAP, O_RDONLY);
if (pagemap_fd < 0)
ksft_exit_fail_msg("Failed to open " PAGEMAP "\n");
@@ -1823,7 +1823,7 @@ int main(int __attribute__((unused)) argc, char *argv[])
mprotect_tests();
/* 13. Transact test */
- transact_test(page_size);
+ transact_test();
/* 14. Sanity testing */
sanity_tests();
--
2.53.0
next prev parent reply other threads:[~2026-09-08 13:44 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-08 13:41 [PATCH v2 0/3] selftests/mm: pagemap_ioctl test fixes and cleanups Zenghui Yu
2026-09-08 13:41 ` [PATCH v2 1/3] selftests/mm: fix size truncation in pagemap_ioctl test Zenghui Yu
2026-09-08 13:43 ` [PATCH v2 2/3] selftests/mm: mark file-local symbols of pagemap_ioctl.c static Zenghui Yu
2026-09-08 13:44 ` Zenghui Yu [this message]
2026-09-08 13:50 ` [PATCH v2 3/3] selftests/mm: init page sizes early in pagemap_ioctl test Zenghui Yu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260908134405.84448-1-zenghui.yu@linux.dev \
--to=zenghui.yu@linux.dev \
--cc=akpm@linux-foundation.org \
--cc=david@kernel.org \
--cc=gourry@gourry.net \
--cc=liam@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=ljs@kernel.org \
--cc=mhocko@suse.com \
--cc=rppt@kernel.org \
--cc=shuah@kernel.org \
--cc=surenb@google.com \
--cc=vbabka@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®