From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mta1.migadu.com (out-127.mta1.migadu.com [95.215.58.127]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EA91D53ED1D for ; Tue, 8 Sep 2026 14:26:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=95.215.58.127 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788877603; cv=none; b=o3INfb+WeQfDN5W69oU9Js6tVrBWVVbb9VGsqpMWRp53yPeN5Emu04VaKX13XfJlAzb03G8q5UXA6fOa2yLIsThD4/QxQILVHjSUmJ9u7d0l3e6qsiEVbBBYD0f0bIF68LYeZCtiO29luLBUEQov0EZ/2ngiAv8hfY2gmNzf2JY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788877603; c=relaxed/simple; bh=s9TT0fZk57NAYbdQgPZkg4s8vZfT60FtoXTyRRE+hbY=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=UdID1+8a9VVVWGd0RWcgxtLVkDPor+Ha3/Q/ewYioqqNKqTCQ/xoXw1twoDQYXJPDa9+4jVlI0qYeaorUT82jpJG0QJajQqu5yUjZBEAw7WHgpYGhNMaKa4q4IR/KjQnyRXMAGk/1p4sroRNYsslMSatYtO2NubrLGHRGwBDTY0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=oUf2b2Me; arc=none smtp.client-ip=95.215.58.127 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="oUf2b2Me" X-Envelope-To: linux-kernel@vger.kernel.org DKIM-Signature: a=rsa-sha256; bh=s9TT0fZk57NAYbdQgPZkg4s8vZfT60FtoXTyRRE+hbY=; c=simple/simple; d=linux.dev; h=from:to:subject:date:message-id:mime-version:content-type; s=key1; t=1788877594; v=1; x=1789482394; b=oUf2b2Me5yQ1AkdLjcXZPsY7ezdSRSf+FZqsh6OeISavuE1DxUeM4PkWAKetZy6F/KgvOdTk 7YjM/Zm4Oj25/F61ESN1YtuOf0/UIxjFagO+BoPqwcXGe2jsfoNh+pG3w11trKG/0qEeEuiFq4r KaIfZarT0vQOs2O8ZK+a/KCU= X-Envelope-To: linux-kernel@vger.kernel.org Received: by smtp.migadu.com with ESMTPS id 14221e000fbbf8e3; Tue, 08 Sep 2026 14:26:34 +0000 X-Mizu-Trace-ID: 14221e000fbbf8e3 X-Migadu-Flow: FLOW_OUT From: Fuad Tabba To: Marc Zyngier , Thomas Gleixner Cc: Radu Rendec , Kemeng Shi , Will Deacon , Fuad Tabba , stable@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH 1/3] irqchip/gic-v3: Release the partition node in gic_irq_get_fwspec_info() Date: Tue, 8 Sep 2026 15:26:30 +0100 Message-Id: <20260908142632.2795308-2-fuad.tabba@linux.dev> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20260908142632.2795308-1-fuad.tabba@linux.dev> References: <20260908142632.2795308-1-fuad.tabba@linux.dev> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit gic_irq_get_fwspec_info() never puts the node it takes from of_find_node_by_phandle(), so every lookup from a four-cell PPI or EPPI specifier naming a partition leaks one. The node is only used for the comparison against gic_data.parts[], and the mask returned points into gic_data, so it can go out of scope with the lookup. Fixes: 68905ea65ceff ("irqchip/gic-v3: Add FW info retrieval support") Signed-off-by: Fuad Tabba --- drivers/irqchip/irq-gic-v3.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/irqchip/irq-gic-v3.c b/drivers/irqchip/irq-gic-v3.c index 6e1fa5b247fc4..b0142b0a93fa4 100644 --- a/drivers/irqchip/irq-gic-v3.c +++ b/drivers/irqchip/irq-gic-v3.c @@ -1728,8 +1728,6 @@ static int gic_irq_get_fwspec_info(struct irq_fwspec *fwspec, struct irq_fwspec_ /* If the specifier provides an affinity, use it */ if (fwspec->param_count == 4 && fwspec->param[3]) { - struct fwnode_handle *fw; - switch (fwspec->param[0]) { case 1: /* PPI */ case 3: /* EPPI */ @@ -1738,7 +1736,10 @@ static int gic_irq_get_fwspec_info(struct irq_fwspec *fwspec, struct irq_fwspec_ return 0; } - fw = of_fwnode_handle(of_find_node_by_phandle(fwspec->param[3])); + struct device_node *np __free(device_node) = + of_find_node_by_phandle(fwspec->param[3]); + struct fwnode_handle *fw = of_fwnode_handle(np); + if (!fw) return -ENOENT; -- 2.39.5