mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: David Sterba <dsterba@suse.cz>
To: Tal Zussman <tz2294@columbia.edu>
Cc: David Sterba <dsterba@suse.com>, Chris Mason <mason@kernel.org>,
	Qu Wenruo <wqu@suse.com>,
	linux-btrfs@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 12/15] btrfs: remove the free space inode ordered extent special cases
Date: Tue, 8 Sep 2026 17:42:31 +0200	[thread overview]
Message-ID: <20260908154231.GE9053@twin.jikos.cz> (raw)
In-Reply-To: <20260907-btrfs-remove-v1-space-cache-v1-12-5f9a5ba352a7@columbia.edu>

On Mon, Sep 07, 2026 at 09:19:27PM -0400, Tal Zussman wrote:
> --- a/fs/btrfs/transaction.c
> +++ b/fs/btrfs/transaction.c
> @@ -125,17 +125,14 @@ static const unsigned int btrfs_blocked_trans_types[TRANS_STATE_MAX] = {
>  	[TRANS_STATE_UNBLOCKED]		= (__TRANS_START |
>  					   __TRANS_ATTACH |
>  					   __TRANS_JOIN |
> -					   __TRANS_JOIN_NOLOCK |
>  					   __TRANS_JOIN_NOSTART),
>  	[TRANS_STATE_SUPER_COMMITTED]	= (__TRANS_START |
>  					   __TRANS_ATTACH |
>  					   __TRANS_JOIN |
> -					   __TRANS_JOIN_NOLOCK |
>  					   __TRANS_JOIN_NOSTART),
>  	[TRANS_STATE_COMPLETED]		= (__TRANS_START |
>  					   __TRANS_ATTACH |
>  					   __TRANS_JOIN |
> -					   __TRANS_JOIN_NOLOCK |
>  					   __TRANS_JOIN_NOSTART),
>  };

This touches the transaction engine, there was exception for the space
cache, I'm not sure if we want to remove it completely. At least it
would be good to separate the space cache usage and the the API in case
we'd want to restore it some day.

  reply	other threads:[~2026-09-08 15:42 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-08  1:19 [PATCH 00/15] btrfs: remove the v1 space cache Tal Zussman
2026-09-08  1:19 ` [PATCH 01/15] btrfs: stop enabling the v1 space cache from the on-disk state Tal Zussman
2026-09-08  1:19 ` [PATCH 02/15] btrfs: remove the v1 space cache writeout from the transaction commit Tal Zussman
2026-09-08  1:19 ` [PATCH 03/15] btrfs: remove the free space cache endio workqueue Tal Zussman
2026-09-08  1:19 ` [PATCH 04/15] btrfs: remove the v1 space cache write path Tal Zussman
2026-09-08  1:19 ` [PATCH 05/15] btrfs: drop the transaction handle from the prealloc helpers Tal Zussman
2026-09-08  1:19 ` [PATCH 06/15] btrfs: remove the v1 space cache load path Tal Zussman
2026-09-08  1:19 ` [PATCH 07/15] btrfs: remove btrfs_disk_cache_state Tal Zussman
2026-09-08  1:19 ` [PATCH 08/15] btrfs: remove the SPACE_CACHE mount option flag Tal Zussman
2026-09-08  1:19 ` [PATCH 09/15] btrfs: replace btrfs_set_free_space_cache_v1_active() with a cleanup helper Tal Zussman
2026-09-08  1:19 ` [PATCH 10/15] btrfs: remove the free space cache trimming ranges Tal Zussman
2026-09-08  1:19 ` [PATCH 11/15] btrfs: remove BTRFS_RESERVE_FLUSH_FREE_SPACE_INODE Tal Zussman
2026-09-08  1:19 ` [PATCH 12/15] btrfs: remove the free space inode ordered extent special cases Tal Zussman
2026-09-08 15:42   ` David Sterba [this message]
2026-09-08 22:27     ` Tal Zussman
2026-09-08  1:19 ` [PATCH 13/15] btrfs: remove the free space inode special cases from the COW paths Tal Zussman
2026-09-08  1:19 ` [PATCH 14/15] btrfs: stop special-casing free space inodes in the delalloc accounting Tal Zussman
2026-09-08  1:19 ` [PATCH 15/15] btrfs: stop reading free space inodes from the commit root Tal Zussman
2026-09-09  1:08 ` [PATCH 00/15] btrfs: remove the v1 space cache David Sterba
2026-09-09  4:33   ` Tal Zussman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260908154231.GE9053@twin.jikos.cz \
    --to=dsterba@suse.cz \
    --cc=dsterba@suse.com \
    --cc=linux-btrfs@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mason@kernel.org \
    --cc=tz2294@columbia.edu \
    --cc=wqu@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®