From: Jakub Kicinski <kuba@kernel.org>
To: Qingfang Deng <qingfang.deng@linux.dev>
Cc: Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>,
Mitchell Blank Jr <mitch@sfgoth.com>,
Chas Williams <3chas3@gmail.com>, Simon Horman <horms@kernel.org>,
James Chapman <jchapman@katalix.com>,
"Jiri Slaby (SUSE)" <jirislaby@kernel.org>,
Kees Cook <kees@kernel.org>, Breno Leitao <leitao@debian.org>,
Asim Viladi Oglu Manizada <manizada@pm.me>,
Eric Woudstra <ericwouds@gmail.com>, Felix Fietkau <nbd@nbd.name>,
linux-ppp@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-atm-general@lists.sourceforge.net
Subject: Re: [PATCH net-next v2] ppp: pass private data to channel callbacks
Date: Tue, 8 Sep 2026 17:03:35 -0700 [thread overview]
Message-ID: <20260908170335.5e98fe60@kernel.org> (raw)
In-Reply-To: <20260906134830.992-1-qingfang.deng@linux.dev>
On Sun, 6 Sep 2026 21:47:36 +0800 Qingfang Deng wrote:
> PPP channel callbacks receive struct ppp_channel only to retrieve the
> driver's private pointer. Pass that pointer directly instead.
>
> This decouples channel callbacks from the public channel representation
> and prepares for making struct ppp_channel opaque, with allocation and
> lifetime managed by the generic PPP layer.
Not immediately obvious that this is a win. Having a callback op take
untyped pointer can be error prone. Also, subjectively, making types
opaque in C often leads to ugly and unnecessarily complex code.
This patch does not stand on its own, IMO, maybe you need to post the
entire series, and maybe rethink.
--
pw-bot: cr
prev parent reply other threads:[~2026-09-09 0:03 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-06 13:47 Qingfang Deng
2026-09-09 0:03 ` Jakub Kicinski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260908170335.5e98fe60@kernel.org \
--to=kuba@kernel.org \
--cc=3chas3@gmail.com \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=ericwouds@gmail.com \
--cc=horms@kernel.org \
--cc=jchapman@katalix.com \
--cc=jirislaby@kernel.org \
--cc=kees@kernel.org \
--cc=leitao@debian.org \
--cc=linux-atm-general@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-ppp@vger.kernel.org \
--cc=manizada@pm.me \
--cc=mitch@sfgoth.com \
--cc=nbd@nbd.name \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=qingfang.deng@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®