From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f49.google.com (mail-pj1-f49.google.com [209.85.216.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5CD1751A759 for ; Tue, 8 Sep 2026 22:57:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.49 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788908263; cv=none; b=OkL4RHnDrfjvKKTLblMg+E8GLlF0WksGDhKiVLm+dD99kfUkbKznPjKAT4sCrNLEJplmJtPTkYsY8kIu5Rh9a4o1/ECE3fNdaSuy/XwPRQbqUKTIJZKUB3fVEh/kMdv6tYmVhKeGMNl2k3dCv6rs+Fwum9yQx0lQSL2BH00bXhw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788908263; c=relaxed/simple; bh=rkKyl75oNGSh9argBDO65R8TRc+7/cMdzZ2u2kUAnOg=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=GLf+t0RE+jVOLPivOg15A/m7wwBSwBVZZhWgrC6suXW8cjpZSQC7BTxrXrrA5RlV8X1g/H+bycv/XXmzvFdF42F3yepITHr0jtCVRgoEhq2qjJ4ESYVn0pNODLaM5uQ/f4MTx3B9HbbdCL1D2/dDJrploG3i74b4IfLL5fFUavY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=sX2n17ka; arc=none smtp.client-ip=209.85.216.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="sX2n17ka" Received: by mail-pj1-f49.google.com with SMTP id 98e67ed59e1d1-3964dfb5b9aso6307246a91.1 for ; Tue, 08 Sep 2026 15:57:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1788908260; x=1789513060; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=dc0GX5Div10dtBv7GvQstkhNGLImZIuVjBsaWt2c5iA=; b=sX2n17kaiGgHH6AD+8GmtskgzlMfU1KmRrrXB1nJ1dTYB73Z09J7PElYBGKMVxKmNW lLHJmfUJW/hqx1TV87Ny1iij0rx3nAeGEVSxpJaKcYKN5BqvrbU+3oc8RGx58kdOueN4 m4gBT2rEMJm7Peifv5e7Aboqkx5btPC6nXZFZqbKq0U46m/bOUBsOsPoNCx/f83d9WhP ZLgu9XcnClxWOMxUWehIyaYXq+FDCV+BTwJ2WT1qy3Yg+LEL/Y0k/XklKSlm/l0NDYOe feYbBMIyJI7H41kInv5fYzloU4bCpxZzOvS9Iwn/g9VYlAO52e4n0Sp4UwYtZhKkjUpw YPRw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1788908260; x=1789513060; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=dc0GX5Div10dtBv7GvQstkhNGLImZIuVjBsaWt2c5iA=; b=qHoDsZsyVRMTQKmQqdxSfpGxCz9LTVbCbhqceMN9SL3ALGSjJkbTouaeSCNx7ajqZk R/sGzoN3e3dz+sbMnL67k5wuBlXc3I21HQ0NsqibtByjnV4rbCzZNMQSYRAJv2sLmjcu e4SQLK4nBO/crQh5K3A7Ef/R7mfVLmrFYKA2WKLfWuuBYjJ7OPzCI/h8BmK7Nul+nkar ajHsGe35n8CY6Knd+Lodr6ravbWkuIiRMNK8LZ/2sVSOZ2xdNE2mOn+FSGpyZGse7mcj fIwGWgmsfh8K83DH0om2rnDZ8GYDhNRrV3RwYAMS/WlelfEDIZXnI9j9ec1QBpWBN6XO +xfA== X-Forwarded-Encrypted: i=1; AKwUvByBEE74nUUplaeP4FQl/wcr7HBEs+XYVT+UWekKG+B7LJpPy6xgvJINsFX8R3KbdI4PMnXocQmxoo/SuBY=@vger.kernel.org X-Gm-Message-State: AFuF++nnGkvZ+bxk0E0cjSjoEL1dvB4HoNvrKMlQuXau+ws8WD+lS+kg xNCwLB7mzc3WSe11+hKzp0m46zoWKkTU3E299hv+huawOY30ovz9SLBa X-Gm-Gg: AYBFou2szHz4zYyOxKzp1R48wvc7uXSuvQkaQhCCdeVtfPc+Gmpt5u0MvqFtuxQf0fB npEevnXQS227aocHRZ9ZPEt2Ogumpk1MP3bSZaA70jrGhzt0bHiw9N7TFJ/0fHy8fZzyy6WZFDO xoMHc46JEwWYeOv6Sw948PCGwheKBtRbk6VVk5z9zWpmO/+wOguOg0ElK8Hmjjp9m2/MCd8hScs OJVYSRb+sWCb90+wgzOlt8afrzj0CskvRd0AVoXj6J0o9s98zfNaNA+NPyUv+Mupqab6jNT951s x2e0amRpxKJr4pQInglTSmhTSUwWfWK9LJirQQOeigFdxISio3TQUn36VtKXoBESqwqP/Pz64C/ GWR8KAyESxx9gW3ZBCQMy5/F6Sfw3JjUtcPqHOP3kCI95cKo9WSensM/JwHfBwNf2qDBg9BrII8 E9M5pEaeDOAnNybre3kBRNoaY/jlSI/NPg+b3uRhwer/46KsEF5L3erABeU58U6Smnnx4= X-Received: by 2002:a17:90a:d64e:b0:38e:2517:5d1f with SMTP id 98e67ed59e1d1-39b2612eb54mr47140729a91.9.1788908260481; Tue, 08 Sep 2026 15:57:40 -0700 (PDT) Received: from localhost ([2620:10d:c090:500::6:91c1]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-143243bfbe3sm36187940c88.11.2026.09.08.15.57.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 08 Sep 2026 15:57:40 -0700 (PDT) From: Zinc Lim To: alexanderduyck@fb.com, kuba@kernel.org, andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@google.com, pabeni@redhat.com, linux@roeck-us.net, horms@kernel.org, mohsin.bashr@gmail.com Cc: kernel-team@meta.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-hwmon@vger.kernel.org, zinclim@meta.com, limzhineng2@gmail.com Subject: [PATCH net-next v3 0/6] eth: fbnic: expand hwmon sensor support Date: Tue, 8 Sep 2026 15:57:31 -0700 Message-ID: <20260908225737.3034403-1-limzhineng2@gmail.com> X-Mailer: git-send-email 2.53.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit fbnic currently exposes only the raw temperature and voltage readings (temp1_input, in0_input) via hwmon. This series builds that out into a complete sensor interface and hardens the read path. The firmware capability response already carries per-board sensor thresholds, and the firmware can asynchronously report when a sensor crosses one of them. This series surfaces both to userspace and cleans up the supporting plumbing: - Move the sensor read logic out of fbnic_mac, closer to its only caller in the hwmon code, and drop the now-unused get_sensor op. - Expose all hwmon attributes unconditionally as read-only (0444). - Cache the temperature and voltage readings for the current jiffy so a burst of attribute reads issues a single firmware round-trip. - Parse and expose the temperature (min/max/crit) and voltage (min/max) thresholds. Thresholds the firmware did not populate read back as -ENODATA. - Add the corresponding alarm attributes, computed by comparing a live reading against the stored thresholds. - Translate the firmware's sensor-threshold-exceeded message into an hwmon event so userspace is notified on the relevant attribute. Changes from v2: - Addressed Jakub's patch 3 feedback on jiffy comparison when checking cache validity. Changes from v1: - Addressed Jakub's patch 6 feedback on including a if (!IS_REACHABLE(CONFIG_HWMON)) return; guard. Zinc Lim (6): eth: fbnic: move sensor read logic out of fbnic_mac eth: fbnic: expose all hwmon attributes unconditionally as read-only eth: fbnic: cache hwmon sensor readings eth: fbnic: report temperature and voltage thresholds via hwmon eth: fbnic: report temperature and voltage alarms via hwmon eth: fbnic: firmware notifies hwmon on sensor threshold events drivers/net/ethernet/meta/fbnic/fbnic.h | 8 + drivers/net/ethernet/meta/fbnic/fbnic_fw.c | 75 +++++ drivers/net/ethernet/meta/fbnic/fbnic_fw.h | 30 ++ drivers/net/ethernet/meta/fbnic/fbnic_hwmon.c | 262 ++++++++++++++++-- drivers/net/ethernet/meta/fbnic/fbnic_mac.c | 55 ---- drivers/net/ethernet/meta/fbnic/fbnic_mac.h | 2 - 6 files changed, 348 insertions(+), 84 deletions(-) -- 2.53.0-Meta