From: Tal Zussman <tz2294@columbia.edu>
To: Jens Axboe <axboe@kernel.dk>, Christoph Hellwig <hch@lst.de>,
Johannes Thumshirn <johannes.thumshirn@wdc.com>,
Luis Chamberlain <mcgrof@kernel.org>,
Hannes Reinecke <hare@kernel.org>,
"Matthew Wilcox (Oracle)" <willy@infradead.org>,
John Garry <john.g.garry@oracle.com>,
Christian Brauner <brauner@kernel.org>,
"Darrick J. Wong" <djwong@kernel.org>,
Keith Busch <kbusch@kernel.org>,
"Martin K. Petersen" <martin.petersen@oracle.com>
Cc: linux-block@vger.kernel.org, linux-kernel@vger.kernel.org,
Sashiko <sashiko-bot@kernel.org>,
Tal Zussman <tz2294@columbia.edu>
Subject: [PATCH v3 7/7] block: remove dead metadata handling from the async direct I/O path
Date: Wed, 09 Sep 2026 18:05:14 -0400 [thread overview]
Message-ID: <20260909-blkdev-fixes-v3-7-1a5222c6e8ad@columbia.edu> (raw)
In-Reply-To: <20260909-blkdev-fixes-v3-0-1a5222c6e8ad@columbia.edu>
Since commit 2729a60bbfb9 ("block: don't silently ignore metadata for
sync read/write"), blkdev_direct_IO() sends every IOCB_HAS_METADATA
request to __blkdev_direct_IO(). Remove the now unreachable metadata
mapping in __blkdev_direct_IO_async() and the unmap in its completion
handler.
No functional change.
Assisted-by: Claude:claude-fable-5
Reviewed-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Tal Zussman <tz2294@columbia.edu>
---
block/fops.c | 10 ----------
1 file changed, 10 deletions(-)
diff --git a/block/fops.c b/block/fops.c
index 0b614d76d128..6a86bffafa7a 100644
--- a/block/fops.c
+++ b/block/fops.c
@@ -306,9 +306,6 @@ static void blkdev_bio_end_io_async(struct bio *bio)
ret = blk_status_to_errno(bio->bi_status);
}
- if (bio_integrity(bio))
- bio_integrity_unmap_user(bio);
-
iocb->ki_complete(iocb, ret);
if (dio->flags & DIO_SHOULD_DIRTY) {
@@ -366,13 +363,6 @@ static ssize_t __blkdev_direct_IO_async(struct kiocb *iocb,
task_io_account_write(bio->bi_iter.bi_size);
}
- if (iocb->ki_flags & IOCB_HAS_METADATA) {
- ret = bio_integrity_map_iter(bio, iocb->private);
- WRITE_ONCE(iocb->private, NULL);
- if (unlikely(ret))
- goto out_bio_put;
- }
-
if (iocb->ki_flags & IOCB_NOWAIT)
bio->bi_opf |= REQ_NOWAIT;
--
2.39.5
next prev parent reply other threads:[~2026-09-09 22:05 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-09 21:59 [PATCH v3 0/7] block device fixes for large block sizes, IOCB_NOWAIT, and direct I/O Tal Zussman
2026-09-09 21:59 ` [PATCH v3 1/7] block: use iomap_dirty_folio for block devices Tal Zussman
2026-09-09 21:59 ` [PATCH v3 2/7] block: take i_rwsem for the direct I/O write fallback Tal Zussman
2026-09-18 2:55 ` Shin'ichiro Kawasaki
2026-09-09 21:59 ` [PATCH v3 3/7] block: take i_rwsem for the splice read path Tal Zussman
2026-09-18 2:57 ` Shin'ichiro Kawasaki
2026-09-18 7:25 ` Christoph Hellwig
2026-09-09 21:59 ` [PATCH v3 4/7] block: honor IOCB_NOWAIT in the block device buffered " Tal Zussman
2026-09-09 22:05 ` [PATCH v3 6/7] block: unpin all pages of a bvec in bio_iov_iter_align_down() Tal Zussman
2026-09-18 3:26 ` Shin'ichiro Kawasaki
2026-09-18 8:43 ` Christoph Hellwig
2026-09-19 5:13 ` Tal Zussman
2026-09-09 22:05 ` [PATCH v3 5/7] block: fail atomic writes instead of falling back to buffered I/O Tal Zussman
2026-09-10 6:40 ` John Garry
2026-09-13 20:48 ` Tal Zussman
2026-09-09 22:05 ` Tal Zussman [this message]
2026-09-10 10:40 ` [PATCH v3 7/7] block: remove dead metadata handling from the async direct I/O path Hannes Reinecke
2026-09-13 20:12 ` Tal Zussman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260909-blkdev-fixes-v3-7-1a5222c6e8ad@columbia.edu \
--to=tz2294@columbia.edu \
--cc=axboe@kernel.dk \
--cc=brauner@kernel.org \
--cc=djwong@kernel.org \
--cc=hare@kernel.org \
--cc=hch@lst.de \
--cc=johannes.thumshirn@wdc.com \
--cc=john.g.garry@oracle.com \
--cc=kbusch@kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=mcgrof@kernel.org \
--cc=sashiko-bot@kernel.org \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®