From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 94F013B0587; Wed, 9 Sep 2026 19:08:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788980880; cv=none; b=Cew4kawB+TEL6e63zMIG59rI9kNembVUAHJweJReMDnJd3Y9YhrIzBj4HzuT5Zbtw1LhnQxNZq9EmTuiW3GOfyspQYGG53o3gmlCUmssIkthjXJan0ZeT8P0ebKvJFFgC19OhPjJU3YqFrBESoAiqmZWSO7LeizmJCEuN5mRY84= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788980880; c=relaxed/simple; bh=zm1X29U/vKcllzl32RPS7yA8qi0SPokOMP9lYNJdA1Q=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=RciZ13xDo+5jZfK4QEsD80ylzMRfUsEQQua9Xzzz6kkiIUrbux9HUwiMbMlK0QiEAP3NKEbhmvZfjFLgHnRdbOPbW2oN3ff6Ir2GTqYutWmX83FHCzXh4eYV7coIeeGYfYJHwmskRDwcMS6gIAeCd5GIguVZy40+gINlIVejT9k= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=RfjRIknE; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="RfjRIknE" Received: by smtp.kernel.org (Postfix) with ESMTPS id EE2D8C4AF09; Wed, 9 Sep 2026 19:07:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1788980880; bh=zm1X29U/vKcllzl32RPS7yA8qi0SPokOMP9lYNJdA1Q=; h=From:Date:Subject:References:In-Reply-To:To:Cc:Reply-To:From; b=RfjRIknE78IFiqPyGIxK88t+XCKf3X7KBLODQCk0PEZcClJMwMVDvro74g/BMVxid wYT8RumGVTsuaTPUcsMqZXjc/VdT8Yt9hzY5X/JHMY8dyT+aa8obl3XRrmN70erLaS PYrvRBpQF/BR+aWmqFQfuy90wmV2mffMi5RxaRQkuYTpuxEmXL7Hk0KGei2jcE1JMT 4OZdrG+rNPZjxjLdVD4esDIt704FwN4+8WYpy8fMnqKhEj4eV2qQ+Pk3jdxZpCIYzJ EnskaHyQHJukTwFBt5AsK2DlUh7Ay3aOUBQFQz5rhtDwT5X8af7vXjs550U/3CuU5N mOP86ImXjbUEw== Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id CCA47C79FB7; Wed, 9 Sep 2026 19:07:59 +0000 (UTC) From: Dave Marquardt via B4 Relay Date: Wed, 09 Sep 2026 14:07:57 -0500 Subject: [PATCH v8 2/9] scsi: ibmvfc: add NOOP command support Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20260909-ibmvfc-fpin-support-v8-2-b27183b055af@linux.ibm.com> References: <20260909-ibmvfc-fpin-support-v8-0-b27183b055af@linux.ibm.com> In-Reply-To: <20260909-ibmvfc-fpin-support-v8-0-b27183b055af@linux.ibm.com> To: "James E.J. Bottomley" , "Martin K. Petersen" , Madhavan Srinivasan , Michael Ellerman , Nicholas Piggin , "Christophe Leroy (CS GROUP)" , Tyrel Datwyler Cc: linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, Brian King , Greg Joyce , Kyle Mahlkuch , Dave Marquardt X-Mailer: b4 0.16.0 X-Developer-Signature: v=1; a=ed25519-sha256; t=1788980878; l=2910; i=davemarq@linux.ibm.com; s=20260216; h=from:subject:message-id; bh=/6eLsH9Lr0XeUeY8Iw7EQ5VPLah0UpDEqJG+hBif1nY=; b=gmGftYvv+WImx24YrY7QsSxYhaKlXOF6CJcLvxPIGAadLcgumas5X9exJOR73MKco3UPa9l6Q WYQGPck9TdaAH0oIOVm68F8jjwaSB/9drKRwVCveCXAKYc9HRKpfofQ X-Developer-Key: i=davemarq@linux.ibm.com; a=ed25519; pk=vy0/nfobrje6EqZxuyw6a3ZstytG8WK2vf5Y3xtGrEg= X-Endpoint-Received: by B4 Relay for davemarq@linux.ibm.com/20260216 with auth_id=689 X-Original-From: Dave Marquardt Reply-To: davemarq@linux.ibm.com From: Dave Marquardt Add support for handling IBMVFC_NOOP format CRQ messages from the VIOS partner. Advertise the client's ability to handle NOOP commands by setting the IBMVFC_CAN_USE_NOOP_CMD capability in ibmvfc_set_login_info(). Handle and ignore IBMVFC_NOOP format messages in both ibmvfc_handle_crq() and ibmvfc_handle_scrq(). In both handlers, log a rate-limited error if a NOOP is received while in the IBMVFC_ACTIVE state without the partner having advertised IBMVFC_SUPPORT_NOOP_CMD. In ibmvfc_handle_scrq(), also fix a typo ("Got and invalid" -> "Got an invalid"), add a missing return on invalid message types, and guard against null event pointers before processing CRQ responses. Signed-off-by: Dave Marquardt --- drivers/scsi/ibmvscsi/ibmvfc-core.c | 27 +++++++++++++++++++++++++-- 1 file changed, 25 insertions(+), 2 deletions(-) diff --git a/drivers/scsi/ibmvscsi/ibmvfc-core.c b/drivers/scsi/ibmvscsi/ibmvfc-core.c index 0dde8dcf43de..c985eb3400a7 100644 --- a/drivers/scsi/ibmvscsi/ibmvfc-core.c +++ b/drivers/scsi/ibmvscsi/ibmvfc-core.c @@ -1578,7 +1578,9 @@ static void ibmvfc_set_login_info(struct ibmvfc_host *vhost) login_info->flags |= cpu_to_be16(IBMVFC_CLIENT_MIGRATED); login_info->max_cmds = cpu_to_be32(max_cmds); - login_info->capabilities = cpu_to_be64(IBMVFC_CAN_MIGRATE | IBMVFC_CAN_SEND_VF_WWPN); + login_info->capabilities = + cpu_to_be64(IBMVFC_CAN_MIGRATE | IBMVFC_CAN_SEND_VF_WWPN | + IBMVFC_CAN_USE_NOOP_CMD); if (vhost->mq_enabled || vhost->using_channels) { login_info->capabilities |= cpu_to_be64(IBMVFC_CAN_USE_CHANNELS); @@ -3693,6 +3695,14 @@ static void ibmvfc_handle_crq(struct ibmvfc_crq *crq, struct ibmvfc_host *vhost, if (crq->format == IBMVFC_ASYNC_EVENT) return; + if (crq->format == IBMVFC_NOOP) { + if (vhost->state == IBMVFC_ACTIVE && + !ibmvfc_check_caps(vhost, IBMVFC_SUPPORT_NOOP_CMD)) + dev_err_ratelimited(vhost->dev, + "Received unexpected NOOP command from partner\n"); + return; + } + /* The only kind of payload CRQs we should get are responses to * things we send. Make sure this response is to something we * actually sent @@ -4223,7 +4233,20 @@ static void ibmvfc_handle_scrq(struct ibmvfc_crq *crq, struct ibmvfc_host *vhost case IBMVFC_CRQ_XPORT_EVENT: return; default: - dev_err(vhost->dev, "Got and invalid message type 0x%02x\n", crq->valid); + dev_err(vhost->dev, "Got an invalid message type 0x%02x\n", crq->valid); + return; + } + + if (crq->format == IBMVFC_NOOP) { + if (vhost->state == IBMVFC_ACTIVE && + !ibmvfc_check_caps(vhost, IBMVFC_SUPPORT_NOOP_CMD)) + dev_err_ratelimited(vhost->dev, + "Received unexpected NOOP command from partner\n"); + return; + } + + if (unlikely(!evt)) { + dev_err(vhost->dev, "Received null event\n"); return; } -- 2.55.0