From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f176.google.com (mail-pf1-f176.google.com [209.85.210.176]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3CA523B995F for ; Wed, 9 Sep 2026 06:47:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.176 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788936462; cv=none; b=QOkc++XqVg+Ws1Nsu3uUQm+CCTeGowFHQz95/a94lgwDWh6k1NFokLhOUsSTA10ghp961KrVLpjsYSOzgQBvoo2nIv+1sWjeWIpM2P1AR5+dhrhbVtJMOuAB0roAHzVfm85gaj/UKtVrIFXq457AVzuubrCSgo60FTirrHFb1DE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788936462; c=relaxed/simple; bh=QjPDfY8HUX1aMlWrIqvKTmWKvq6qJTUY69IkdKukLbA=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=UDGaq9ltajnsAEXXlCJr6mcxvDAzMpNxkzTS3zhwnMDEfzqFAR5pHfZbQfrQJGUKqAp/idu0yBTZIUENJLQwnj7QrcNzfoCSuOoj6tt3yxNfPo6bbnx6eFPrlUryHLQwIbifsMcvsLBxTgW/exMvwwna39pYcsb79Cdql8DcOnQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Ht8GHM8k; arc=none smtp.client-ip=209.85.210.176 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Ht8GHM8k" Received: by mail-pf1-f176.google.com with SMTP id d2e1a72fcca58-84eb992a881so4013598b3a.2 for ; Tue, 08 Sep 2026 23:47:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1788936457; x=1789541257; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=PiRADsgEtjb9wVO+PPwZjDl9Sb9Qx/bxeGIV39F6Vss=; b=Ht8GHM8kcaXBEG0QxVEtgfiuhS0iaygTSQePwS5WNk+r81xJGHZbkPqUy787LO8/ah OZSJ5lMdF8x3a8lR6KbnNb6I1+u8MHU0k++FjmMz0byrl4QNrTwZeBGuIjHDW5bk4VQM NUaX986xhZr8nN6Wt3KaQbnIU538oH5QgSxIufiX1pLOr09C2hrh1UPKxr5XAbhDPUpe jQly3hE9A8vCSL2frAg1MwqV9HhsTkCr3ykR3Nh8EThvUTqhp6fUytARzkhhmgqhB0De vM0Af3QZN9kzPCjpC8pa7oViH1O9sRArn1sWMNmjMvkfh7QHnool7MBCoV6XFcZhEXpG Q+pQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1788936457; x=1789541257; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=PiRADsgEtjb9wVO+PPwZjDl9Sb9Qx/bxeGIV39F6Vss=; b=XDQUoLuR83bjUnajHqV5z6NU9SgecSXzYuN7FtUrwp7aeKyz8iKOBMp27pB1HvzgS0 uI1XlbgNnh/pWt/dXbMwuVXy3hZ1WWMLzd5jgD9pfPKMNkAVjdUfkZIy5c0MBAV5Y4Qj Xl2iQLkJUjBYW2pliD4riz8FWHf/wtrNl9tz+andMmmqdhX+tFS//7q/1HzCfxoXcm1G dfL+NBtM5Sm+Pa11sH56s9ONvt8aF9qNkZX9aIlUYVvFO/21KJ2XHUO9DcTV6L0iwOaW 4wnF2RlVJPCNBwOrW1jIJOZ+DFJY2OICp8vO0/wTevuqLIPe3wtGEdeQy5mzXerAuNV+ dgWA== X-Forwarded-Encrypted: i=1; AKwUvBxx7m7053v0bdfgpBf7Xiagtb2r8gEQ4/rO7TBu1NOwNidFBCpZ1bCPQ7urnMxvVf3Vkmz7n8VeYVcr4GA=@vger.kernel.org X-Gm-Message-State: AFuF++nddFNPNs35D7XsBR2dfb+BYgx/menFJYENZUzVbCodlIc/miI5 gB28waJo9kZuKQ9wzUdYXgy2dUtzhPtw0fpqxfqXN6nHwaRZdkn2LasM X-Gm-Gg: AYBFou1rykUSs7TwnlfeW+tShvPcqC7DqZvc8YG5J6oeZkUNXqKh07V/XwtiDVJi32Y MjYmg4iNEgGABUknVpLEK3yj0if3EfozGvxF9sAAakbwtcK4Yqk8Ndwej39jVYMq57pRo3ccWFz qekdP6MgPwcwJDs5lCwxDOI5Za+voVdBuOYspsHpr99w1vIl4lg5zoRkYwTMxq7osoDIrd19w1k fSNqOufy2hAsjP6qQ7HbY7oNoaJg1bkMWltmcHZsxd7cai6ie4P/Hj8XhCVF5b12B5fQ8FPIyXD c5fBd+jyDfGIEeXV8boqQHSWe6/i3ZJKgcWokKCMsEH6At18fvZFdusGivl9y+JyOGEdwVWAh6B +ItRMkRCYMQfnBvhes3p3yKwXT5Ev3ZapCqqhKZjDMFEBuyYzyEFRuD/ofIFOcq05kDb5lwtnAT BunI81GxpDL2N8gGNxxOqNJbmBbnKrC6kdpDQ8HhfJKNXac3YLaZrNNUFWM9FSeD5IXFHDfuXPm Yeza02RbHFx0QPx/IJnwTTZa2ZsVwu/HcfMdt6AsMvSzVi8TScrdqElz3MWLLddA6mU8dGzhazS ww/J8h9fde54frQ= X-Received: by 2002:a05:6a00:17a9:b0:857:7317:cff4 with SMTP id d2e1a72fcca58-8616a867724mr47261170b3a.21.1788936456799; Tue, 08 Sep 2026 23:47:36 -0700 (PDT) Received: from phuc-desktop.. ([183.91.15.56]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-86152045e8dsm6406973b3a.20.2026.09.08.23.47.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 08 Sep 2026 23:47:36 -0700 (PDT) From: phucduc.bui@gmail.com To: Wei Fang , Frank Li , Shenwei Wang Cc: Andrew Lunn , Simon Horman , davem@davemloft.net, Eric Dumazet , Jakub Kicinski , Paolo Abeni , Richard Cochran , Stephen Boyd , imx@lists.linux.dev, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, bui duc phuc Subject: [PATCH net v5 2/2] net: fec: Handle optional IRQ lookup errors correctly Date: Wed, 9 Sep 2026 13:47:12 +0700 Message-ID: <20260909064712.22539-2-phucduc.bui@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260909064712.22539-1-phucduc.bui@gmail.com> References: <20260909064712.22539-1-phucduc.bui@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: bui duc phuc Handle errors from platform_get_irq_byname_optional() explicitly while preserving the existing fallback to platform_get_irq() when the named IRQ is not available. Propagate errors other than -ENXIO from the optional IRQ lookup instead of silently falling back to the indexed IRQ lookup. In particular, silently ignoring -EPROBE_DEFER can cause the driver to continue probing instead of deferring as required. Fixes: 3b56be218f65 ("net: fec_main: Use platform_get_irq_byname_optional() to avoid error message") Signed-off-by: bui duc phuc --- drivers/net/ethernet/freescale/fec_main.c | 11 ++++++++--- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/drivers/net/ethernet/freescale/fec_main.c b/drivers/net/ethernet/freescale/fec_main.c index c6e29b5c2abb..f7636f23d1eb 100644 --- a/drivers/net/ethernet/freescale/fec_main.c +++ b/drivers/net/ethernet/freescale/fec_main.c @@ -5397,12 +5397,17 @@ fec_probe(struct platform_device *pdev) for (i = 0; i < irq_cnt; i++) { snprintf(irq_name, sizeof(irq_name), "int%d", i); irq = platform_get_irq_byname_optional(pdev, irq_name); - if (irq < 0) - irq = platform_get_irq(pdev, i); - if (irq < 0) { + if (irq < 0 && irq != -ENXIO) { ret = irq; goto failed_irq; } + if (irq == -ENXIO) { + irq = platform_get_irq(pdev, i); + if (irq < 0) { + ret = irq; + goto failed_irq; + } + } ret = devm_request_irq(&pdev->dev, irq, fec_enet_interrupt, 0, pdev->name, ndev); if (ret) -- 2.43.0