From: Isaac Aneek Sarker <alvasarker2004@gmail.com>
Cc: alvasarker2004@gmail.com,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Nikolay Kulikov <nikolayof23@gmail.com>,
Andrei Khomenkov <khomenkov@mailbox.org>,
Dalvin-Ehinoma Noah Aiguobas <fliegbert2@gmail.com>,
Khushal Chitturi <khushalchitturi@gmail.com>,
Minu Jin <s9430939@naver.com>, Anirban Bose <boses156@gmail.com>,
Khasar Munkh-Erdene <02khasar@gmail.com>,
Jennifer Guo <guojy.bj@gmail.com>,
linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: [PATCH] staging: rtl8723bs: fix unnecessary else block with only a break statement
Date: Wed, 9 Sep 2026 14:29:38 +0600 [thread overview]
Message-ID: <20260909083010.13064-1-alvasarker2004@gmail.com> (raw)
Warning found by checkpatch.pl : else is not generally useful after a
break or return. The function would reach the break statement after
if-elseif block even if the else block is not used.
Signed-off-by: Isaac Aneek Sarker <alvasarker2004@gmail.com>
---
drivers/staging/rtl8723bs/core/rtw_recv.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/rtl8723bs/core/rtw_recv.c b/drivers/staging/rtl8723bs/core/rtw_recv.c
index 3c82012fdc6c..a203ef8bd6f6 100644
--- a/drivers/staging/rtl8723bs/core/rtw_recv.c
+++ b/drivers/staging/rtl8723bs/core/rtw_recv.c
@@ -1789,8 +1789,8 @@ static int enqueue_reorder_recvframe(struct recv_reorder_ctrl *preorder_ctrl, un
/* Duplicate entry is found!! Do not insert current entry. */
/* spin_unlock_irqrestore(&ppending_recvframe_queue->lock, irql); */
return false;
- else
- break;
+
+ break;
}
/* spin_lock_irqsave(&ppending_recvframe_queue->lock, irql); */
--
2.53.0
next reply other threads:[~2026-09-09 8:30 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-09 8:29 Isaac Aneek Sarker [this message]
2026-09-09 9:33 ` Greg Kroah-Hartman
2026-09-09 13:37 ` Isaac Aneek Sarker
2026-09-09 13:42 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260909083010.13064-1-alvasarker2004@gmail.com \
--to=alvasarker2004@gmail.com \
--cc=02khasar@gmail.com \
--cc=boses156@gmail.com \
--cc=fliegbert2@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=guojy.bj@gmail.com \
--cc=khomenkov@mailbox.org \
--cc=khushalchitturi@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=nikolayof23@gmail.com \
--cc=s9430939@naver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®