mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Junnan Zhang <zhangjn_dev@163.com>
To: zhangjn_dev@163.com, Tejun Heo <tj@kernel.org>
Cc: Michal Koutny <mkoutny@suse.com>,
	Johannes Weiner <hannes@cmpxchg.org>,
	cgroups@vger.kernel.org, linux-kernel@vger.kernel.org,
	Ridong Chen <ridong.chen@linux.dev>,
	Shouxin Sun <sunshx@chinatelecom.cn>
Subject: Re: [PATCH v3] cgroup: avoid flushing global workqueue in cgroup1_pidlist_destroy_all
Date: Wed,  9 Sep 2026 16:46:19 +0800	[thread overview]
Message-ID: <20260909084619.91579-1-zhangjn_dev@163.com> (raw)
In-Reply-To: <aqA6x_8E3Xiewoso@slm.duckdns.org>

Hi Tejun, Michal,

> I'd rather not touch them at all and eventually retire the whole v1
> interface.

Understood, and I have no objection to Michal's approach as the
long-term direction -- routing v1 reads through css_task_iter removes
the pidlist machinery altogether, including the destroy workqueue
behind this hang.

May I ask for some guidance on the near term, though? cgroup v1 is
still the default on widely deployed enterprise distros and will
likely remain in production use for years to come, and this hung
task was observed on a production Kubernetes node. This patch (v3)
is a pure maintenance fix: it changes no user-visible behavior, adds
no interface, and is stable-backportable. It would also remain
relevant for the cgroup_v1_sorted=true path if Michal's change
lands.

Would you consider taking it as a minimal fix? Or, if the consensus
is to leave v1 completely untouched, what would be the recommended
course for production systems that keep hitting this?

Thanks,
Junnan


  reply	other threads:[~2026-09-09  8:47 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-14  8:40 [PATCH] " Junnan Zhang
2026-08-14  9:45 ` [PATCH v2] " Junnan Zhang
2026-08-14 10:20 ` [PATCH v3] " Junnan Zhang
2026-08-31  7:39   ` Junnan Zhang
2026-08-31  8:16   ` Michal Koutný
2026-09-01  1:53     ` Ridong Chen
2026-09-01  3:48       ` Junnan Zhang
2026-09-01  3:51       ` Junnan Zhang
     [not found]     ` <FIXME-fill-in-Michals-message-id>
2026-09-01  3:38       ` Junnan Zhang
2026-09-01  3:39       ` Junnan Zhang
2026-09-08 14:13         ` Michal Koutný
2026-09-08 16:41           ` Tejun Heo
2026-09-09  8:46             ` Junnan Zhang [this message]
2026-09-09 18:59               ` Tejun Heo
2026-09-10  6:16                 ` Junnan Zhang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260909084619.91579-1-zhangjn_dev@163.com \
    --to=zhangjn_dev@163.com \
    --cc=cgroups@vger.kernel.org \
    --cc=hannes@cmpxchg.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mkoutny@suse.com \
    --cc=ridong.chen@linux.dev \
    --cc=sunshx@chinatelecom.cn \
    --cc=tj@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®