From: shaopeijie@gmail.com
To: sboyd@kernel.org, bmasney+clk@redhat.com,
jbrunet+clk@baylibre.com, michal.simek@amd.com
Cc: linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, Peijie Shao <shaopeijie@gmail.com>
Subject: [PATCH] clk: clocking-wizard: Fix overflow in clockout0 divisor calculation
Date: Wed, 9 Sep 2026 21:14:12 +0800 [thread overview]
Message-ID: <20260909131412.3051635-1-shaopeijie@gmail.com> (raw)
From: Peijie Shao <shaopeijie@gmail.com>
On 32-bit platforms (e.g., Zynq 7000 series), parent_rate * 1000
may overflow, leading to incorrect divisor calculation.
The issue was first found on Zynq7020 with "parent_rate=1GHz"
and "xlnx,nr-outputs=2".
Cast parent_rate to u64 and use the ULL version of DIV_ROUND*
instead.
Signed-off-by: Peijie Shao <shaopeijie@gmail.com>
---
drivers/clk/xilinx/clk-xlnx-clock-wizard.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/clk/xilinx/clk-xlnx-clock-wizard.c b/drivers/clk/xilinx/clk-xlnx-clock-wizard.c
index edf8c0eaca27..5abbc6b83b72 100644
--- a/drivers/clk/xilinx/clk-xlnx-clock-wizard.c
+++ b/drivers/clk/xilinx/clk-xlnx-clock-wizard.c
@@ -881,10 +881,10 @@ static int clk_wzrd_dynamic_reconfig_f(struct clk_hw *hw, unsigned long rate,
struct clk_wzrd_divider *divider = to_clk_wzrd_divider(hw);
void __iomem *div_addr = divider->base + divider->offset;
- rate_div = DIV_ROUND_DOWN_ULL(parent_rate * 1000, rate);
+ rate_div = DIV_ROUND_DOWN_ULL((u64)parent_rate * 1000, rate);
clockout0_div = rate_div / 1000;
- pre = DIV_ROUND_CLOSEST((parent_rate * 1000), rate);
+ pre = DIV_ROUND_CLOSEST_ULL((u64)parent_rate * 1000, rate);
f = (u32)(pre - (clockout0_div * 1000));
f = f & WZRD_CLKOUT_FRAC_MASK;
f = f << WZRD_CLKOUT_DIVIDE_WIDTH;
--
2.43.5
reply other threads:[~2026-09-09 13:14 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260909131412.3051635-1-shaopeijie@gmail.com \
--to=shaopeijie@gmail.com \
--cc=bmasney+clk@redhat.com \
--cc=jbrunet+clk@baylibre.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michal.simek@amd.com \
--cc=sboyd@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®