From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AA5F853FD37; Wed, 9 Sep 2026 14:04:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788962658; cv=none; b=mMeDZMBqDSXO9nXHHid5peIaJfG4SmXA7AWq0jDM/V42r9q5qmqb2JR21vPBCtnLzwQAonUi53436V5gjzOY2UXvoOKx3paU8WX3j9Hp3btwLUqXP4CmdI7qR1sLzUtwBK0AzBnb5opNLHx94A1c0UPNLbXFbbuuNbMXYfGppSU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788962658; c=relaxed/simple; bh=joj+oZhcKNxCBlFa64dD6fvIqv0Vs4g/OHf5Lxq+AoA=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=ZXn4vWDjbLmUxreNGxos0kfEw8/LOfe3KQji+JgTHxPPBtsTelrUDlZtwm9MVtNg34bCQK46DjtpNGTvn6RsvquG0pJqAfVAnaf8JdOYPhBgeR0KTwtoDwr8F4OPzVlFEK6BEwCwO4tnzKMXrBJAlOyjO9kumeUtYuWeig5dYVc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=ZirFfFOi; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="ZirFfFOi" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 68AFB1F00A3F; Wed, 9 Sep 2026 14:04:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1788962656; bh=/q4lRoCEmtfAN8WJows66A5UoAjh8q66hyUmXRAz+Cg=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=ZirFfFOiBYwMdynaPn83142DNnMx1cuqIsMzSc0P2ONtSNMa4vl2Ewt3lij1t26/m ZE7+4PClUCLBsuGhidUxKcJz6qTgaL1pU0aLttA9zIY1d3ptddWB5qQKYSz7euuGfL ZprN3LznRcQvT0+HIy5gRQPmKGxwoJVb+jesgW5imusIvql9JF7Wrh2ywlbl3OouRf 2n5BCj+AyZT54O7KcTzXP+sgpd/8+2zSn01srWSRU1q26dUqIdDsGPL6idcHkDGbOB qmzBMbNGSvyoyp45XZ4ARSgCPrdhM0AV47xxrNSKfP/rrpXbIulO2ukV+UDQifcc30 In3oDeyosUN1Q== From: SJ Park To: Andrew Morton Cc: SJ Park , damon@lists.linux.dev, linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: [PATCH REPOST 2/5] mm/damon/paddr: move probe filter handling to ops-common Date: Wed, 9 Sep 2026 07:04:04 -0700 Message-ID: <20260909140408.104699-3-sj@kernel.org> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260909140408.104699-1-sj@kernel.org> References: <20260909140408.104699-1-sj@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Probe filter matching logic for anon and memcg type filters in DAMON's physical address space operation set (paddr) can be reused by virtual address space operation set (vaddr) in future. Prepare the future by moving the code to ops-common.c Signed-off-by: SJ Park --- mm/damon/ops-common.c | 32 ++++++++++++++++++++++++++++++++ mm/damon/ops-common.h | 2 ++ mm/damon/paddr.c | 23 +---------------------- 3 files changed, 35 insertions(+), 22 deletions(-) diff --git a/mm/damon/ops-common.c b/mm/damon/ops-common.c index acf8f216c51cc..c36cc39cd2c70 100644 --- a/mm/damon/ops-common.c +++ b/mm/damon/ops-common.c @@ -531,3 +531,35 @@ bool damos_ops_has_filter(struct damos *s) return true; return false; } + +bool damon_ops_filter_match(struct damon_filter *filter, struct folio *folio) +{ + bool matched = false; + struct mem_cgroup *memcg; + + switch (filter->type) { + case DAMON_FILTER_TYPE_ANON: + if (!folio) { + matched = false; + break; + } + matched = folio_test_anon(folio); + break; + case DAMON_FILTER_TYPE_MEMCG: + if (!folio) { + matched = false; + break; + } + rcu_read_lock(); + memcg = folio_memcg_check(folio); + if (!memcg) + matched = false; + else + matched = filter->memcg_id == mem_cgroup_id(memcg); + rcu_read_unlock(); + break; + default: + break; + } + return matched == filter->matching; +} diff --git a/mm/damon/ops-common.h b/mm/damon/ops-common.h index 172f0f17c4a84..ee27058251005 100644 --- a/mm/damon/ops-common.h +++ b/mm/damon/ops-common.h @@ -31,3 +31,5 @@ bool damos_folio_filter_match(struct damos_filter *filter, struct folio *folio); unsigned long damon_migrate_pages(struct list_head *folio_list, int target_nid); bool damos_ops_has_filter(struct damos *s); + +bool damon_ops_filter_match(struct damon_filter *filter, struct folio *folio); diff --git a/mm/damon/paddr.c b/mm/damon/paddr.c index d2173a448d0b0..d7c81829445ba 100644 --- a/mm/damon/paddr.c +++ b/mm/damon/paddr.c @@ -143,29 +143,8 @@ static bool damon_pa_filter_match(struct damon_filter *filter, struct folio *folio) { bool matched = false; - struct mem_cgroup *memcg; switch (filter->type) { - case DAMON_FILTER_TYPE_ANON: - if (!folio) { - matched = false; - break; - } - matched = folio_test_anon(folio); - break; - case DAMON_FILTER_TYPE_MEMCG: - if (!folio) { - matched = false; - break; - } - rcu_read_lock(); - memcg = folio_memcg_check(folio); - if (!memcg) - matched = false; - else - matched = filter->memcg_id == mem_cgroup_id(memcg); - rcu_read_unlock(); - break; case DAMON_FILTER_TYPE_PGIDLE_UNSET: if (!folio) matched = false; @@ -173,7 +152,7 @@ static bool damon_pa_filter_match(struct damon_filter *filter, matched = damon_folio_young(folio); break; default: - break; + return damon_ops_filter_match(filter, folio); } return matched == filter->matching; } -- 2.47.3