From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4F39433AD85; Thu, 10 Sep 2026 01:08:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789002540; cv=none; b=W7aqSi4yWHM4P2Ia+vZeEddoHcKXS66HJofaNyjyukjGffn6nwRQsNq9g4Wmqno9h5XoH9YSxLwTh3uH4qxrlPiH1IRsH7LXO7AL6DVqOthlAWRvhNwz93HyRggglI/ZOkr53HTGKEoEbYO4NKo/MgbFEbCwrgdiw35t90iq7Ew= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789002540; c=relaxed/simple; bh=wvQO0DQGI8pBQqS9tilbSsOZVdFoYHcw8f1LdzJny9A=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=kPvFBZoeny2U/BBbj29eImIBHZuWUTC3yDGmbUqsmdE/FzP0fQn2z3y66cl3hf8GeKhXyOk/THlHQZHWB7JNwDbNMFAurMpl4EOEiv1anb1vhzkC4xAiirPZI+49BNGYK3NZrRno3xw3+vtNk9DjlNasQx1+vsnXef7iK2h16FI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=fvlObo+h; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="fvlObo+h" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5234E1F000FF; Thu, 10 Sep 2026 01:08:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1789002532; bh=J1v1M1ChXuvCldJXEtP/MlrTpnP0zRIR+mHnUD9ZX5A=; h=Date:From:To:Cc:Subject:In-Reply-To:References; b=fvlObo+h35YMEFYsYQPZ3gBZ3C3MZ/5L8xB6CcRVBfnp1ak8gMctL1vm8q9AHr//z DAYaEOM5oFUk/tZPNf3aDK3XPhjjxNE7Q4MD8xFFSxE3aKrUIH+S3U4PDF4b6cwNDd AiAF/SxrVTIRcswHnLkPUi2Ce3aPMwDQz26dAgk3HVL5fkB+/KnsAPaDroqzhzC+Ca n2LsqSfhUIbhydWgn9uWpruSuxcV8PR5OVCotwqOA7CizDMlKX+fhBpMvk1QwknUed SZvwkuAbGUu2hKlFtiVQLp6OBXpTgT7Tr45kSAPbBk0neIzULHNyi5f7URN0wCdJae eIs5dbryczL6w== Date: Wed, 9 Sep 2026 18:08:51 -0700 From: Jakub Kicinski To: shuo huang Cc: netdev@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, davem@davemloft.net, edumazet@google.com, pabeni@redhat.com, horms@kernel.org, shuah@kernel.org Subject: Re: [PATCH net-next] selftests: net: Add TCP payload verification to udpgso_bench_rx Message-ID: <20260909180851.01488994@kernel.org> In-Reply-To: <20260906145643.219609-1-f64116045@gs.ncku.edu.tw> References: <20260906145643.219609-1-f64116045@gs.ncku.edu.tw> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Sun, 6 Sep 2026 22:56:43 +0800 shuo huang wrote: > udpgso_bench_rx supports UDP payload verification but rejects the > combination of TCP and verification mode. Its TCP receive path discards > the payload, so it cannot check the data generated by udpgso_bench_tx. > > Read the TCP payload into a buffer when verification is requested > and check it against the transmitter's repeating alphabetic > pattern. Preserve the verification position across recv() calls > because TCP does not preserve send boundaries. Restart the pattern > at the payload length supplied with -l, matching the transmitter's > pattern restart on each message. > > Require a nonzero -l value for TCP verification and retain the existing > discard path when verification is disabled. This new option is not exercised by any in-tree test. Do you have any special use case that needs it? Otherwise either its useful and in-tree tests should run it, or it's not useful and we shouldn't merge this patch either.. -- pw-bot: cr