From: Krzysztof Kozlowski <krzk@kernel.org>
To: Vivek Aknurwar <vivek.aknurwar@oss.qualcomm.com>
Cc: Bjorn Andersson <andersson@kernel.org>,
Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>,
Brian Masney <bmasney@redhat.com>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Vladimir Zapolskiy <vladimir.zapolskiy@linaro.org>,
Jagadeesh Kona <jagadeesh.kona@oss.qualcomm.com>,
Taniya Das <taniya.das@oss.qualcomm.com>,
Brian Masney <bmasney+clk@redhat.com>,
Jerome Brunet <jbrunet+clk@baylibre.com>,
Jagadeesh Kona <quic_jkona@quicinc.com>,
linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/2] dt-bindings: clock: qcom: Add Hawi CAMCC compatible strings
Date: Thu, 10 Sep 2026 10:47:43 +0200 [thread overview]
Message-ID: <20260910-bright-spotted-cuttlefish-8d6b5a@quoll> (raw)
In-Reply-To: <20260908-camcc-hawi-v2-1-f892ba1d118e@oss.qualcomm.com>
On Tue, Sep 08, 2026 at 11:01:22PM -0700, Vivek Aknurwar wrote:
> The Hawi SoC is a derivative of Kaanapali with an updated camera
> clock controller (CAMCC). While the overall block structure is
> similar, Hawi's CAMCC differs from Kaanapali in the following ways:
>
> - Uses Taycan EHA-T PLLs instead of Taycan EKO-T PLLs, with an
> additional ninth PLL (PLL8)
> - Adds a SQPF block with its own GDSC, AHB clock, and BCR reset
> - Adds a CX GDSC (CAM_CC_TITAN_TOP_CX_GDSC) for the camera subsystem
> - Expands ICP from one to two instances (ICP_0 and ICP_1)
>
> Due to these differences, Hawi requires its own 'qcom,hawi-camcc'
> compatible string and a dedicated driver.
>
> The BIST MCLK clock controller (CAMBISTMCLKCC) is unchanged between
> Hawi and Kaanapali, allowing the existing Kaanapali CAMBISTMCLKCC
> driver to support both SoCs without modification.
>
> Add the 'qcom,hawi-camcc' and 'qcom,hawi-cambistmclkcc' compatible
> strings to the binding, along with the corresponding clock ID header.
>
> Signed-off-by: Vivek Aknurwar <vivek.aknurwar@oss.qualcomm.com>
> ---
> .../bindings/clock/qcom,sm8450-camcc.yaml | 27 ++--
> include/dt-bindings/clock/qcom,hawi-camcc.h | 165 +++++++++++++++++++++
> 2 files changed, 182 insertions(+), 10 deletions(-)
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
Best regards,
Krzysztof
next prev parent reply other threads:[~2026-09-10 8:47 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-09 6:01 [PATCH v2 0/2] clk: qcom: add camera clock controller support for Hawi SoC Vivek Aknurwar
2026-09-09 6:01 ` [PATCH v2 1/2] dt-bindings: clock: qcom: Add Hawi CAMCC compatible strings Vivek Aknurwar
2026-09-10 8:47 ` Krzysztof Kozlowski [this message]
2026-09-11 4:27 ` Taniya Das
2026-09-09 6:01 ` [PATCH v2 2/2] clk: qcom: Add support for the camera clock controller (CAMCC) on Hawi Vivek Aknurwar
2026-09-10 7:27 ` Abel Vesa
2026-09-11 4:25 ` Taniya Das
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260910-bright-spotted-cuttlefish-8d6b5a@quoll \
--to=krzk@kernel.org \
--cc=andersson@kernel.org \
--cc=bmasney+clk@redhat.com \
--cc=bmasney@redhat.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jagadeesh.kona@oss.qualcomm.com \
--cc=jbrunet+clk@baylibre.com \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=quic_jkona@quicinc.com \
--cc=robh@kernel.org \
--cc=sboyd@kernel.org \
--cc=taniya.das@oss.qualcomm.com \
--cc=vivek.aknurwar@oss.qualcomm.com \
--cc=vladimir.zapolskiy@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®