From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EF26E48D89A for ; Thu, 10 Sep 2026 13:01:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789045283; cv=none; b=BCoawAmuMA3umO8U1YuSDqVWhp3TYryNGtRsMduZlC8Rgs5bhUnle8QsfcyiJJhYVT0yh8K9+mZJ9yJQ38Oge9Va6mjJRQMxYISZcxG5FxLnhmH0tNOJtUqweoxyYcbbn9nFnwM7Em+jBi/+/QOm8JigFl0x/lGilYXzWAbRXso= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789045283; c=relaxed/simple; bh=fiubGOpznSBlWjS81EhUbY8+Jvg8mdIEbz8sZifJeJk=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=kXi46YUQVFWJluM6UfiN56fAqLPLeJtxIJozy1JuLNcwtUv5TSy4eO/c1JtXPESWcPJUgygZOn10mu7+r8naqVHRRPbzxm5lWlkkrQKU9YysNHWQiLXPSsKE8x8a0fhOJT27ooKdlTDDmy675YjE5Tr3u33YcKQZz1mK3TWJzm0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=HjDllPDm; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=IbMS/l5W; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="HjDllPDm"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="IbMS/l5W" Received: from pps.filterd (m0279870.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 68AC7prX1087050 for ; Thu, 10 Sep 2026 13:01:20 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= skjmTwe/2/9vsGC6HLJTSQTIY2ObikwZKwuHsPTlEzE=; b=HjDllPDmBNjrJIYe PCoW0BPGw4s5pa5PUZRjEHfunhly70NromYsN6NVcF50TxSaDUgnVbBFVC/FlkDz RAD0qXM2FEKgshz+fwo9kd+z1aiI5TLWdYJoed7fth2bJRpUi1LNFYXs4TC+JIci TIXU7YVXvQqUeXULKbvcXCqkikS5tz5feAt9hfcpQu5P3lodTWYg+QYlDSJO3a3T REq073oR8EpdP5+4fK+gwFgpQoPF4Vczvsm3YWC96UburMReAVCDEa2fppED0IZ/ EjaaThXAvDAtJ/r6C4wqGRlpEIyb/a6idBxqdv8E10LXkkadeWYJhobMAx/9zDAe BCQqQw== Received: from mail-vk1-f200.google.com (mail-vk1-f200.google.com [209.85.221.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4gkcyg3ytm-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 10 Sep 2026 13:01:20 +0000 (GMT) Received: by mail-vk1-f200.google.com with SMTP id 71dfb90a1353d-5c7a3b3c06bso2183651e0c.2 for ; Thu, 10 Sep 2026 06:01:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1789045280; x=1789650080; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=skjmTwe/2/9vsGC6HLJTSQTIY2ObikwZKwuHsPTlEzE=; b=IbMS/l5Wy7IFd/wNioYO+mtEU8JiDEUgyYsAR81fzpvfJC188e7Wkn4fMLlGxNaq3e aLgcwMUQ2LXRj+Jee+XiMB2LnRp2I37PylIcB9ZFkx8CmATb5Z3MrBf940nYNz1H3HSr qVgBLoGNMhkzJXsIMGbX1xV5lPdseCnU3xZVzLQSE42p9GdM0lCqIu6+Qo9as5CuKlab IN1reJmJSARkOHF7vZDMavnzxxaH6zEUdJAJ3SQwv0G7nAoHAvjRb+QAcjmCMlJOM5Zq 7xbSLwm1Z6K+W6hgUk0vEk2yFHGn5PQUiz9VgPGtPAyk94JJTgzwC3eksvRlUzZSpXYN gw0g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1789045280; x=1789650080; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=skjmTwe/2/9vsGC6HLJTSQTIY2ObikwZKwuHsPTlEzE=; b=tXAqXua5EEzTSXFqahYpqvej2oA2zhP3PvqE37LpMUH6S45E9YzZlw1KUeSjKtSXv3 eoyOfjFbPQrO+q7/Ze7JvizvBxUNsylruLyilemjGQiExBcWtuAKMNo3P7MdBgfusCYw L+FglrB4dSk8h/NdBr1Ffzv2ln52eprFgAYUDAC9mkDJjQnjZHW2r7lnYgn+tPYtCl/Z mqSu1aGkgZVQws0dAjCABnAej97+TC3JV1Jk21y97H4L+LMD34F1Jd9Ue2V/lXwFGQLk 05oRLTXK+9S4wl1A/6LwAYaClD/8+tYRcjs1FCzSzoeneVzJM0ekZOMQG1rFL9D4f44g lDZg== X-Forwarded-Encrypted: i=1; AKwUvBzH+lY4kbKBUjblq1EJHxkAxZ4N9YNkO5CIOrdvipPmp8GNCSsh+adE3O6Hxg4GfJMVgYoc2I4WIYlxPXc=@vger.kernel.org X-Gm-Message-State: AFuF++l/13N8/rZ828EwsZwg9nH9jYtaDbMHxjQlakn6wGfGFEaOslZI kDWnOZ8tKIG7tUCmMtDl/G6XmxL4a7v8UOYadmZsZaUYt/9tZzRXMXdtawVTWL4xzCzimCyznXs OKU+IpiSTK74QVenKlD4nKDUJjwqknVRW90557GQSU0HUnWteqQrBkWHyw3li4yz0OW8= X-Gm-Gg: AYBFou0qHGhbps22vfzHlouHl7bLSxpSsdRuEMKV7UM8+0G+7Ymzzb5fZ9StsjystUa QvRxRMHHzCmBjVrC2cEJeLmcOb9YBvSQoHoNcH4feKWvePHWJaImWk+nwBR2I+vbJkqwST6E6Eg y+m+OvjtXVS+0Z3XtwA9bjahOxyC/f/L5wNczRHR/qwciugeAR1xcENI3lYaOsdEBTmidglt1qY 9goybAX7LEcK6D5mFarLNVzVIpfaj7U8eQO3rL9+bbZfUy2B7kjSqxklvIhghszEyXjSLIReuze zsbGrSQvHcq1BCPwvP93vmbetRF7q74IXSsiH+fanv9XA/0gnquOvsWV1RURmVapOBsjwuVPyAb SoYYJL3t5lTMyANllX1LtgV/jUYqE X-Received: by 2002:a05:6122:f18:b0:5c7:a814:b987 with SMTP id 71dfb90a1353d-5c7ed298f6cmr2448666e0c.2.1789045279817; Thu, 10 Sep 2026 06:01:19 -0700 (PDT) X-Received: by 2002:a05:6122:f18:b0:5c7:a814:b987 with SMTP id 71dfb90a1353d-5c7ed298f6cmr2447218e0c.2.1789045275485; Thu, 10 Sep 2026 06:01:15 -0700 (PDT) Received: from brgl-qcom.local ([2a01:cb1d:dc:7e00:c9b1:abfb:f300:5e98]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-c26204ecdbcsm831849866b.25.2026.09.10.06.01.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 10 Sep 2026 06:01:14 -0700 (PDT) From: Bartosz Golaszewski Date: Thu, 10 Sep 2026 15:00:43 +0200 Subject: [PATCH v7 02/12] crypto: qce - Reject empty messages for AES-XTS Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20260910-qce-fix-self-tests-v7-2-cdbd2718af14@oss.qualcomm.com> References: <20260910-qce-fix-self-tests-v7-0-cdbd2718af14@oss.qualcomm.com> In-Reply-To: <20260910-qce-fix-self-tests-v7-0-cdbd2718af14@oss.qualcomm.com> To: Thara Gopinath , Herbert Xu , "David S. Miller" , Stanimir Varbanov , Eneas U de Queiroz , Kuldeep Singh , Eric Biggers , Demi Marie Obenour , Bjorn Andersson , Konrad Dybcio Cc: linux-crypto@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, brgl@kernel.org, Bartosz Golaszewski , stable@vger.kernel.org X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=1491; i=bartosz.golaszewski@oss.qualcomm.com; h=from:subject:message-id; bh=fiubGOpznSBlWjS81EhUbY8+Jvg8mdIEbz8sZifJeJk=; b=owEBbQKS/ZANAwAKAQWdLsv/NoTDAcsmYgBqoqoKcY6VeoV7uAaQfnvTc+CvguzwaEw7NG/Cu 8SLkUH96GuJAjMEAAEKAB0WIQSR5RMt5bVGHXuiZfwFnS7L/zaEwwUCaqKqCgAKCRAFnS7L/zaE w9+tD/4qzI8NshC9kwQ3NuRh/YcmU37MwUDDOclQjTz38ZU+o2+KCUP9p/TGSWazcK3zGYqD1+e +XnoG5b7OAvUhlgWmxZpCJHdm4rcxsX8BNpFbaF7Dw7VE2rgIoT3lF8FpwGv+XilOEb/doc4N+V VlwYDiwqFgsO/fW0Xu+Zve/BbPDA3amixlqiD1386ijpScbGs+mmJ9gsyeprV1RBS6XuGfzhLHP +EOLCUgRBgjW59Wr5A8hvNSN288iz2Xf/VRWvbI8tzqweRefG+qxbHA+bUjg+5atscpqQRf85d3 jzAr8mIQ/6YZHglJJg1CmhYDZXHLQWYDmpFORVPdUyReWKLa+IoSEV7GmH5VWFOMasDzKdwzX9k ZLW7afyjyAMgtwGrHKoMR01nuC80rYzRmRyc/fivWDbiR0R5urhxfsBLoai/tluyhRp7vXAP7kZ 7jnRr6Swty2XIkRdvQlBtWLKRW4QJ23ygkSPn+hzMFBD4r+Nm6DfFXzcz6CFwa0rRL/Z/BtLzrm PDxT1u6tq32+OiianYYqDeanLAu5qAsv0vCmHdiGvzAbHGF2CV2tAYCvE5Fdk7gUuvewEKu9J0e 5nlWL7/Z7Av76DKee/jCxCEC7vqJasO6C9e5LQI/hHqPwQ+pKdXbAN3X0+7YcuBDXiVUlWci/Sk Rk00/MmhPKktKTQ== X-Developer-Key: i=bartosz.golaszewski@oss.qualcomm.com; a=openpgp; fpr=169DEB6C0BC3C46013D2C79F11A72EA01471D772 X-Authority-Analysis: v=2.4 cv=Vu62kO2n c=1 sm=1 tr=0 ts=6aa2aa20 cx=c_pps a=wuOIiItHwq1biOnFUQQHKA==:117 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=VdqzKS8jKosA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=gowsoOTTUOVcmtlkKump:22 a=VwQbUJbxAAAA:8 a=EUspDBNiAAAA:8 a=kiYxeA6Iecqc4QeK3QQA:9 a=QEXdDO2ut3YA:10 a=XD7yVLdPMpWraOa8Un9W:22 X-Proofpoint-GUID: DCG2CpSmHDMGzYoxhKH9st1dtHj6Uhng X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwOTEwMDE1NiBTYWx0ZWRfX+FbRpL7K0+mz Jt6Qm/h2hO7Uml1RTvuMXRzlJSlPm+lnGR3T5shz/UjjMPoEAPFNieDNfsP3iKZbZiImZbfXMGq xv0VHK/W8/NFu5QDU/qHPRDB4gft+0hMhZF2Qm9vKMXyok13KRrt0/kxBI8FqkPL9ompsSIXec+ quplYw6sYdw+wqIzdvMOFVxKciCcJjh6fCG3mflZFgljo5JvR1yX4Lyq+yBt/z22ZWxZH93lkNA Oopj1V2NKfqzHueY4EEL1jwUu1rL1vyOXCyknhqWMrbsD9OR05ipO/lpFDhsRMiLnU75+V8bR20 Q0KTMY1fN3bvrOO4Jjr/zkXBFncAyEc5dO1ewNedco0SdO0zRTKxAQMw7eHiJ//L/SEdM8hd/Qc ZAkO8GnLzSD1Kc8TuMsmuWdHnydKWzGxlKIvXsCmBTKik3WY8pwMRZt8PWaozNu+POTzaEzdmms UZ9iKXbfZr4P9MdrSUQ== X-Proofpoint-Spam-Info: AW1haW4tMjYwOTEwMDE1NiBTYWx0ZWRfX+xUgb+t+bAPA g5vO/jduh3bSfZPWVRbLWz7ctUjH4hHBwC4erUkCd0XEjkMVY6pS3Z58ji3p40hNHDRxj2MW983 FYYZUXL2Egn8o2TtOj7WtxOa/AMscbw= X-Proofpoint-ORIG-GUID: DCG2CpSmHDMGzYoxhKH9st1dtHj6Uhng X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-09-10_04,2026-09-09_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 impostorscore=0 adultscore=0 lowpriorityscore=0 clxscore=1015 bulkscore=0 suspectscore=0 malwarescore=0 phishscore=0 spamscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2609040000 definitions=main-2609100156 XTS is not defined for an empty plaintext: it requires at least one full block of data. The driver treated a zero-length request as a successful no-op, so the crypto self-tests "unexpectedly succeeded" when -EINVAL was expected. Return -EINVAL for empty XTS requests while keeping the no-op behavior for the other ciphers, which the crypto engine simply cannot process due to its DMA not supporting zero-length transfers. Cc: stable@vger.kernel.org Fixes: f08789462255 ("crypto: qce - Return error for zero length messages") Tested-by: Kuldeep Singh Signed-off-by: Bartosz Golaszewski --- drivers/crypto/qce/skcipher.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers/crypto/qce/skcipher.c b/drivers/crypto/qce/skcipher.c index 84263ddbd62733f4d1ed42a2b94ae9f4d0d5c6df..b49c1aeb0d27d4798e3e3d0b30299f48ef8ae453 100644 --- a/drivers/crypto/qce/skcipher.c +++ b/drivers/crypto/qce/skcipher.c @@ -222,8 +222,12 @@ static int qce_skcipher_crypt(struct skcipher_request *req, int encrypt) keylen = IS_XTS(rctx->flags) ? ctx->enc_keylen >> 1 : ctx->enc_keylen; /* CE does not handle 0 length messages */ - if (!req->cryptlen) + if (!req->cryptlen) { + /* XTS requires at least one full block of data */ + if (IS_XTS(rctx->flags)) + return -EINVAL; return 0; + } /* * ECB and CBC algorithms require message lengths to be -- 2.47.3