From: Lee Jones <lee@kernel.org>
To: "hpp.iscas" <hppiscas@163.com>
Cc: mfd@lists.linux.dev, linux-kernel@vger.kernel.org,
Aaron Kling <webgeek1234@gmail.com>
Subject: Re: [PATCH] mfd: max77620: publish I2C and OF module aliases
Date: Thu, 10 Sep 2026 10:25:13 +0100 [thread overview]
Message-ID: <20260910092513.GM2133376@google.com> (raw)
In-Reply-To: <20260905134051.66545-1-hppiscas@163.com>
On Sat, 05 Sep 2026, hpp.iscas wrote:
> MFD_MAX77620 became tristate without publishing any module alias for the
> I2C driver. Device Tree I2C clients emit OF modaliases, while legacy
> board-info clients use the existing I2C IDs, so both supported
> enumeration paths need module metadata.
>
> Publish the I2C table and add an OF table for the three documented
> compatibles. Keep i2c_client_get_device_id() as the source of chip data
> and leave MFD child registration unchanged.
>
> Fixes: 0d084ee9ba87 ("mfd: max77620: Allow building as a module")
> Signed-off-by: hpp.iscas <hppiscas@163.com>
Real name please.
> ---
> drivers/mfd/max77620.c | 10 ++++++++++
> 1 file changed, 10 insertions(+)
>
> diff --git a/drivers/mfd/max77620.c b/drivers/mfd/max77620.c
> index c4f89a9..6a624e6 100644
> --- a/drivers/mfd/max77620.c
> +++ b/drivers/mfd/max77620.c
> @@ -699,6 +699,15 @@ static const struct i2c_device_id max77620_id[] = {
> {"max77663", MAX77663},
> {},
> };
> +MODULE_DEVICE_TABLE(i2c, max77620_id);
> +
> +static const struct of_device_id max77620_of_match[] = {
> + { .compatible = "maxim,max77620" },
> + { .compatible = "maxim,max20024" },
> + { .compatible = "maxim,max77663" },
> + { }
> +};
> +MODULE_DEVICE_TABLE(of, max77620_of_match);
>
> static DEFINE_SIMPLE_DEV_PM_OPS(max77620_pm_ops,
> max77620_i2c_suspend, max77620_i2c_resume);
> @@ -706,6 +715,7 @@ static DEFINE_SIMPLE_DEV_PM_OPS(max77620_pm_ops,
> static struct i2c_driver max77620_driver = {
> .driver = {
> .name = "max77620",
> + .of_match_table = max77620_of_match,
> .pm = pm_sleep_ptr(&max77620_pm_ops),
> },
> .probe = max77620_probe,
>
--
Lee Jones
prev parent reply other threads:[~2026-09-10 9:25 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-05 13:40 hpp.iscas
2026-09-10 9:25 ` Lee Jones [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260910092513.GM2133376@google.com \
--to=lee@kernel.org \
--cc=hppiscas@163.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mfd@lists.linux.dev \
--cc=webgeek1234@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®