From: Peter Zijlstra <peterz@infradead.org>
To: Andrea Righi <arighi@nvidia.com>
Cc: Tejun Heo <tj@kernel.org>, David Vernet <void@manifault.com>,
Changwoo Min <changwoo@igalia.com>,
John Stultz <jstultz@google.com>, Ingo Molnar <mingo@redhat.com>,
Juri Lelli <juri.lelli@redhat.com>,
Vincent Guittot <vincent.guittot@linaro.org>,
Dietmar Eggemann <dietmar.eggemann@arm.com>,
Steven Rostedt <rostedt@goodmis.org>,
Ben Segall <bsegall@google.com>, Mel Gorman <mgorman@suse.de>,
Valentin Schneider <vschneid@redhat.com>,
K Prateek Nayak <kprateek.nayak@amd.com>,
Christian Loehle <christian.loehle@arm.com>,
David Dai <david.dai@linux.dev>, Emil Tsalapatis <etsal@meta.com>,
Lee Trager <ltrager@nvidia.com>,
Richard Cheng <icheng@nvidia.com>, Koba Ko <kobak@nvidia.com>,
Aiqun Yu <aiqun.yu@oss.qualcomm.com>,
sched-ext@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 07/18] sched: Add sched_ext hooks for proxy execution
Date: Thu, 10 Sep 2026 12:38:18 +0200 [thread overview]
Message-ID: <20260910103818.GH4120091@noisy.programming.kicks-ass.net> (raw)
In-Reply-To: <20260831134338.1531664-8-arighi@nvidia.com>
On Mon, Aug 31, 2026 at 03:42:17PM +0200, Andrea Righi wrote:
> Proxy execution splits the scheduling context (the donor) from the
> execution context (the lock owner). sched_ext needs to observe that
> split at three points in __schedule():
>
> - whether a blocked EXT task can be retained on the runqueue as a
> donor,
> - when a donor's scheduling context starts driving a lock owner,
> - once proxy resolution has settled for the current pick.
>
> Introduce scx_allow_proxy_exec(), scx_proxy_donor_start() and
> scx_proxy_resolved(), and add their call sites in __schedule(). The
> implementations are empty here and are filled in by the sched_ext
> changes that follow, so that all the sched core changes needed by proxy
> execution stay together in the preparatory patches.
>
> SCHED_PROXY_EXEC still depends on !SCHED_CLASS_EXT, so the new hooks are
> inert: they are compiled out with CONFIG_SCHED_CLASS_EXT=n and
> unreachable otherwise.
>
> This is a preparatory change to support proxy execution with sched_ext.
> No functional change.
>
> Signed-off-by: Andrea Righi <arighi@nvidia.com>
> ---
> kernel/sched/core.c | 12 +++++++-----
> kernel/sched/ext/ext.c | 13 +++++++++++++
> kernel/sched/ext/ext.h | 6 ++++++
> 3 files changed, 26 insertions(+), 5 deletions(-)
>
> diff --git a/kernel/sched/core.c b/kernel/sched/core.c
> index bb79fcfa21cd2..d578dd635f2eb 100644
> --- a/kernel/sched/core.c
> +++ b/kernel/sched/core.c
> @@ -7217,13 +7217,12 @@ static void __sched notrace __schedule(int sched_mode)
> }
> } else if (!preempt && prev_state) {
> /*
> - * We pass task_is_blocked() as the should_block arg
> - * in order to keep mutex-blocked tasks on the runqueue
> - * for slection with proxy-exec (without proxy-exec
> - * task_is_blocked() will always be false).
> + * Keep mutex-blocked tasks on the runqueue for proxy execution
> + * only when their scheduling class allows it. Without proxy
> + * execution, task_is_blocked() always returns false.
> */
> try_to_block_task(rq, prev, &prev_state,
> - !task_is_blocked(prev));
> + !task_is_blocked(prev) || !scx_allow_proxy_exec(prev));
> switch_count = &prev->nvcsw;
> }
>
> @@ -7244,6 +7243,7 @@ static void __sched notrace __schedule(int sched_mode)
> }
> if (next == rq->idle) {
> zap_balance_callbacks(rq);
> + scx_proxy_resolved(rq);
> goto keep_resched;
> }
> }
> @@ -7264,6 +7264,8 @@ static void __sched notrace __schedule(int sched_mode)
> donor->sched_class->put_prev_task(rq, donor, donor);
> donor->sched_class->set_next_task(rq, donor, true);
> }
> + scx_proxy_donor_start(rq);
> + scx_proxy_resolved(rq);
> } else {
> rq_set_donor(rq, next);
> }
Can you expand on the need for scx_proxy_resolved() ? I understand the
other two, but this one I'm struggling with a bit.
next prev parent reply other threads:[~2026-09-10 10:38 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-31 13:42 [PATCHSET v13 sched_ext/for-7.4] sched: Make proxy execution compatible with sched_ext Andrea Righi
2026-08-31 13:42 ` [PATCH 01/18] sched/core: Drop mutex locks before proxy rescheduling Andrea Righi
2026-08-31 13:42 ` [PATCH 02/18] sched/core: Dequeue waking proxy donors before reset Andrea Righi
2026-09-01 5:24 ` K Prateek Nayak
2026-09-08 9:28 ` Andrea Righi
2026-08-31 13:42 ` [PATCH 03/18] sched: Make NOHZ CFS bandwidth checks follow proxy donor Andrea Righi
2026-09-10 9:54 ` Peter Zijlstra
2026-08-31 13:42 ` [PATCH 04/18] sched/core: Avoid false migration warning for proxy donors Andrea Righi
2026-09-10 10:06 ` Peter Zijlstra
2026-08-31 13:42 ` [PATCH 05/18] sched: Pass next class to sched_change_begin() Andrea Righi
2026-09-10 10:12 ` Peter Zijlstra
2026-08-31 13:42 ` [PATCH 06/18] sched: Add helper to block retained proxy donors Andrea Righi
2026-08-31 13:42 ` [PATCH 07/18] sched: Add sched_ext hooks for proxy execution Andrea Righi
2026-09-10 10:38 ` Peter Zijlstra [this message]
2026-08-31 13:42 ` [PATCH 08/18] sched: Introduce WF_ON_RQ wake flag Andrea Righi
2026-09-10 10:45 ` Peter Zijlstra
2026-08-31 13:42 ` [PATCH 09/18] sched_ext: Block proxy donors across scheduler transitions Andrea Righi
2026-09-10 10:53 ` Peter Zijlstra
2026-09-10 11:41 ` Peter Zijlstra
2026-08-31 13:42 ` [PATCH 10/18] sched_ext: Fix ops.running/stopping() pairing for proxy-exec donors Andrea Righi
2026-08-31 13:42 ` [PATCH 11/18] sched_ext: Move reject DSQ draining into core Andrea Righi
2026-08-31 13:42 ` [PATCH 12/18] sched_ext: Generalize the reject DSQ reenqueue path Andrea Righi
2026-09-03 22:39 ` Tejun Heo
2026-09-08 9:34 ` Andrea Righi
2026-08-31 13:42 ` [PATCH 13/18] sched_ext: Handle proxy-exec races in remote DSQ transfers Andrea Righi
2026-08-31 13:42 ` [PATCH 14/18] sched_ext: Split curr|donor references properly Andrea Righi
2026-09-10 11:47 ` Peter Zijlstra
2026-08-31 13:42 ` [PATCH 15/18] sched_ext: Delegate proxy donor admission to BPF schedulers Andrea Righi
2026-09-10 13:39 ` Peter Zijlstra
2026-09-10 13:41 ` Peter Zijlstra
2026-08-31 13:42 ` [PATCH 16/18] sched_ext: Add selftest for blocked donor admission Andrea Righi
2026-08-31 13:42 ` [PATCH 17/18] sched_ext: scx_qmap: Add proxy execution support Andrea Righi
2026-09-01 7:52 ` Richard Cheng
2026-09-08 9:42 ` Andrea Righi
2026-08-31 13:42 ` [PATCH 18/18] sched: Allow enabling proxy exec with sched_ext Andrea Righi
2026-09-03 22:51 ` [PATCHSET v13 sched_ext/for-7.4] sched: Make proxy execution compatible " Tejun Heo
2026-09-08 8:02 ` Peter Zijlstra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260910103818.GH4120091@noisy.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=aiqun.yu@oss.qualcomm.com \
--cc=arighi@nvidia.com \
--cc=bsegall@google.com \
--cc=changwoo@igalia.com \
--cc=christian.loehle@arm.com \
--cc=david.dai@linux.dev \
--cc=dietmar.eggemann@arm.com \
--cc=etsal@meta.com \
--cc=icheng@nvidia.com \
--cc=jstultz@google.com \
--cc=juri.lelli@redhat.com \
--cc=kobak@nvidia.com \
--cc=kprateek.nayak@amd.com \
--cc=linux-kernel@vger.kernel.org \
--cc=ltrager@nvidia.com \
--cc=mgorman@suse.de \
--cc=mingo@redhat.com \
--cc=rostedt@goodmis.org \
--cc=sched-ext@lists.linux.dev \
--cc=tj@kernel.org \
--cc=vincent.guittot@linaro.org \
--cc=void@manifault.com \
--cc=vschneid@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®