From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm2-f12.google.com (mail-wm2-f12.google.com [74.125.225.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0B94B38E100 for ; Thu, 10 Sep 2026 08:38:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.225.140 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789029533; cv=none; b=cVH55mRx/PxZkZofFsFcE4nYeyF0XW88h+dkB62qIvjtNmiTlSd7HYBOSf7aEZ6MSY0Gku3vtaZ+fnsybpC823h7YACzM7p/m6Wcb1xhEQBt9kLIui32jAYbC3zn85P0nVcA2P1DZ1FuXZOuW6Bn9+9wHnbCdEUO57aYHx9IHdI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789029533; c=relaxed/simple; bh=Iv/FuHLzpjRfX/Hu97z4K4S4AtbS4uRUVjP2BEKtEN0=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=gltoZuVqDPjI18btTrA59L1a1amO0Fo6Nsbm1BGwSlORP6yzOOurvqitzkGwHWm1Jhw1rqyHrv+aMe3Vp+h52mREwJozwFa3KDlQWLvCMn1JDZYzPSmuPLcM9i/D8L14kETn1CGwQtN3AFZJyIp3cVcmv0JleLPEFN+6uNAEgCo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=PNr+DALi; arc=none smtp.client-ip=74.125.225.140 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="PNr+DALi" Received: by mail-wm2-f12.google.com with SMTP id 5b1f17b1804b1-49cc9f581c4so11097925e9.0 for ; Thu, 10 Sep 2026 01:38:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1789029529; x=1789634329; darn=vger.kernel.org; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=krWlsGzKhYn79KLVkVDG+CVwssGuEXbVIFgPkModltY=; b=PNr+DALiX77pVm3xrCt3IDwjU6z1l1QfxmxYeXwqBBcnn/8/9OXnr7bAYuK6jYLkAJ sslbhYMAEmEY35sU6/hpAwNsIFG13Ch8SiNXcc57jEnKrBjdMxsOuRvAilN6iqlH1bZ3 2HdURyW5Rk2LAt/r5VPYtPZ9YoKqhtWPbrID1PTGAYhv1spnOdyOaX1/UhphxiylbNVL rfe4RfHTstNZBfxbBZQtV+DesJtr3tVjFBk5OC+dThvBemHHVZFDgTB2umWciz0EFDrz 7b57/23fFTkfuLWA+i0fnZZy7NubgpqoQBTWKd34DWKNcaKwo7nHolqp+AB23Qqe0aIb 9E8w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1789029529; x=1789634329; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=krWlsGzKhYn79KLVkVDG+CVwssGuEXbVIFgPkModltY=; b=IV65q0VKubzd6bBGwQskvPrXMU2yYKrKujPJ48eqpaGyqZWO5YsNafDisGnS8rr/Ih IjIuqUTq/0GJVqRsRsZKTMizYZ6LuZJPHEaE3FPLdBEu4OdduCJfauvVtWQ2viyBOeHg PCV0KOmsk3tW6E9XHA793gwu6LggXiyttw/RsfIX6iC/5uLzLO8LEDTq4HeTWGV3a9wQ tpC0qBxqCzwBG8ni3T/4PlPLR0mYP3q+fjjBxhylBhPpYRZTeRDNGecF+X03vhl7nZYA OIbw/NEM+npbrb3PcoVlh3xhDD0yiEh52ssLvNJ0WHaBefu8nMQNrSJ9hj0azzSgrgVd NJhw== X-Forwarded-Encrypted: i=1; AKwUvBz18PnMmsLpI66bFXoZYs8jKmRv6PTwwvNOC2NBiV3jvsJE+W1t0BXFyuOItkoKsphXJ5qkzhBI27LlapY=@vger.kernel.org X-Gm-Message-State: AFuF++niy1IP7IIXQQPiPbQe/9kf6+hpmUELN0QMnX/P0yf6wPuD/Tgm q0qBPyuDgoyul0Ijmt8TH/eS4eX/10NtQhCyjE39j8HQvo7de9o4wn1D X-Gm-Gg: AYBFou1nNTpwhzcRT7yNUPvKu1Qf9cpIm1rRB1CsYI4Yl92HL9LZTXo/fQXxVCTrvhJ BlZFvTwBboHFzyhL5to+dHrS/RxIYg484j8YMd8BWX+hlglWu5YZVuBy+GidVyc1vICltjBNuMF qi+HFmRg/Y9U7xknOdXMJID67N44m9eWjeW5fpq1Kz9aKUZ7dNZ1jXcwGIKEjxWD82oHRNriFIW wjWJGSccm9XH0wwXM2Xy/PQR2dcG6w0yRvAwmmjJiBsWKdx6oWENH+0gH+YDBCScyqIIe7ID/y9 PLAbijnjjMAaZIoJo8b4bx6N23DG5ckb45w7MyHjpIllUp4VV3VOuBFs4wnKWa4NeUauQ2q3icN 5LoUSCR4rVu3pqi+NLpRixNyrrSoaNl3oB5r3Hq1BZNrcoWIFr1fNLoD/Sk66t8lgb+qc4w0QT3 PJHiX2uy/9Oyd/c9CnzOrMM1ypTyq+e3Wm9nA01uCHjpXLoQBKDmFlsO42Q6vdr/YTT6sjMbEi1 JbW41aeig== X-Received: by 2002:a05:600c:8b10:b0:49d:1e79:35d6 with SMTP id 5b1f17b1804b1-49d26dcaa22mr38489625e9.14.1789029528985; Thu, 10 Sep 2026 01:38:48 -0700 (PDT) Received: from foxbook (bfg95.neoplus.adsl.tpnet.pl. [83.28.44.95]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-49d1fb058c8sm57245275e9.0.2026.09.10.01.38.48 (version=TLS1_2 cipher=AES128-SHA bits=128/128); Thu, 10 Sep 2026 01:38:48 -0700 (PDT) Date: Thu, 10 Sep 2026 10:38:45 +0200 From: Michal Pecio To: Quinn Schive Cc: linux-input@vger.kernel.org, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [BUG] HID: logitech-hidpp: G502 LIGHTSPEED loses hi-res scroll state after S3 resume Message-ID: <20260910103845.71b194f4.michal.pecio@gmail.com> In-Reply-To: References: <20260909222724.30fc8f52.michal.pecio@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Wed, 9 Sep 2026 18:13:17 -0600, Quinn Schive wrote: > I tested the patch you suggested, and so far it appears to have fixed > the problem on my system. Thanks for testing, looks like that issue may be somewhat widespread. BTW, you may respond to the patch (in its original thread) with: Tested-by: Your Name and a brief note that it's confirmed to work for you as well. As for the Logitech driver, I'd guess it needs something like this. Of course, the xHCI patch must be removed to reproduce this again. diff --git a/drivers/hid/hid-logitech-hidpp.c b/drivers/hid/hid-logitech-hidpp.c index 1504de32b1c8..0107ffc9efb3 100644 --- a/drivers/hid/hid-logitech-hidpp.c +++ b/drivers/hid/hid-logitech-hidpp.c @@ -4711,6 +4711,21 @@ static bool hidpp_application_equals(struct hid_device *hdev, return report && report->application == application; } +static int hidpp_reset_resume(struct hid_device *hdev) +{ + struct hidpp_device *hidpp = hid_get_drvdata(hdev); + int ret = 1234; + + /* reset disables hi-res scroll, restore if it was used */ + if (hidpp && hidpp->vertical_wheel_counter.wheel_multiplier > 1) + ret = hi_res_scroll_enable(hidpp); + + dev_info(&hdev->dev, "hidpp_reset_resume mult %d ret %d\n", + hidpp ? hidpp->vertical_wheel_counter.wheel_multiplier : 4321, + ret); + return 0; +} + static int hidpp_probe(struct hid_device *hdev, const struct hid_device_id *id) { struct hidpp_device *hidpp; @@ -5059,6 +5074,7 @@ static struct hid_driver hidpp_driver = { .input_configured = hidpp_input_configured, .input_mapping = hidpp_input_mapping, .input_mapped = hidpp_input_mapped, + .reset_resume = pm_ptr(hidpp_reset_resume), }; module_hid_driver(hidpp_driver);