mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Hans Verkuil <hverkuil+cisco@kernel.org>
Cc: Hemanth Selam <hemanth.selam@gmail.com>,
	Mauro Carvalho Chehab <mchehab@kernel.org>,
	Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>,
	Hans Verkuil <hverkuil@kernel.org>,
	linux-kernel@vger.kernel.org, linux-media@vger.kernel.org,
	linux-renesas-soc@vger.kernel.org
Subject: Re: [PATCH 2/3] media: fix repeated words in comments
Date: Thu, 10 Sep 2026 14:45:50 +0300	[thread overview]
Message-ID: <20260910114550.GJ1892234@killaraus.ideasonboard.com> (raw)
In-Reply-To: <3f13417b-cca2-4403-8fb4-ac9c65f1311d@kernel.org>

On Thu, Sep 10, 2026 at 01:30:11PM +0200, Hans Verkuil wrote:
> On 04/09/2026 15:36, Laurent Pinchart wrote:
> > On Fri, Sep 04, 2026 at 05:04:43PM +0530, Hemanth Selam wrote:
> >> Drop words accidentally written twice, reported by checkpatch.pl as a
> >> possible repeated word.  Only touches comments, no code changes.
> >>
> >> Assisted-by: Cursor:claude-opus-5
> > 
> > This is not a good use of reviewer time. NAK.
> 
> Actually, I'll take this patch.
> 
> Laurent, feel free to delegate patches fixing typos/grammar to me. I hate
> typos etc. in code, they actually make the code harder to read. Patches
> fixing that take very little time to review, so I'm fine doing that.

I don't welcome people who use LLMs to generate noise with barely any
value, just for the sake of having their name in the kernel git log. We
have enough important patches to review. This kind of submission should
be discouraged. It would be different if the typo fixes were part of a
human-written series that adds real value.

> >> Signed-off-by: Hemanth Selam <hemanth.selam@gmail.com>
> >> ---
> >>  drivers/media/i2c/adv7175.c                   | 2 +-
> >>  drivers/media/platform/renesas/vsp1/vsp1_dl.c | 2 +-
> >>  drivers/media/usb/gspca/ov519.c               | 2 +-
> >>  3 files changed, 3 insertions(+), 3 deletions(-)
> >>
> >> diff --git a/drivers/media/i2c/adv7175.c b/drivers/media/i2c/adv7175.c
> >> index f1caab8e2abd..b6f0e1b24383 100644
> >> --- a/drivers/media/i2c/adv7175.c
> >> +++ b/drivers/media/i2c/adv7175.c
> >> @@ -209,7 +209,7 @@ static int adv7175_s_std_output(struct v4l2_subdev *sd, v4l2_std_id std)
> >>  		/* This is an attempt to convert
> >>  		 * SECAM->PAL (typically it does not work
> >>  		 * due to genlock: when decoder is in SECAM
> >> -		 * and encoder in in PAL the subcarrier can
> >> +		 * and encoder in PAL the subcarrier can
> >>  		 * not be synchronized with horizontal
> >>  		 * quency) */
> >>  		adv7175_write_block(sd, init_pal, sizeof(init_pal));
> >> diff --git a/drivers/media/platform/renesas/vsp1/vsp1_dl.c b/drivers/media/platform/renesas/vsp1/vsp1_dl.c
> >> index 6430f2ec8b32..8257759421f3 100644
> >> --- a/drivers/media/platform/renesas/vsp1/vsp1_dl.c
> >> +++ b/drivers/media/platform/renesas/vsp1/vsp1_dl.c
> >> @@ -649,7 +649,7 @@ static void __vsp1_dl_list_put(struct vsp1_dl_list *dl)
> >>  	dl->post_cmd = NULL;
> >>  
> >>  	/*
> >> -	 * body0 is reused as as an optimisation as presently every display list
> >> +	 * body0 is reused as an optimisation as presently every display list
> >>  	 * has at least one body, thus we reinitialise the entries list.
> >>  	 */
> >>  	dl->body0->num_entries = 0;
> >> diff --git a/drivers/media/usb/gspca/ov519.c b/drivers/media/usb/gspca/ov519.c
> >> index bffa94e76da5..57219a738c73 100644
> >> --- a/drivers/media/usb/gspca/ov519.c
> >> +++ b/drivers/media/usb/gspca/ov519.c
> >> @@ -13,7 +13,7 @@
> >>   * Copyright (c) 1999-2006 Mark W. McClelland
> >>   * Support for OV519, OV8610 Copyright (c) 2003 Joerg Heckenbach
> >>   * Many improvements by Bret Wallach <bwallac1@san.rr.com>
> >> - * Color fixes by by Orion Sky Lawlor <olawlor@acm.org> (2/26/2000)
> >> + * Color fixes by Orion Sky Lawlor <olawlor@acm.org> (2/26/2000)
> >>   * OV7620 fixes by Charl P. Botha <cpbotha@ieee.org>
> >>   * Changes by Claudio Matsuoka <claudio@conectiva.com>
> >>   *

-- 
Regards,

Laurent Pinchart

  reply	other threads:[~2026-09-10 11:45 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-04 11:34 [PATCH 0/3] media: fix typos and " Hemanth Selam
2026-09-04 11:34 ` [PATCH 1/3] media: fix typos " Hemanth Selam
2026-09-04 11:34 ` [PATCH 2/3] media: fix repeated words " Hemanth Selam
2026-09-04 13:36   ` Laurent Pinchart
2026-09-10 11:30     ` Hans Verkuil
2026-09-10 11:45       ` Laurent Pinchart [this message]
2026-09-04 11:34 ` [PATCH 3/3] media: pci: fix repeated word in log message Hemanth Selam

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260910114550.GJ1892234@killaraus.ideasonboard.com \
    --to=laurent.pinchart@ideasonboard.com \
    --cc=hemanth.selam@gmail.com \
    --cc=hverkuil+cisco@kernel.org \
    --cc=hverkuil@kernel.org \
    --cc=kieran.bingham+renesas@ideasonboard.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=linux-renesas-soc@vger.kernel.org \
    --cc=mchehab@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®