From: phucduc.bui@gmail.com
To: Mark Brown <broonie@kernel.org>,
AngeloGioacchino Del Regno
<angelogioacchino.delregno@collabora.com>
Cc: Liam Girdwood <lgirdwood@gmail.com>,
Matthias Brugger <matthias.bgg@gmail.com>,
Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
Cezary Rojewski <cezary.rojewski@intel.com>,
Cyril Chao <Cyril.Chao@mediatek.com>,
Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>,
Dan Carpenter <error27@gmail.com>,
cassiogabrielcontato@gmail.com, linux-sound@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org,
bui duc phuc <phucduc.bui@gmail.com>
Subject: [PATCH 13/13] ASoC: mediatek: mt8189: Validate TDM MCLK frequency
Date: Thu, 10 Sep 2026 19:57:42 +0700 [thread overview]
Message-ID: <20260910125742.150902-14-phucduc.bui@gmail.com> (raw)
In-Reply-To: <20260910125742.150902-1-phucduc.bui@gmail.com>
From: bui duc phuc <phucduc.bui@gmail.com>
mtk_dai_tdm_cal_mclk() accepts zero or negative frequencies.
Reject invalid frequencies before configuring the TDM clock.
Fixes: 9f202872ba04 ("ASoC: mediatek: mt8189: support TDM in platform driver")
Signed-off-by: bui duc phuc <phucduc.bui@gmail.com>
---
sound/soc/mediatek/mt8189/mt8189-dai-tdm.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/sound/soc/mediatek/mt8189/mt8189-dai-tdm.c b/sound/soc/mediatek/mt8189/mt8189-dai-tdm.c
index 1b51027c6cf4..7748b4ff2c72 100644
--- a/sound/soc/mediatek/mt8189/mt8189-dai-tdm.c
+++ b/sound/soc/mediatek/mt8189/mt8189-dai-tdm.c
@@ -381,6 +381,9 @@ static int mtk_dai_tdm_cal_mclk(struct mtk_base_afe *afe,
int apll;
int apll_rate;
+ if (freq <= 0)
+ return -EINVAL;
+
apll = mt8189_get_apll_by_rate(afe, freq);
apll_rate = mt8189_get_apll_rate(afe, apll);
--
2.43.0
prev parent reply other threads:[~2026-09-10 12:59 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-10 12:57 [PATCH 00/13] ASoC: mediatek: mt8189: Improve error handling phucduc.bui
2026-09-10 12:57 ` [PATCH 01/13] ASoC: mediatek: mt8189: Return error for missing regmap phucduc.bui
2026-09-10 12:57 ` [PATCH 02/13] ASoC: mediatek: mt8189: Propagate APLL enable errors phucduc.bui
2026-09-10 13:32 ` Dan Carpenter
2026-09-11 7:59 ` Bui Duc Phuc
2026-09-10 12:57 ` [PATCH 03/13] ASoC: mediatek: mt8189: Propagate MCK " phucduc.bui
2026-09-10 12:57 ` [PATCH 04/13] ASoC: mediatek: mt8189: Validate MCK ID phucduc.bui
2026-09-10 12:57 ` [PATCH 05/13] ASoC: mediatek: mt8189: Propagate reg_rw clock errors phucduc.bui
2026-09-10 12:57 ` [PATCH 06/13] ASoC: mediatek: mt8189: Use dev_err_probe() for " phucduc.bui
2026-09-10 12:57 ` [PATCH 07/13] ASoC: mediatek: mt8189: Propagate runtime resume errors phucduc.bui
2026-09-10 12:57 ` [PATCH 08/13] ASoC: mediatek: mt8189: Remove redundant error message phucduc.bui
2026-09-10 12:57 ` [PATCH 09/13] ASoC: mediatek: mt8189: Propagate APLL errors phucduc.bui
2026-09-10 12:57 ` [PATCH 10/13] ASoC: mediatek: mt8189: Propagate MCLK errors phucduc.bui
2026-09-10 12:57 ` [PATCH 11/13] ASoC: mediatek: mt8189: Validate sysclk frequency phucduc.bui
2026-09-10 13:26 ` Dan Carpenter
2026-09-11 7:47 ` Bui Duc Phuc
2026-09-10 12:57 ` [PATCH 12/13] ASoC: mediatek: mt8189: Propagate TDM clock errors phucduc.bui
2026-09-10 12:57 ` phucduc.bui [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260910125742.150902-14-phucduc.bui@gmail.com \
--to=phucduc.bui@gmail.com \
--cc=Cyril.Chao@mediatek.com \
--cc=angelogioacchino.delregno@collabora.com \
--cc=broonie@kernel.org \
--cc=cassiogabrielcontato@gmail.com \
--cc=cezary.rojewski@intel.com \
--cc=error27@gmail.com \
--cc=kuninori.morimoto.gx@renesas.com \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-sound@vger.kernel.org \
--cc=matthias.bgg@gmail.com \
--cc=perex@perex.cz \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®