mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Nguyen Quang Le Kien <khiemtranzo532001@gmail.com>
Cc: 3chas3@gmail.com, linux-usb@vger.kernel.org,
	linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
	linux-atm-general@lists.sourceforge.net,
	accessrunner-general@lists.sourceforge.net,
	syzbot+24eb38c789655fc43663@syzkaller.appspotmail.com
Subject: Re: [PATCH] usb: atm: cxacru: fix use-after-free in cxacru_poll_status
Date: Thu, 10 Sep 2026 14:49:31 +0200	[thread overview]
Message-ID: <2026091016-gracious-purity-9ca9@gregkh> (raw)
In-Reply-To: <20260803101716.2592486-1-khiemtranzo532001@gmail.com>

On Mon, Aug 03, 2026 at 06:17:16PM +0800, Nguyen Quang Le Kien wrote:
> In cxacru_unbind(), cancel_delayed_work_sync() was conditionally skipped
> when poll_state was CXPOLL_STOPPED. However, a work item previously
> scheduled when poll_state was CXPOLL_POLLING may still be pending in the
> workqueue at the time poll_state transitions to CXPOLL_STOPPED. Skipping
> cancel_delayed_work_sync() in this case allows the work to fire after
> cxacru_data is freed, causing a use-after-free when cxacru_poll_status()
> attempts to acquire instance->poll_state_serialize.
> 
> Fix this by always calling cancel_delayed_work_sync() regardless of
> poll_state, ensuring no pending or in-flight work can access the freed
> instance.
> 
> Reported-by: syzbot+24eb38c789655fc43663@syzkaller.appspotmail.com
> Closes: https://syzkaller.appspot.com/bug?extid=24eb38c789655fc43663
> Signed-off-by: Nguyen Quang Le Kien <khiemtranzo532001@gmail.com>
> ---
>  drivers/usb/atm/cxacru.c | 10 +---------
>  1 file changed, 1 insertion(+), 9 deletions(-)

Did you forget the assisted-by: tag?

And how did you test this?

thanks.

greg k-h

      parent reply	other threads:[~2026-09-10 12:49 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-03 10:17 Nguyen Quang Le Kien
2026-08-06 15:50 ` patchwork-bot+netdevbpf
2026-09-10 12:49 ` Greg KH [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2026091016-gracious-purity-9ca9@gregkh \
    --to=gregkh@linuxfoundation.org \
    --cc=3chas3@gmail.com \
    --cc=accessrunner-general@lists.sourceforge.net \
    --cc=khiemtranzo532001@gmail.com \
    --cc=linux-atm-general@lists.sourceforge.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=syzbot+24eb38c789655fc43663@syzkaller.appspotmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®