From: Jakub Kicinski <kuba@kernel.org>
To: phucduc.bui@gmail.com
Cc: Wei Fang <wei.fang@nxp.com>, Frank Li <frank.li@nxp.com>,
Shenwei Wang <shenwei.wang@nxp.com>,
Andrew Lunn <andrew+netdev@lunn.ch>,
Simon Horman <horms@kernel.org>,
davem@davemloft.net, Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>,
Richard Cochran <richardcochran@gmail.com>,
Stephen Boyd <swboyd@chromium.org>,
imx@lists.linux.dev, linux-kernel@vger.kernel.org,
netdev@vger.kernel.org
Subject: Re: [PATCH net v5 1/2] net: fec: Propagate PTP initialization errors
Date: Thu, 10 Sep 2026 18:07:33 -0700 [thread overview]
Message-ID: <20260910180733.2d4d48e9@kernel.org> (raw)
In-Reply-To: <20260909064712.22539-1-phucduc.bui@gmail.com>
On Wed, 9 Sep 2026 13:47:11 +0700 phucduc.bui@gmail.com wrote:
> * cyclecounter init routine and exits.
> */
>
> -void fec_ptp_init(struct platform_device *pdev, int irq_idx)
> +int fec_ptp_init(struct platform_device *pdev, int irq_idx)
This function has a kdoc, you need to document the return value now.
Please repost this for net-next without the Fixes tags.
next prev parent reply other threads:[~2026-09-11 1:07 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-09 6:47 phucduc.bui
2026-09-09 6:47 ` [PATCH net v5 2/2] net: fec: Handle optional IRQ lookup errors correctly phucduc.bui
2026-09-09 7:56 ` Wei Fang
2026-09-09 7:52 ` [PATCH net v5 1/2] net: fec: Propagate PTP initialization errors Wei Fang
2026-09-11 1:07 ` Jakub Kicinski [this message]
2026-09-11 4:02 ` Bui Duc Phuc
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260910180733.2d4d48e9@kernel.org \
--to=kuba@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=frank.li@nxp.com \
--cc=horms@kernel.org \
--cc=imx@lists.linux.dev \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=phucduc.bui@gmail.com \
--cc=richardcochran@gmail.com \
--cc=shenwei.wang@nxp.com \
--cc=swboyd@chromium.org \
--cc=wei.fang@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®