mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Petko Manolov <petko.manolov@konsulko.com>
To: Dinh Nguyen <dinguyen@kernel.org>
Cc: linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
	robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org
Subject: Re: [PATCH v3 0/3] ARM: dts: draeger: Add socfpga devicetree for Draeger's M48 board.
Date: Fri, 11 Sep 2026 12:21:49 +0300	[thread overview]
Message-ID: <20260911092149.GD722@carbon.k.g> (raw)
In-Reply-To: <c78630cb-999e-4825-833f-3e184ed98573@kernel.org>

On 26-09-09 08:27:22, Dinh Nguyen wrote:
> Hi Petko,
> 
> On 9/9/26 06:15, Petko Manolov wrote:
> > Adding the device trees for “Dräger M48 on NXP i.MX6 (Q) and Intel/Altera
> > SoCFPGA Cyclone V” board variant.  It has both (the SoC and FPGA) on the same
> > carrier and they are cross-monitoring each other.
> > 
> > This is the SoCFPGA devicetree part.
> > 
> > Changes in v3:
> > 
> >    - add Draeger AG in devicetree/bindings/vendor-prefixes.yaml
> >    - separate binding changes from the actual devicetree patch
> >    - remove "earlyprintk" from the boot arguments
> > 
> > Petko Manolov (3):
> >    Add Draeger AG as a vendor
> >    Add Draeger's M48 board to the SoCFPGA family.
> >    Add socfpga devicetree for Draeger's M48 board.
> > 
> >   .../devicetree/bindings/arm/altera.yaml       |   1 +
> >   .../devicetree/bindings/vendor-prefixes.yaml  |   2 +
> >   arch/arm/boot/dts/intel/socfpga/Makefile      |   1 +
> >   .../socfpga/socfpga_cyclone5_draeger_m48.dts  | 129 ++++++++++++++++++
> >   4 files changed, 133 insertions(+)
> >   create mode 100644 arch/arm/boot/dts/intel/socfpga/socfpga_cyclone5_draeger_m48.dts
> > 
> 
> Please look up what a commit header and message should look like for these
> patches. For example:
> 
> patch 1/3 should look something like this:
> 
> dt-bindings: vendor-prefixes: add Draeger AG
> 
> Add a vendor prefix for Draegar AG, which is Draegerwerk AG & Co. KGaA
> 
> Signed-off-by: Petko Manolov <petko.manolov@konsulko.com>

That was really dump omission on my part, sorry.  Will be fixed.

> You should look what the formatting of the commit header and message look like
> for the subsystem you're submitting patches to.
> 
> All of your patches are missing the appropriate formatting.

Could you please specify.  I've run all of them through checkpatch.pl.  Maybe
i'm missing something else?


		Petko

      reply	other threads:[~2026-09-11  9:21 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-09 11:15 Petko Manolov
2026-09-09 11:15 ` [PATCH v3 1/3] Add Draeger AG as a vendor Petko Manolov
2026-09-10  8:54   ` Krzysztof Kozlowski
2026-09-09 11:15 ` [PATCH v3 2/3] Add Draeger's M48 board to the SoCFPGA family Petko Manolov
2026-09-10  8:55   ` Krzysztof Kozlowski
2026-09-09 11:15 ` [PATCH v3 3/3] Add socfpga devicetree for Draeger's M48 board Petko Manolov
2026-09-09 13:36   ` Dinh Nguyen
2026-09-11  9:25     ` Petko Manolov
2026-09-11  9:54       ` Dinh Nguyen
2026-09-11 10:10         ` Petko Manolov
2026-09-10  8:56   ` Krzysztof Kozlowski
2026-09-09 13:27 ` [PATCH v3 0/3] ARM: dts: draeger: " Dinh Nguyen
2026-09-11  9:21   ` Petko Manolov [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260911092149.GD722@carbon.k.g \
    --to=petko.manolov@konsulko.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dinguyen@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®