From: Steven Rostedt <rostedt@goodmis.org>
To: Leon Hwang <leon.hwang@linux.dev>
Cc: kernel test robot <lkp@intel.com>,
oe-kbuild-all@lists.linux.dev, linux-kernel@vger.kernel.org,
Jiri Olsa <jolsa@kernel.org>
Subject: Re: kernel/trace/ftrace.c:6651:40: sparse: sparse: incorrect type in assignment (different address spaces)
Date: Fri, 11 Sep 2026 09:28:41 -0400 [thread overview]
Message-ID: <20260911092841.530e3fcf@gandalf.local.home> (raw)
In-Reply-To: <d876a8c2-3e4d-449a-9127-ec15b34c9e5d@linux.dev>
Can you send this as a proper patch to linux-trace-kernel@vger.kernel.org
Thanks,
-- Steve
On Fri, 11 Sep 2026 11:14:00 +0800
Leon Hwang <leon.hwang@linux.dev> wrote:
> >From 03079b720a8cba88b3da579acfbcf88d983a838d Mon Sep 17 00:00:00 2001
> From: Leon Hwang <leon.hwang@linux.dev>
> Date: Fri, 11 Sep 2026 10:43:13 +0800
> Subject: [PATCH] ftrace: Use rcu_assign_pointer() for tmp_ops filter hash
>
> tmp_ops.func_hash->filter_hash is annotated __rcu, but
> update_ftrace_direct_mod() assigns hash to it directly. Sparse reports an
> address-space mismatch.
>
> Use rcu_assign_pointer() for the assignment.
>
> Fixes: 50b35c9e50a8 ("ftrace: Use hash argument for tmp_ops in
> update_ftrace_direct_mod")
> Reported-by: kernel test robot <lkp@intel.com>
> Closes:
> https://lore.kernel.org/oe-kbuild-all/202609110704.Q3M5vCDV-lkp@intel.com/
> Signed-off-by: Leon Hwang <leon.hwang@linux.dev>
> ---
> kernel/trace/ftrace.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/kernel/trace/ftrace.c b/kernel/trace/ftrace.c
> index 53d5db60bfa5..673a54fdf392 100644
> --- a/kernel/trace/ftrace.c
> +++ b/kernel/trace/ftrace.c
> @@ -6675,7 +6675,7 @@ int update_ftrace_direct_mod(struct ftrace_ops
> *ops, struct ftrace_hash *hash, b
>
> /* Enable the tmp_ops to have the same functions as the hash
> object. */
> ftrace_ops_init(&tmp_ops);
> - tmp_ops.func_hash->filter_hash = hash;
> + rcu_assign_pointer(tmp_ops.func_hash->filter_hash, hash);
>
> err = register_ftrace_function_nolock(&tmp_ops);
> if (err)
> --
> 2.55.0
prev parent reply other threads:[~2026-09-11 13:27 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-10 23:59 kernel test robot
2026-09-11 3:14 ` Leon Hwang
2026-09-11 13:28 ` Steven Rostedt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260911092841.530e3fcf@gandalf.local.home \
--to=rostedt@goodmis.org \
--cc=jolsa@kernel.org \
--cc=leon.hwang@linux.dev \
--cc=linux-kernel@vger.kernel.org \
--cc=lkp@intel.com \
--cc=oe-kbuild-all@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®