From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Changyul Lee <lcy8047@gmail.com>
Cc: Srinivas Kandagatla <srini@kernel.org>,
linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] slimbus: messaging: hold lock until transaction is completed
Date: Fri, 11 Sep 2026 08:00:28 +0200 [thread overview]
Message-ID: <2026091111-appear-stopper-6fd6@gregkh> (raw)
In-Reply-To: <20260911045911.1327413-1-lcy8047@gmail.com>
On Fri, Sep 11, 2026 at 12:59:11AM -0400, Changyul Lee wrote:
> slim_msg_response() drops lock after idr_find() and dereferences txn.
> If the requester times out in the meantime, it frees the TID and
> returns, so the handler writes the reply into msg->rbuf and calls
> complete() on txn->comp, both of which have already benn freed.
>
> Keep lock held until complete(txn->comp) finishes, so a requester
> in slim_free_txn_tid() and cannot return while txn is still in use.
> Call idr_remove() because slim_free_txn_tid() takes the same lock.
>
> Fixes: afbdcc7c384b ("slimbus: Add messaging APIs to slimbus framework")
>
> Signed-off-by: Changyul Lee <lcy8047@gmail.com>
No blank line between these please.
And how was this found and tested?
thanks,
greg k-h
prev parent reply other threads:[~2026-09-11 6:02 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-11 4:59 Changyul Lee
2026-09-11 6:00 ` Greg Kroah-Hartman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2026091111-appear-stopper-6fd6@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=lcy8047@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=srini@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®