Re: [PATCH net-next v7 2/3] dt-bindings: net: wiznet,w5100: add link status interrupt

[Arthur Crepin Leblond <arthur@marmottus.net>]

On Fri, Sep 11, 2026 at 05:33:35PM +0200, Arthur Crepin Leblond wrote:
>On Wed, Sep 09, 2026 at 12:39:00PM +0000, netdev-bot+sashiko@kernel.org wrote:
>>Should the item count be tied to the compatible string, for example:
>>
>> allOf:
>>   - if:
>>       properties:
>>         compatible:
>>           contains:
>>             enum:
>>               - wiznet,w5100
>>               - wiznet,w5200
>>     then:
>>       properties:
>>         interrupts:
>>           maxItems: 1
>>
>>The driver side of the series treats index 1 as w5500-only:
>>
>>drivers/net/ethernet/wiznet/w5100.c:w5100_probe() {
>>   ...
>>   priv->link_irq = ops->chip_id == W5500 ?
>>                    fwnode_irq_get(dev_fwnode(dev), 1) : -ENODEV;
>>   ...
>>}
>>
>>with w5100_get_link() returning a hardcoded 1 for the parts that have no
>>PHYCFGR link-status register.  So for w5100/w5200 a second interrupt in DT
>>would validate but then be silently ignored, since fwnode_irq_get() is
>>never called for index 1 on those chip ids.
>
>Let me update this and have it conditional and re-request a review
>from the devicetree people.
>
>Arthur

Or maybe updating the description of the top level interrupts is
enough, the same way it is done in example-schema.yaml?

Arthur