From: Charles Keepax <ckeepax@opensource.cirrus.com>
To: vkoul@kernel.org
Cc: yung-chuan.liao@linux.intel.com, pierre-louis.bossart@linux.dev,
peter.ujfalusi@linux.intel.com, linux-sound@vger.kernel.org,
patches@opensource.cirrus.com, linux-kernel@vger.kernel.org
Subject: [PATCH 0/2] Allow SoundWire devices to communicate during remove
Date: Fri, 11 Sep 2026 17:19:01 +0100 [thread overview]
Message-ID: <20260911161903.419814-1-ckeepax@opensource.cirrus.com> (raw)
Currently on Intel systems SoundWire drivers can't communicate with the
device during driver removal. This is primarily because the IRQs are
disabled before the driver remove callback is run. The result of this is
such transactions timeout causing a) a lot of errors in the log and b)
driver remove to take a very long time.
This issue affects cs42l43 and cs42l45, primarily due to both using
regmap IRQ.
soundwire_intel soundwire_intel.link.0: IO transfer timed out, cmd 3 device 6 addr 5d len 1
soundwire sdw-master-0-0: trf on Slave 6 failed:-110 write addr 5d count 0
sdca_class sdw:0:0:01fa:4245:01: Failed to sync masks in 5d
As regmap IRQ is torn down it will mask the interrupts that are
removed. However, there are many valid reasons a driver might want
communicate with the device during removal, others would include
disabling jack detection, putting the device into the lowest possible
power state to save power, etc.
This patch set attempts to address this problem trying to locate the
reason interrupts are disabled, fixing that and then leaving the IRQs
enabled for the remove callback.
Charles Keepax (2):
soundwire: bus: Don't unassign dev_num before unregistering device
soundwire: intel_auxdevice: Don't disable IRQs before removing
children
drivers/soundwire/bus.c | 4 ++--
drivers/soundwire/intel.h | 1 +
drivers/soundwire/intel_auxdevice.c | 5 ++++-
drivers/soundwire/intel_init.c | 16 ++++++++++++++++
include/linux/soundwire/sdw_intel.h | 1 +
5 files changed, 24 insertions(+), 3 deletions(-)
--
2.47.3
next reply other threads:[~2026-09-11 16:19 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-11 16:19 Charles Keepax [this message]
2026-09-11 16:19 ` [PATCH 1/2] soundwire: bus: Don't unassign dev_num before unregistering device Charles Keepax
2026-09-14 18:21 ` Pierre-Louis Bossart
2026-09-11 16:19 ` [PATCH 2/2] soundwire: intel_auxdevice: Don't disable IRQs before removing children Charles Keepax
2026-09-14 18:27 ` Pierre-Louis Bossart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260911161903.419814-1-ckeepax@opensource.cirrus.com \
--to=ckeepax@opensource.cirrus.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=patches@opensource.cirrus.com \
--cc=peter.ujfalusi@linux.intel.com \
--cc=pierre-louis.bossart@linux.dev \
--cc=vkoul@kernel.org \
--cc=yung-chuan.liao@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®