From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A968F420475; Fri, 11 Sep 2026 17:35:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=213.167.242.64 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789148145; cv=none; b=l4np3t+gqggyQxSaWGK01Po2Tsrosj2g4txNsJXPG1JgOn1HsUvUloZISco7XqyP+/f+7AuixccE1n5TODn6hylTNcGmhAM1QrfzdNofRr+EOBVLR/SBgy1BFhfOK5fy69PRJHRJCzIb+FPLeusrfa/0FoTPBzTLgdpk9rNCSjs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789148145; c=relaxed/simple; bh=iwS1vIB//xdldz1BpUq3y6FKoMrwQfjgvhFiBVkFpJ8=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=DSpgMSE6LAxbU/eSZa7ff1roYd/o9mBUwuI/nyR+7BHEvO06EygalGrnFjqXHAg8GInPh4FbNP+3tJO2yxYoi6akkSyYMWbhht2zpZCDbvlgz7xa1Nv9HENLnRTfZwEA9OySykOE9WGM01zBRDHZH238r72Gx09h/a9YslJDKMo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=ideasonboard.com; spf=pass smtp.mailfrom=ideasonboard.com; dkim=pass (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b=G7PDZITx; arc=none smtp.client-ip=213.167.242.64 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=ideasonboard.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ideasonboard.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="G7PDZITx" Received: from killaraus.ideasonboard.com (2001-14ba-70f3-e800--a06.rev.dnainternet.fi [IPv6:2001:14ba:70f3:e800::a06]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id CCE38DA8; Fri, 11 Sep 2026 19:33:59 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1789148040; bh=iwS1vIB//xdldz1BpUq3y6FKoMrwQfjgvhFiBVkFpJ8=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=G7PDZITx/MujrpiarN9EybIY1mRkNbTwzhvSEn83zOfTkm/EOUm3PTGudX8yGNQw5 YVqp5nJT79QwxGQhN5phLuKUN43obFtdWNsNKvPglxi1APLJZ16rxDhHV5Vd79RDRK YOnsURurJrjcX7oo3cWiRjOj6updowLDTyXNpjJ0= Date: Fri, 11 Sep 2026 20:35:36 +0300 From: Laurent Pinchart To: Jacopo Mondi Cc: Kieran Bingham , Dafna Hirschfeld , Heiko Stuebner , Mauro Carvalho Chehab , Paul Elder , Sakari Ailus , linux-media@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: Re: [PATCH] media: rkisp1: Fix Bayer demosaicing bypass Message-ID: <20260911173536.GX1892234@killaraus.ideasonboard.com> References: <20260911-imx8mp-demosaicing-bypass-v1-1-5568a7a560a6@ideasonboard.com> <178913687012.1723501.3167773155478207003@ping.linuxembedded.co.uk> <20260911173508.GW1892234@killaraus.ideasonboard.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20260911173508.GW1892234@killaraus.ideasonboard.com> On Fri, Sep 11, 2026 at 08:35:10PM +0300, Laurent Pinchart wrote: > On Fri, Sep 11, 2026 at 04:43:32PM +0200, Jacopo Mondi wrote: > > On Fri, Sep 11, 2026 at 03:27:50PM +0100, Kieran Bingham wrote: > > > Quoting Jacopo Mondi (2026-09-11 14:56:19) > > > > The RKISP1_CIF_ISP_DEMOSAIC_BYPASS bit, when set, bypasses the > > > > demosaicing block on the RkISP1 ISP. > > > > > > > > The current implementation however clears the bit when demosaicing > > > > have to be bypassed and sets it when demosaicing has to be enabled, > > > > effectively inverting the bypass bit handling logic. > > > > > > Ouch. > > > > > > > Fix this by setting the bypass bit when disabling the demosaicing block, > > > > and by clearing it instead when demosaicing has to be performed. > > > > > > > > The issue never manifested itself as libcamera hasn't an algorithm s/hasn't/doesn't have/ I'll fix it when applying. > > > > to control Bayer demosaicing bypass yet. > > > > > > > > Fixes: 6c53a7b68c5d ("media: rkisp1: Implement extensible params support") > > > > Cc: stable@vger.kernel.org > > > > Signed-off-by: Jacopo Mondi > > > > --- > > > > media: rkisp1: Fix demosaicing bypass > > > > --- > > > > drivers/media/platform/rockchip/rkisp1/rkisp1-params.c | 8 ++++---- > > > > 1 file changed, 4 insertions(+), 4 deletions(-) > > > > > > > > diff --git a/drivers/media/platform/rockchip/rkisp1/rkisp1-params.c b/drivers/media/platform/rockchip/rkisp1/rkisp1-params.c > > > > index 042b759eba62..496381962f1b 100644 > > > > --- a/drivers/media/platform/rockchip/rkisp1/rkisp1-params.c > > > > +++ b/drivers/media/platform/rockchip/rkisp1/rkisp1-params.c > > > > @@ -1854,8 +1854,8 @@ rkisp1_ext_params_bdm(struct rkisp1_params *params, > > > > const struct rkisp1_ext_params_bdm_config *bdm = &block->bdm; > > > > > > > > if (bdm->header.flags & RKISP1_EXT_PARAMS_FL_BLOCK_DISABLE) { > > > > - rkisp1_param_clear_bits(params, RKISP1_CIF_ISP_DEMOSAIC, > > > > - RKISP1_CIF_ISP_DEMOSAIC_BYPASS); > > > > + rkisp1_param_set_bits(params, RKISP1_CIF_ISP_DEMOSAIC, > > > > + RKISP1_CIF_ISP_DEMOSAIC_BYPASS); > > > > return; > > > > } > > > > > > > > @@ -1863,8 +1863,8 @@ rkisp1_ext_params_bdm(struct rkisp1_params *params, > > > > > > > > if ((bdm->header.flags & RKISP1_EXT_PARAMS_FL_BLOCK_ENABLE) && > > > > !(params->enabled_blocks & BIT(bdm->header.type))) > > > > - rkisp1_param_set_bits(params, RKISP1_CIF_ISP_DEMOSAIC, > > > > - RKISP1_CIF_ISP_DEMOSAIC_BYPASS); > > > > + rkisp1_param_clear_bits(params, RKISP1_CIF_ISP_DEMOSAIC, > > > > + RKISP1_CIF_ISP_DEMOSAIC_BYPASS); > > > > > > I think this also opens us up to add mono formats as explicitly > > > supported by the ISP and potentially set the demosaic defaulting to off > > > in that instance? > > > > mmm, I think userspace is in a better position to decide when to > > bypass debayer instead of relying on auto-configuration of the ISP ? > > > > I guess we'll discuss this when support for luma-only formats will be > > added to the driver > > While I understand why auto-configuration is tempting, I've found that > more often than not it makes the life of both the driver and userspace > more difficult. Look for instance at the colourspace handling code in > rkisp1. > > > > Anyway, Looks sane to me in this order. > > > > > > Reviewed-by: Kieran Bingham > > Reviewed-by: Laurent Pinchart > > > thanks > > > > > > } > > > > > > > > static void > > > > > > > > --- > > > > base-commit: 27953c044974baf7e24dee3e9342fe0103dea80c > > > > change-id: 20260911-imx8mp-demosaicing-bypass-bb284d9cca60 -- Regards, Laurent Pinchart