mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Suren Baghdasaryan <surenb@google.com>
To: akpm@linux-foundation.org
Cc: liam@infradead.org, ljs@kernel.org, vbabka@kernel.org,
	david@kernel.org,  willy@infradead.org, jannh@google.com,
	paulmck@kernel.org, pfalcato@suse.de,  xueyuan.chen21@gmail.com,
	linux-mm@kvack.org, linux-kernel@vger.kernel.org,
	 linux-fsdevel@vger.kernel.org, surenb@google.com
Subject: [PATCH v4 0/7] read proc/pid/smaps_rollup under per-vma lock
Date: Fri, 11 Sep 2026 12:41:38 -0700	[thread overview]
Message-ID: <20260911194145.1781926-1-surenb@google.com> (raw)

proc/pid/smaps_rollup can be read using the combination of RCU and
VMA read locks, similar to proc/pid/{maps|smaps|numa_maps}. RCU is
required to safely traverse the VMA tree and VMA lock stabilizes the
VMA being processed and the pagetable walk.
Note that we have to keep the logic to drop mmap_lock on contention
because even when using per-VMA locks we might have to fall back to
holding the mmap_lock.

The first 5 patches are cleanups making later change simpler. The main
change is in patch 6. Patch 7 extends existing proc-maps-race tearing
test to verify smaps_rollup content.

Changes since v3 [1]:
Patch 2:
- Added Acked-by, per David Hildenbrand
Patch 3:
- Moved conversion of (start != 0) to is_partial into the next patch,
  per Lorenzo Stoakes
Patch 4:
- Moved conversion of (start != 0) to is_partial into the next patch,
  per Lorenzo Stoakes
- Converted multiple lines of arguments in modified functions to
  two-tab indents, per David Hildenbrand
- Introduced smap_gather_stats_range() for partial VMA walks,
  per Lorenzo Stoakes
Patch 5:
- Added Reviewed-by and Acked-by, per David Hildenbrand and
  Lorenzo Stoakes
- Added a comment explaining the check for SENTINEL_VMA_GATE in m_start,
  per Lorenzo Stoakes
Patch 6:
- Added Reviewed-by, per Lorenzo Stoakes
Patch 7:
- Converted multiple lines of arguments in modified functions to
  two-tab indents
- Added Acked-by, per Lorenzo Stoakes

[1] https://lore.kernel.org/all/20260910234737.1340642-1-surenb@google.com/

Patchset applies over mm-new branch.

Suren Baghdasaryan (7):
  proc/task_mmu: remove unnecessary helpers
  proc/task_mmu: remove unnecessary inlines in function definitions
  proc/task_mmu: clarify shmem mapping walk conditions in
    smap_gather_stats()
  proc/task_mmu: remove special-casing of smap_gather_stats() start
    parameter
  proc/task_mmu: change proc_get_vma() to stop returning gate VMA at the
    end
  proc/task_mmu: read proc/pid/smaps_rollup under per-vma lock
  selftests/proc: add /proc/pid/smaps_rollup tearing tests

 fs/proc/task_mmu.c                            | 339 ++++++++----------
 tools/testing/selftests/proc/proc-maps-race.c | 186 +++++++++-
 2 files changed, 334 insertions(+), 191 deletions(-)


base-commit: 1f78f28a2945f9e856b4ea8428ac41a6788e4b67
-- 
2.55.0.1007.g17ff1f9808-goog


             reply	other threads:[~2026-09-11 19:41 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-11 19:41 Suren Baghdasaryan [this message]
2026-09-11 19:41 ` [PATCH v4 1/7] proc/task_mmu: remove unnecessary helpers Suren Baghdasaryan
2026-09-11 19:41 ` [PATCH v4 2/7] proc/task_mmu: remove unnecessary inlines in function definitions Suren Baghdasaryan
2026-09-11 19:41 ` [PATCH v4 3/7] proc/task_mmu: clarify shmem mapping walk conditions in smap_gather_stats() Suren Baghdasaryan
2026-09-11 19:44   ` Lorenzo Stoakes (ARM)
2026-09-11 21:00   ` David Hildenbrand (Arm)
2026-09-11 21:31     ` Suren Baghdasaryan
2026-09-11 19:41 ` [PATCH v4 4/7] proc/task_mmu: remove special-casing of smap_gather_stats() start parameter Suren Baghdasaryan
2026-09-11 19:45   ` Lorenzo Stoakes (ARM)
2026-09-11 19:47     ` Suren Baghdasaryan
2026-09-14 10:38   ` David Hildenbrand (Arm)
2026-09-11 19:41 ` [PATCH v4 5/7] proc/task_mmu: change proc_get_vma() to stop returning gate VMA at the end Suren Baghdasaryan
2026-09-11 19:41 ` [PATCH v4 6/7] proc/task_mmu: read proc/pid/smaps_rollup under per-vma lock Suren Baghdasaryan
2026-09-11 19:41 ` [PATCH v4 7/7] selftests/proc: add /proc/pid/smaps_rollup tearing tests Suren Baghdasaryan
2026-09-12  7:24 ` [PATCH v4 0/7] read proc/pid/smaps_rollup under per-vma lock Andrew Morton
2026-09-12 18:55   ` Paul E. McKenney
2026-09-13 19:26   ` Suren Baghdasaryan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260911194145.1781926-1-surenb@google.com \
    --to=surenb@google.com \
    --cc=akpm@linux-foundation.org \
    --cc=david@kernel.org \
    --cc=jannh@google.com \
    --cc=liam@infradead.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=ljs@kernel.org \
    --cc=paulmck@kernel.org \
    --cc=pfalcato@suse.de \
    --cc=vbabka@kernel.org \
    --cc=willy@infradead.org \
    --cc=xueyuan.chen21@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®