From: Karl Mehltretter <kmehltretter@gmail.com>
To: Viresh Kumar <vireshk@kernel.org>, Nishanth Menon <nm@ti.com>,
Stephen Boyd <sboyd@kernel.org>
Cc: Karl Mehltretter <kmehltretter@gmail.com>,
Ulf Hansson <ulfh@kernel.org>,
Rajendra Nayak <rajendra.nayak@oss.qualcomm.com>,
Jordan Crouse <jordan@cosmicpenguin.net>,
linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH] OPP: Fix the return value in dev_pm_opp_get_of_node() kernel-doc
Date: Sat, 12 Sep 2026 00:14:43 +0200 [thread overview]
Message-ID: <20260911221443.7139-1-kmehltretter@gmail.com> (raw)
dev_pm_opp_get_of_node() returns NULL when the OPP is invalid, but its
kernel-doc says "else 0 on success", which was never true. Say NULL.
Fixes: e2f4b5f8dc59 ("PM / OPP: Implement dev_pm_opp_get_of_node()")
Assisted-by: LLM
Signed-off-by: Karl Mehltretter <kmehltretter@gmail.com>
---
drivers/opp/of.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/opp/of.c b/drivers/opp/of.c
index 2f3bbde9a9e1742a2d6b40be91a65d8fa7365bf3..ea93800795783f0595483742c0c10de42b25518a 100644
--- a/drivers/opp/of.c
+++ b/drivers/opp/of.c
@@ -1409,7 +1409,7 @@ bool dev_pm_opp_of_has_required_opp(struct device *dev)
* dev_pm_opp_get_of_node() - Gets the DT node corresponding to an opp
* @opp: opp for which DT node has to be returned for
*
- * Return: DT node corresponding to the opp, else 0 on success.
+ * Return: DT node corresponding to the opp, else NULL.
*
* The caller needs to put the node with of_node_put() after using it.
*/
next reply other threads:[~2026-09-11 22:16 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-11 22:14 Karl Mehltretter [this message]
2026-10-01 6:11 ` Viresh Kumar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260911221443.7139-1-kmehltretter@gmail.com \
--to=kmehltretter@gmail.com \
--cc=jordan@cosmicpenguin.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=nm@ti.com \
--cc=rajendra.nayak@oss.qualcomm.com \
--cc=sboyd@kernel.org \
--cc=ulfh@kernel.org \
--cc=vireshk@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®