From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ot1-f98.google.com (mail-ot1-f98.google.com [209.85.210.98]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5D91441F7EE for ; Fri, 11 Sep 2026 23:35:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.98 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789169756; cv=none; b=UOFvIKCuD0yIDqvwqbHUZ1Cdy/agzRcmkoDTD3NcOrPqa8ih1ulAWYzonCP5wlA8hMMa2FDYxfERRvSL0aSHF6c16eJLK/YFt80ysLgKBUNL3/QkTMcAJosH1iznLYSHnr0JmsybvHLJ4yCCJUYG6D5l9zMxBUYKNNyo6Ng/Vhw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789169756; c=relaxed/simple; bh=nttleM8Tx0cIVF/OubkghUhIrwkhO7hXwcPPrF0zhrg=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=jl6DGUDqK4ERcV0jrmRZnse6m6vb8VZtwVJXhG5A7C6um/Sg0lKoVckOH0rm2MDf5Bs/my+Dd/EKtJSH1fOoRJwQTkuTQeJ3iQeNlG96sEoloP5cgApagCxPfVQNBR4GTo0QFHNPdIFqEVfO3VWeOZkavD753NoTM335hX9HpoE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=broadcom.com; spf=fail smtp.mailfrom=broadcom.com; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b=gZIQPoqd; arc=none smtp.client-ip=209.85.210.98 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=broadcom.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=broadcom.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b="gZIQPoqd" Received: by mail-ot1-f98.google.com with SMTP id 46e09a7af769-7f5934ba2a5so810384a34.3 for ; Fri, 11 Sep 2026 16:35:55 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1789169754; x=1789774554; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=TL/+G3e3u5ILLrluIyCPB8J12Dl41Ws69Qu/dHBTdLE=; b=rt1G/TZjGlotEls+3SnkvRxnoVyajjOmel4YNiAUN2BBe+khpzDbEgy5KlOccq/qAe +9x2W5F9AaixDAeVJyxg7KVjAzoAHnQi8NPZYCBJPxmg1OI/OSowopH4FHO/glhHU7gy x5MUEookClAPXejwlg5EgUQ8SB46+kAbBqpB79II/pCHBK6yqXPaxLQpSVaioKPlSM5E TY3pM7ZW3qJR4s/KKvHOfX13WI/C6ROKOe6c999xvO5ajXwa0wq/1i/3iqXmuzqFZ8Tf bk9/xI+cKbcbIVOHfuOvHka6V5B3/BRD7T5r4aISpWjwnLF6zv7wknMqBVVXg3TnH/An bemQ== X-Forwarded-Encrypted: i=1; AKwUvBw/iaeZ4NtJiEmf9h1sr2Pd1lcdEK+HTwaIPTmncK0Ax3+lGpRI92c9FUu35b4+jTYEFDBjHmgskBsX5MU=@vger.kernel.org X-Gm-Message-State: AFuF++nqNXZ6o/E7SR1wfGSE/TnoqtCoRUyW2UjtOpfgzZBjrzEC+PdN fEVr9wu5+12JrmnoKs+ED4srRg8mjYR5aGmXgb8ATByTbqEOmpKCeqMuqmYi+SK+biWFH/b5QmR KZdKyXTi95WOZbum4M1VAIZdi5ZgVnG2ZwJzhUeFu1xYISAEajIVppfFCTYjAcclAR7WMdNI7Jg Yu1d5rRvPGp7X/hrURIscGEX1u8T7MhUDQUXfHSxeRJAsRWXskeWWJg8PgzqW3etN390no9HW+C Ua8/lTXkdo+0WtKfx8T X-Gm-Gg: AYBFou1rliqbnhYS+ylO7BBRtGpflvxzflgjfTDmfBlAb58kEpLRsUqOiS9hWB6vXOx v1ldGeepoREpkIvZ20ZPnKyDnCFQJhKZD8bzpQVcvb2SuIzCmhiz0Fq6HlkRAqqYA1MISpY1H2q EIb/8KQZAnWsn3HLf8NoU1jg3aSFHqzn/vkZ4us9X0vYE6bP8KSek15BkKTZCvrhBvQ7R6F8/4E BLiWJkiv3tNNdIPnx5/32GMLsYdcH7LSttnw4jPaBrW3qKMXCpLlWm1ERPYMlgSqRXuOOlnZFX3 HwBZIeSCkPcFVNbBEYZB2vV+ABBLBPpXUmzHDxQwrPETEDOUofWsEmiQFCFws9KlMPJN6rfGRt5 uSTcoJICv/2hLavxX8r5ywVXExD/uLebCy2VzpY9uTRsw4n6Hgn86SH9sZntdxINLDowpqfnHY9 0xMYLTqC4QsfIcSqHGDCzcP4rtHClj04FJAP/q X-Received: by 2002:a05:6830:4c0e:b0:7f6:705b:fff6 with SMTP id 46e09a7af769-8059e8508d4mr450538a34.3.1789169754190; Fri, 11 Sep 2026 16:35:54 -0700 (PDT) Received: from smtp-us-east1-p01-i01-si01.dlp.protect.broadcom.com (address-144-49-247-25.dlp.protect.broadcom.com. [144.49.247.25]) by smtp-relay.gmail.com with ESMTPS id 46e09a7af769-803f5df7d05sm1925055a34.6.2026.09.11.16.35.53 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Fri, 11 Sep 2026 16:35:54 -0700 (PDT) X-Relaying-Domain: broadcom.com X-CFilter-Loop: Reflected Received: by mail-qt1-f198.google.com with SMTP id d75a77b69052e-53013dc2330so29725151cf.0 for ; Fri, 11 Sep 2026 16:35:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; t=1789169753; x=1789774553; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=TL/+G3e3u5ILLrluIyCPB8J12Dl41Ws69Qu/dHBTdLE=; b=gZIQPoqdAAqhb5huqkn97h2zkxhCXrW65TjzrfniLxZLzqQjNMQqSULXslpNfugxqt +QURE23PufRHEySGKH+0aej0yvL8kT1wZx8yZhdd4rd6E67PbP6+uIt/EcaBnG5aIKDa INA5KTzuadk9yIYiNZ1CKahdNygL7h9dAEYi4= X-Forwarded-Encrypted: i=1; AKwUvBwyfa3pvjsO5nhgUZiW/2LWtz7kmOfkVtI9z2hyxCiLhlZ9jvpiQ7Tch4s0ZBKAgGC12cp22pbN0BrEduE=@vger.kernel.org X-Received: by 2002:ac8:6903:0:b0:530:cbf7:6bb7 with SMTP id d75a77b69052e-530e81f5bdamr6175151cf.49.1789169753254; Fri, 11 Sep 2026 16:35:53 -0700 (PDT) X-Received: by 2002:ac8:6903:0:b0:530:cbf7:6bb7 with SMTP id d75a77b69052e-530e81f5bdamr6174881cf.49.1789169752856; Fri, 11 Sep 2026 16:35:52 -0700 (PDT) Received: from stband-bld-1.and.broadcom.net ([192.19.144.250]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-9120f45ab71sm31717326d6.12.2026.09.11.16.35.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 11 Sep 2026 16:35:52 -0700 (PDT) From: Jim Quinlan To: linux-pci@vger.kernel.org, Nicolas Saenz Julienne , Bjorn Helgaas , Lorenzo Pieralisi , bcm-kernel-feedback-list@broadcom.com, jim2101024@gmail.com, james.quinlan@broadcom.com Cc: Florian Fainelli , Lorenzo Pieralisi , =?UTF-8?q?Krzysztof=20Wilczy=C5=84ski?= , Manivannan Sadhasivam , Rob Herring , linux-rpi-kernel@lists.infradead.org (moderated list:BROADCOM BCM2711/BCM2835 ARM ARCHITECTURE), linux-arm-kernel@lists.infradead.org (moderated list:BROADCOM BCM2711/BCM2835 ARM ARCHITECTURE), linux-kernel@vger.kernel.org (open list) Subject: [PATCH 04/13] PCI: brcmstb: Declare and assign quirk OB_WIN_32BIT_ADDR Date: Fri, 11 Sep 2026 19:35:29 -0400 Message-Id: <20260911233541.1650895-5-james.quinlan@broadcom.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260911233541.1650895-1-james.quinlan@broadcom.com> References: <20260911233541.1650895-1-james.quinlan@broadcom.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-DetectorID-Processed: b00c1d49-9d2e-4205-b15f-d015386d3d5e Even though only BMIPs chips have this quirk, it is more uniform and readable to define this specific quirk in which the outbound region must reside in the lower 4GB region. Signed-off-by: Jim Quinlan --- drivers/pci/controller/pcie-brcmstb.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers/pci/controller/pcie-brcmstb.c b/drivers/pci/controller/pcie-brcmstb.c index bf002bcf6bd5..71ddd8a760af 100644 --- a/drivers/pci/controller/pcie-brcmstb.c +++ b/drivers/pci/controller/pcie-brcmstb.c @@ -288,6 +288,8 @@ struct inbound_win { * or a hang (AXI). */ #define CFG_QUIRK_AVOID_BRIDGE_SHUTDOWN BIT(0) +/* The outbound windows must be within the 0-4GB region */ +#define CFG_QUIRK_OB_WIN_32BIT_ADDR BIT(1) /* FLAGS */ #define BFLAG(pcie, flag) ((pcie)->cfg->flags & CFG_FLG_ ## flag) @@ -519,7 +521,7 @@ static void brcm_pcie_set_outbound_win(struct brcm_pcie *pcie, PCIE_MISC_CPU_2_PCIE_MEM_WIN0_BASE_LIMIT_LIMIT_MASK); writel(tmp, pcie->base + PCIE_MEM_WIN0_BASE_LIMIT(win)); - if (is_bmips(pcie)) + if (BQUIRK(pcie, OB_WIN_32BIT_ADDR)) return; /* Write the cpu & limit addr upper bits */ @@ -1995,6 +1997,7 @@ static const struct pcie_cfg_data bcm7425_cfg = { .perst_set = brcm_pcie_perst_set_generic, .bridge_sw_init_set = brcm_pcie_bridge_sw_init_set_generic, .num_inbound_wins = 3, + .quirks = CFG_QUIRK_OB_WIN_32BIT_ADDR, }; static const struct pcie_cfg_data bcm7435_cfg = { @@ -2003,6 +2006,7 @@ static const struct pcie_cfg_data bcm7435_cfg = { .perst_set = brcm_pcie_perst_set_generic, .bridge_sw_init_set = brcm_pcie_bridge_sw_init_set_generic, .num_inbound_wins = 3, + .quirks = CFG_QUIRK_OB_WIN_32BIT_ADDR, }; static const struct pcie_cfg_data bcm7216_cfg = { -- 2.34.1