From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ot1-f99.google.com (mail-ot1-f99.google.com [209.85.210.99]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 94CAE2F7F07 for ; Fri, 11 Sep 2026 23:36:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.99 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789169766; cv=none; b=BeTfA5DJH610BZmj293mBbu9noOT5gqz7EQc1rLIlFtSETwE7h6xPF65H7VZ5Yfh0PhD6PB7kP6t5EvF7h80KX+iJJ0GKJlO26jp1xTZr1903/joe1YU+DYAsJ6rRwOV99zMDOmKo7izjA8JFokNUOFyw8KAvq9kw/reTJzqlAs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789169766; c=relaxed/simple; bh=IOzcB3Bmrz2d/LpZV9YPGC7WVt70Kz1xAnQJkxk+nKQ=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=iqrOx/NhIt+ZQVFHMoriACLo2ZfGoQzyk7chKUGjgLOGEdcVrr1asOMilEg6aXPjiBrEBM0KmYQaK3m0OdpUrnMPWSsnN/LNXPPVJLAi13J2yF093Rytle4Wn/4s4xOLLT8aWLcR5Op9hPleInwprJH3PhfLXZPj4oss9sd3jIQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=broadcom.com; spf=fail smtp.mailfrom=broadcom.com; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b=bmh0DkUG; arc=none smtp.client-ip=209.85.210.99 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=broadcom.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=broadcom.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b="bmh0DkUG" Received: by mail-ot1-f99.google.com with SMTP id 46e09a7af769-80576d65d8eso271980a34.1 for ; Fri, 11 Sep 2026 16:36:04 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1789169763; x=1789774563; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=URIpbMJfCXSfu2fCsU8nZeVa+T330OFxkgZkw90cYgk=; b=OOuTy+aQn/cPXfnlnERv79OpFYy7OfxRAGwrv2ZAxVfB0f7F1G7/tkfpwSFAfTJIJz IZEPQ3IBZlbPTmmqE1IzxjsY3/FVHXe+G5mBYL5E8P3J3NaViaYtb8SiphKcPiovz/kE PIRFaygEIh3imjsaiylvSxk0NLckHSn020OrgSIfR+wz1nrUjVgIboo7PQ+Bt+JuqQVc sRp91PADMHtjO+HdCj3MxQWGOqgi+w6D33hOWHzbpvHWxttXrTEkfvK6NDtj5jQsJWTx PwxNUzSn7E6V/HPhPCIhv9HBM9FWkKP+d2UImigYOhCl5Gci5W5LkHheI49bWbbIuLgP mtuw== X-Forwarded-Encrypted: i=1; AKwUvByBbY61HZCR632ffHuG2RzRPYUfPwvr4hyMJ/RakoztP6gqu5HPJoP1FOpeC8O1vdpnQoF7WqgMvHcdhZ0=@vger.kernel.org X-Gm-Message-State: AFuF++k+78aB8rZ/KHBEn/dGUDV88oxkj5XKtLvjqE34iZoarQYywsP+ aETK4o+y/pyf696Dz3N/L+teybJ4wiEMQHrG1pzkr2cZxAUF4+GE43n4LzPFfhTx4I4DKAVvAua CjUCx+DNSgQ0s3vGnE5wqKDhqvpTSUxHiduEBGAH5ZSTX5qpuZvWghiapP/5QGnrViH6y1ZyjsC 6TncPTwtygxDCV65RsWkIpg+taGHD859N8jE9sT3mMZt8DagpBJp9POPJwKA9XY95Z3b6mVSdpi Yyl8aVXF1eST3FoxW6r X-Gm-Gg: AYBFou0u4p7lcEsEMTbnYCh+XdnQ9kukTEVAhAQ5+kxJMIxA3ePLjPn4IXRJlLJ8t62 7X53f/Qw3FNh4Q6z16SkMVpEm0DzJQCGS8qrgswZTmjSoWTac95jTozZCqUd/Uz3xCm+Hq+BAfo FXPZeopuNRbu/AWeW9A+nEYL70WokdEb2a7DAde1cj/ZVAWiN/7m8Gk4L+wIi/55kR00K3TiLZT UHf390qR/Fu2fZjOH3JA1er05IZXqRfOXAuA5RlK5JrSzbdazLn+w5kMbaDjnSdCCHBSccIF5PJ 0MWz1q3/c8uMRd8ZlQG5ww70ARrLxC/4oFu3kyC/fl0ASEMudpntpKj43ZV3ksdqeQfd3+1tqCS svIXYBHKE+f7OBveOErRF+tumk13Y5EtfsNkTTMyuKt+GAyEbORzAa0QOClH1 X-Received: by 2002:a05:6830:6af8:b0:7f8:9fba:2cd8 with SMTP id 46e09a7af769-803ff332991mr5302083a34.9.1789169763488; Fri, 11 Sep 2026 16:36:03 -0700 (PDT) Received: from smtp-us-east1-p01-i01-si01.dlp.protect.broadcom.com ([144.49.247.127]) by smtp-relay.gmail.com with ESMTPS id 46e09a7af769-803f681202bsm1943382a34.8.2026.09.11.16.36.02 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Fri, 11 Sep 2026 16:36:03 -0700 (PDT) X-Relaying-Domain: broadcom.com X-CFilter-Loop: Reflected Received: by mail-qv1-f70.google.com with SMTP id 6a1803df08f44-9104417215aso30312046d6.2 for ; Fri, 11 Sep 2026 16:36:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; t=1789169762; x=1789774562; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=URIpbMJfCXSfu2fCsU8nZeVa+T330OFxkgZkw90cYgk=; b=bmh0DkUGP2C2lyTfkz4LfPvUJnyKpl/ZMo1CKOQMQr2EJ+P5U/YtEjGwaUQb/T+jRp moyS/1Bo2kCM4V9UEY8N5+SJpey9g7nUsCFbP1OGgZIJ9Nxqoi1Vq7ssdTVifFv9h/5A Y+sB0LIbYl9Bg7agZ3fsmkJFsTWcIhPwCWBQo= X-Forwarded-Encrypted: i=1; AKwUvBwogSB7YHQydMzD2Y8WVgfcufE65R71VsnPW1XggeAuVWVlsxYdjpcTpVcQ6tzliLIDFTVojyFrVpKCNng=@vger.kernel.org X-Received: by 2002:ad4:5e8b:0:b0:910:63f9:29f9 with SMTP id 6a1803df08f44-91212086712mr89710786d6.10.1789169761773; Fri, 11 Sep 2026 16:36:01 -0700 (PDT) X-Received: by 2002:ad4:5e8b:0:b0:910:63f9:29f9 with SMTP id 6a1803df08f44-91212086712mr89710446d6.10.1789169761388; Fri, 11 Sep 2026 16:36:01 -0700 (PDT) Received: from stband-bld-1.and.broadcom.net ([192.19.144.250]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-9120f45ab71sm31717326d6.12.2026.09.11.16.35.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 11 Sep 2026 16:36:01 -0700 (PDT) From: Jim Quinlan To: linux-pci@vger.kernel.org, Nicolas Saenz Julienne , Bjorn Helgaas , Lorenzo Pieralisi , bcm-kernel-feedback-list@broadcom.com, jim2101024@gmail.com, james.quinlan@broadcom.com Cc: Florian Fainelli , Lorenzo Pieralisi , =?UTF-8?q?Krzysztof=20Wilczy=C5=84ski?= , Manivannan Sadhasivam , Rob Herring , linux-rpi-kernel@lists.infradead.org (moderated list:BROADCOM BCM2711/BCM2835 ARM ARCHITECTURE), linux-arm-kernel@lists.infradead.org (moderated list:BROADCOM BCM2711/BCM2835 ARM ARCHITECTURE), linux-kernel@vger.kernel.org (open list) Subject: [PATCH 08/13] PCI: brcmstb: Declare and assign quirk NO_RGR1_TIMER Date: Fri, 11 Sep 2026 19:35:33 -0400 Message-Id: <20260911233541.1650895-9-james.quinlan@broadcom.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260911233541.1650895-1-james.quinlan@broadcom.com> References: <20260911233541.1650895-1-james.quinlan@broadcom.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-DetectorID-Processed: b00c1d49-9d2e-4205-b15f-d015386d3d5e Very few SoCs do not have an internal bus timer whose timeout value may be adusted for L1SS operation. Declare this as a quirk and assign it accordingly. Signed-off-by: Jim Quinlan --- drivers/pci/controller/pcie-brcmstb.c | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/drivers/pci/controller/pcie-brcmstb.c b/drivers/pci/controller/pcie-brcmstb.c index be414d346855..e2284e114241 100644 --- a/drivers/pci/controller/pcie-brcmstb.c +++ b/drivers/pci/controller/pcie-brcmstb.c @@ -294,6 +294,8 @@ struct inbound_win { #define CFG_QUIRK_OB_WIN_MAXSZ_128MB BIT(2) /* PCIe HW can only access config space with 32bit R/W */ #define CFG_QUIRK_32BIT_PCI_OPS BIT(3) +/* PCIe HW does not have an internal bus timer */ +#define CFG_QUIRK_NO_RGR1_TIMER BIT(4) /* FLAGS */ #define BFLAG(pcie, flag) ((pcie)->cfg->flags & CFG_FLG_ ## flag) @@ -1339,8 +1341,8 @@ static void brcm_extend_rbus_timeout(struct brcm_pcie *pcie) const unsigned int REG_OFFSET = PCIE_RGR1_SW_INIT_1(pcie) - 8; u32 timeout_us = 4000000; /* 4 seconds, our setting for L1SS */ - /* 7712 does not have this (RGR1) timer */ - if (pcie->cfg->soc_base == BCM7712) + /* Don't do access if there is no timer */ + if (BQUIRK(pcie, NO_RGR1_TIMER)) return; /* Each unit in timeout register is 1/216,000,000 seconds */ @@ -1971,7 +1973,8 @@ static const struct pcie_cfg_data bcm2712_cfg = { .perst_set = brcm_pcie_perst_set_7278, .bridge_sw_init_set = brcm_pcie_bridge_sw_init_set_generic, .post_setup = brcm_pcie_post_setup_bcm2712, - .quirks = CFG_QUIRK_AVOID_BRIDGE_SHUTDOWN, + .quirks = CFG_QUIRK_AVOID_BRIDGE_SHUTDOWN | + CFG_QUIRK_NO_RGR1_TIMER, .num_inbound_wins = 10, }; @@ -2028,6 +2031,7 @@ static const struct pcie_cfg_data bcm7712_cfg = { .bridge_sw_init_set = brcm_pcie_bridge_sw_init_set_generic, .soc_base = BCM7712, .num_inbound_wins = 10, + .quirks = CFG_QUIRK_NO_RGR1_TIMER, }; static const struct of_device_id brcm_pcie_match[] = { -- 2.34.1