mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Darrick J. Wong" <djwong@kernel.org>
To: Karl Mehltretter <kmehltretter@gmail.com>
Cc: Jens Axboe <axboe@kernel.dk>, Jan Kara <jack@suse.cz>,
	Christian Brauner <brauner@kernel.org>,
	linux-block@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] block: Fix the thaw_bdev reference in bdev_freeze() kernel-doc
Date: Fri, 11 Sep 2026 16:54:51 -0700	[thread overview]
Message-ID: <20260911235451.GD6283@frogsfrogsfrogs> (raw)
In-Reply-To: <20260911233415.31271-1-kmehltretter@gmail.com>

On Sat, Sep 12, 2026 at 01:34:14AM +0200, Karl Mehltretter wrote:
> The kernel-doc comment of bdev_freeze() refers to thaw_bdev, which was
> renamed to bdev_thaw by commit 982c3b305843 ("bdev: rename freeze and
> thaw helpers"). Say bdev_thaw.
> 
> Fixes: 982c3b305843 ("bdev: rename freeze and thaw helpers")
> Assisted-by: LLM
> Signed-off-by: Karl Mehltretter <kmehltretter@gmail.com>

Not sure why I'm on this, but this is correct so
Reviewed-by: "Darrick J. Wong" <djwong@kernel.org>

--D

> ---
>  block/bdev.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/block/bdev.c b/block/bdev.c
> index cd8323083740604da145563aa8e7b55c4f627467..fac74319e9fbacc9cf2bec4a4b043b837a9678ab 100644
> --- a/block/bdev.c
> +++ b/block/bdev.c
> @@ -292,7 +292,7 @@ EXPORT_SYMBOL(sync_blockdev_range);
>   * The reference counter (bd_fsfreeze_count) guarantees that only the last
>   * unfreeze process can unfreeze the frozen filesystem actually when multiple
>   * freeze requests arrive simultaneously. It counts up in bdev_freeze() and
> - * count down in bdev_thaw(). When it becomes 0, thaw_bdev() will unfreeze
> + * count down in bdev_thaw(). When it becomes 0, bdev_thaw() will unfreeze
>   * actually.
>   *
>   * Return: On success zero is returned, negative error code on failure.
> -- 
> 2.39.5 (Apple Git-154)
> 

      reply	other threads:[~2026-09-11 23:54 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-11 23:34 Karl Mehltretter
2026-09-11 23:54 ` Darrick J. Wong [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260911235451.GD6283@frogsfrogsfrogs \
    --to=djwong@kernel.org \
    --cc=axboe@kernel.dk \
    --cc=brauner@kernel.org \
    --cc=jack@suse.cz \
    --cc=kmehltretter@gmail.com \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®