From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-oo2-f0.google.com (mail-oo2-f0.google.com [74.125.231.128]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 98B8037266D for ; Sat, 12 Sep 2026 06:40:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.231.128 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789195259; cv=none; b=TtiakGqlBydPBPnrTlNWWdVJ+3cKfhC5YKW4WBTz+MI3GH9k2FhGowJLCcuN+Y/bE1ZXaIm9ayA3isxBVfv0rZXyLMdxWQlbHyL+xB5cxGHo1iL8fhJr5tz7velWbPFbcA1VsymTK1Jt5KlqmHgakUX9vFF5oo2P7eKzRQHLtXo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789195259; c=relaxed/simple; bh=Zt1FOqW2KqdoRYXtktantBzoTQDsX3R4Zq/f08ZKesg=; h=From:Subject:Date:Message-Id:MIME-Version:Content-Type:To:Cc; b=XsR7P+B1F8jMcJUY7TqpXVoMVUXiv3RpGT3Vbpq0zzYZGybsqjrtVTCV9Kyf4eJYuursKQ4kLgsvssR/v2x0UKUg2i6MedZFjOxouTRJAr5ZljJXiPpnljQRSL2O//iQf9LdXFPJ23umIbky9OgRFjvAar4p0LlyRqFucsbXMTY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=fi58I/Om; arc=none smtp.client-ip=74.125.231.128 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="fi58I/Om" Received: by mail-oo2-f0.google.com with SMTP id 46e09a7af769-8047334328bso495710a34.0 for ; Fri, 11 Sep 2026 23:40:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1789195255; x=1789800055; darn=vger.kernel.org; h=cc:to:content-transfer-encoding:content-type:mime-version :message-id:date:subject:from:from:to:cc:subject:date:message-id :reply-to:content-type; bh=Q640RqR38QE29MmVFWdMcnQiW2Q7cR4iK1FcWO3aAjg=; b=fi58I/Om4SpWy3H9MKVurYtfbzLAPNGCP+iWiyuhSarAOyZFmJ90jrzUeX0uK8KPQu YgXmFx5Z6fWbxC1XE6vCMq7uBOAitIBJ0nYbFo8IiACk11GZZEXtmF2zIk4MGSAHf9Gh lMpjvuTspCXX+L/CJOyuYaWm9vn7+RmJkDNfGzHqRmg07UMy+nLkq+qzCB1YDeKBf5Mv KabTMs6iX6EAn5uNGT1IQIZNMth7xBm4hHKWv2W89Bx+cX9nzpENX0rgsp+aabtckjJF gNz3q5uSMDo015pIWmbv6Pn1CmYqJIehon5DDr1lV3XNX5M8xQyTz9jYgYbAyeJ5Bmlk 916A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1789195255; x=1789800055; h=cc:to:content-transfer-encoding:content-type:mime-version :message-id:date:subject:from:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to:content-type; bh=Q640RqR38QE29MmVFWdMcnQiW2Q7cR4iK1FcWO3aAjg=; b=MNqC9XLZx+oYMK+6UEcq3L8hdtrOdpcPSASlLA/uebNJYXYwcIBQ+jzLJTMwvtzqJO J6sj6uudCYVPCT0LCmGibx1LJjyAnqKW/jR4csl0uEpquo9zX0EKS5h8F2D5lcbVBxtV cGoKiYGVybGKG/rXTbUPcOthib4IFvA1XGEQMh1ZE72jtTB6HZwuEvD5I1qLj0POVTgQ kOYmyrNiUCSd7SuhC7p++C+tXWHuCsCu8KC0+9hdkvrEeyDOCbubLsqC/YTYDvvgVlGC v1lt3OoxQXNcay2gRs52ef1VT08dw0yDUU/fFD091LSTCzNa74f/0QzI2VcJRkPtnmY/ P63g== X-Forwarded-Encrypted: i=1; AKwUvBztGjqfvr1mS4KxTMkjAr6g4p8qGhzV6U5xzyehWorxOMyHiTuZ32CRkDcf23mLxF1TFqDIQP+jb1ketgQ=@vger.kernel.org X-Gm-Message-State: AFuF++nfuCYJkfuiPkyief/htxYzikDDoikbDwhuIDkWmw2P0C+/krmB +lK7XSeJj91eteE5j+wJIYauDmVVikXoaUMi9J7KtwdUNPOlANMAEAw5 X-Gm-Gg: AYBFou3uiopt1Z01e6zg0Bue9jBJa6CdjuI/NEyxTOfNE1rktWjgNi46PvQ6T+IG+wf PVJ74xpIh+NaLWlKRXExso76XDRDfeeyWnp1C4ECPAyILJfbecu99ddU/6Pmbqhl6Q6wf39L74l jucs1CCC4uBxQPp3NrBjX3OMvNDCslsxefooiu+vhOEFJz3GchE9suX0VvYoO6+i7ypEdrd+r7D ab0Hetf29kbDYKshQeVEaMzLD/xgAFdNuznVs5KwVs3V2Qv47KgJUeIGoVUkEIxQPV83pp42jgG GXW7QTcStC1mw6kdFaQ6MXGeUE0DKlaRd6JPlx68zupGVvgw61Fc39bchhuaJpciOJTOVJNQi+j oiS01RrdBvcXjhgt4X33Z4ePwuGEKRBoGqsKUk5fsI2Hr3zVlsv9AnksL+O8JNzytC0xlHACCMs glzLeSYWLfhcfrymZ2SR4Na8yLVMvG9Qku3tJyCRI/xMZuUcsd/kfsX9BsLBmh1H/OnRA= X-Received: by 2002:a05:6830:348e:b0:7f4:d1aa:2f32 with SMTP id 46e09a7af769-803fd871808mr7192047a34.11.1789195254741; Fri, 11 Sep 2026 23:40:54 -0700 (PDT) Received: from [192.168.18.164] ([2600:8804:5716:d800::b712]) by smtp.gmail.com with ESMTPSA id 46e09a7af769-803f670ec82sm4932735a34.20.2026.09.11.23.40.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 11 Sep 2026 23:40:53 -0700 (PDT) From: Ryan Brue Subject: [PATCH 0/2] clk: mediatek: Fix FHCTL DDS mask widths for mt8173, mt6795 Date: Sat, 12 Sep 2026 01:40:36 -0500 Message-Id: <20260912-mt8173-fix-dds-mask-width-v1-0-3d0c0292c85c@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-B4-Tracking: v=1; b=H4sIAAAAAAAC/yXMyw6CQAyF4VchXduEjmZAX8WwgGmBakAzHS8J4 d0dYfkl5/wLmEQVg0uxQJS3mj7mDDoUEMZ2HgSVs8GVzpdncjilmqoj9vpFZsOptTt+lNOIPnQ VBd/LiQny/xklr7b2tdltr+4mIf2DsK4/qaqIzX0AAAA= X-Change-ID: 20260912-mt8173-fix-dds-mask-width-6cb71c6fe4d1 To: Stephen Boyd , Brian Masney , Jerome Brunet , Matthias Brugger , AngeloGioacchino Del Regno , Chen-Yu Tsai Cc: linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, Ryan Brue X-Mailer: b4 0.16.0 X-Developer-Signature: v=1; a=ed25519-sha256; t=1789195251; l=1557; i=ryanbrue.dev@gmail.com; s=20260906; h=from:subject:message-id; bh=Zt1FOqW2KqdoRYXtktantBzoTQDsX3R4Zq/f08ZKesg=; b=f+gU2KPV4GL3RlxKjra3EBgbSRpjeS0ghAYC7hkFJHSavKdwLttmPfViyyZOeMjxCFe3rP57A +UtDJosJl5FDBkDh1Pme7YytT+JN9WWHnOdfvJLKSqQ3pYoiBiSGLRM X-Developer-Key: i=ryanbrue.dev@gmail.com; a=ed25519; pk=KsUvVaP//v/2q+ZBuacc7cLbsyEYn+AD71Sn28oZWKo= Discovered this while working on bringup for the Amazon Fire HD 10 (2017). In f222a1baec5f ("clk: mediatek: mt6795: Add support for frequency hopping through FHCTL"), and 45a5cbe05d1f ("clk: mediatek: mt8173: Add support for frequency hopping through FHCTL"), the DDS masks were set to the same GENMASK(21, 0) as mt8186, mt8192, and mt8195, despite not having the same pcwbits (21 as opposed to 22). These two patches correct that. Tested on an Amazon Fire HD 10 (2017), an mt8173 tablet, across 6 MMPLL rate changes. All of them timed out prior to this patchset, and all of them succeed with the patchset. mt8173 currently doesn't use FHCTL, but this will correct it for the future in case it does get used. I do not have an mt6795 to test with, but mt6795-sony-xperia-m5.dts is an actual consumer of the FHCTL node, and switches it on for mainpll, mpll and msdcpll. If someone has that device to test the second patch, that would be appreciated. I do believe this is the correct fix though regardless. Signed-off-by: Ryan Brue --- Ryan Brue (2): clk: mediatek: mt8173: fix the FHCTL DDS mask width clk: mediatek: mt6795: fix the FHCTL DDS mask width drivers/clk/mediatek/clk-mt6795-apmixedsys.c | 2 +- drivers/clk/mediatek/clk-mt8173-apmixedsys.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) --- base-commit: df2908090cda368b01ff43709f51890076c56157 change-id: 20260912-mt8173-fix-dds-mask-width-6cb71c6fe4d1 Best regards, -- Ryan Brue