From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pz2-f42.google.com (mail-pz2-f42.google.com [74.125.228.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3A7B6313545 for ; Sat, 12 Sep 2026 01:28:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.228.42 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789176510; cv=none; b=ujlc6N6DL2on4MzURPLILMFJvOodUwJIf/+GGnOnqHyLR+uBI+idc/SNN+5Q0gNJ8I9lIPYhYbboiRDHtObdXEK+8Pbm1XD0ru8QMDXg+QBGwwMZEjdJeGQ8yrSteHGyY3mPZVeUWAMmBrmtrlV1IdY8OnrCLqXV7ISbSEvuTnE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789176510; c=relaxed/simple; bh=uVvlkd3r7AzFL0bwoPRshRxUVPE5PJY2DyGjC0onaAw=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=CdU/AH6/hNL+9FDo4OXeebrru5MSnpPiVt0+lboXT8UIsh9gjaNVOACG+w/tZIbMAKBVqasnjcmkn1U2aobpT15q81nSRVLvN19Iu98K80pknYMW9U6kj2uXyVeg1OApcarFvFO5Y5CPaUm6zWtTX25kM430RaIz5HXY0wgvjPo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=g03UzGRQ; arc=none smtp.client-ip=74.125.228.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="g03UzGRQ" Received: by mail-pz2-f42.google.com with SMTP id d2e1a72fcca58-85469b35601so72266b3a.3 for ; Fri, 11 Sep 2026 18:28:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1789176506; x=1789781306; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=5Ohl5GXWK7z9PSL07FA+1qnT/VjHf89JQfhIV3tvy2o=; b=g03UzGRQ9ZwuOM24HyaKxUOZBtLeszngZetHR/AM1wKRhPNdOc8dRDPwVpOuKaR/lb P/w3KGQ/fATjOO3sU1bmsrbdbr5GvPHjKRjWT5Jnp3UdMvdvpZk+3j2BsJFY/+CVlKhT 66ko0/1OzzCC3zyHvTgsrYRZ5U65thM+N9vsz0SSh7YMIOYaT8l9JIg7MlXpbwV7xMvm IQKM36WfZ48cwoia5ZgwYRQPDyeRP2xCL+/YNGWsRTKkvda27Z2YcgcNt2Hqk6LWo4AR tnPSEndhX+ucn9QwLf2dP0T4cjVk2joD8XgvfsJke9bkvBsqe76dEgqvtdu53i4zAyoQ 7CwQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1789176506; x=1789781306; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=5Ohl5GXWK7z9PSL07FA+1qnT/VjHf89JQfhIV3tvy2o=; b=HlNq/CFZ1C9lVjKCMWcxOnyV4lA7Yzgwrgx/2eIBPX3or0W4Jv+l67c2rt+QTueXwk i+xAUS+E8q+4bZuVpKzl9qWr1Ate68Qtp1gTDWr2C+8jr/jWxLhcHkNUCUS2+sJBBMvP W9HyuC62b4WUfo6yBfJLqhDLWQ87zEYrBfLvcVaDLe8Zas/pegUHsEbJofhC0ubFNAio jse9SnYjlibNFd8qBWGfUh+u7LeyVWVdpTqmAJweKj40CI1KvN9vI9dto3e/ygcJ01Yp PGkme3Xz5NaTx01+xQM/4chlcxK8HJPmd3bJQ0lsUd0tnj/76R1Jf5Is+UgH2KtdoYSw bBEQ== X-Forwarded-Encrypted: i=1; AKwUvBwpkZQbphRYFeuDz5rSR8EA1saOnkNSm4kICIns+X0G29tS48o+IwM5kjujLfHIUcdbCNY97ijwSIyJOfU=@vger.kernel.org X-Gm-Message-State: AFuF++l9qaORto5I0XAUrZXrHXfEULM9WiuIpbpPR1Ae9YzVXwpR8SRx YEKoGTmuyIHMlWRHMDV2aMkMJSFdkPWfQMIPlsaZXX8d8hQV4cVPgl4= X-Gm-Gg: AYBFou3Sd9e1HTohUNebnSu2ZxNG7sLoyYPSVC5ZH4p0WvKv+vadIvAhozjvjyIASqK nKqPRqwM2ZscMYzIDfH743wQj3OSonTyFqWEHBSBG8TQBbkOyAYEKBWZd8xQHH8YxyuApWl3vMc dzFLsJZNYw441Vo6JuNEz0WWDly9lBLLsuUTImiXG+J+jhTdtImQBG46X54zRE5AIEWfbSfuzEq /jWCoPTVsenLRNaWMr6NPFJG8t1xThN5MAcFllSubl0e/cgmEx16t20D8flkTz8oSk0/XtMzQbI d2OdcxYx3qGmAsLMKcYbNEaAPwDKyNO/pR9H4bhwHJauhcCQerYE6ZtP2fnPy+GHv3xdRMAk/cP McE5pVYrfvchO6sIhG5qEvmJ+h54JMRyccJje/w8AycueqQ9ci2c37CvR3cqZyOTQMwdqnhzk92 tFiA4+966j94lYmL2e85KPRpBWg4HQZS6LfY9nLIsyoP1679HGOVuL+ph9AwvPli005g+gwnELT 1CMirdSxSWRze/lJGdfJPz4jbPa5qT/aDE= X-Received: by 2002:a05:6a00:94fd:b0:84e:89a:b8ec with SMTP id d2e1a72fcca58-86cca73e429mr1155632b3a.11.1789176506482; Fri, 11 Sep 2026 18:28:26 -0700 (PDT) Received: from ydg-Zenbook-14-UM3406GA ([211.230.25.193]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-86b291c1601sm1805850b3a.31.2026.09.11.18.28.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 11 Sep 2026 18:28:25 -0700 (PDT) From: Donggeun Yoo To: Andrew Lunn , Heiner Kallweit , "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni Cc: Russell King , netdev@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, Sashiko , donggeunyoo.kernel@gmail.com, stable@vger.kernel.org Subject: [PATCH net] net: phy: qca808x: handle the active-high LED polarity mode Date: Sat, 12 Sep 2026 10:28:19 +0900 Message-ID: <20260912012819.2072067-1-donggeunyoo.kernel@gmail.com> X-Mailer: git-send-email 2.53.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Commit a274465cc3be ("net: phy: support 'active-high' property for PHY LEDs") added PHY_LED_ACTIVE_HIGH but did not cover qca808x, so qca808x_led_polarity_set() returns -EINVAL for it. phy_probe() propagates that, leaving the mdio device unbound and phy_attach_direct() falling back to the genphy driver. Accepting the mode alone is not enough: led_polarity_mode records active_low, so an explicit 'active-high' node stores 0, while qca808x_config_init() re-asserts QCA808X_LED_ACTIVE_HIGH only for -1. The bit does not survive the reset phy_init_hw() runs first, so the LED would come up active-low. Reported-by: Sashiko Closes: https://netdev-ai.bots.linux.dev/sashiko/#/patchset/20260908105959.70453-1-donggeunyoo.kernel%40gmail.com Cc: stable@vger.kernel.org Fixes: a274465cc3be ("net: phy: support 'active-high' property for PHY LEDs") Signed-off-by: Donggeun Yoo Assisted-by: Claude:claude-fable-5 checkpatch sparse --- Supersedes [PATCH net v3 3/3] (20260908105959.70453-4-donggeunyoo.kernel@gmail.com); 1/3 and 2/3 are in mainline. Andrew Lunn's Reviewed-by on v3 3/3 is dropped -- this changes behavior. Compile-tested only (W=1, sparse). I have no QCA808x hardware, and there is no KUnit suite or MDIO mock under drivers/net/phy to exercise the MMD7 write without it. drivers/net/phy/qcom/qca808x.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/drivers/net/phy/qcom/qca808x.c b/drivers/net/phy/qcom/qca808x.c index 8eb51b1a006c..68fd4d0fe31b 100644 --- a/drivers/net/phy/qcom/qca808x.c +++ b/drivers/net/phy/qcom/qca808x.c @@ -200,8 +200,8 @@ static int qca808x_config_init(struct phy_device *phydev) struct qca808x_priv *priv = phydev->priv; int ret; - /* Default to LED Active High if active-low not in DT */ - if (priv->led_polarity_mode == -1) { + /* Set LED Active High unless active-low was requested in DT */ + if (priv->led_polarity_mode != 1) { ret = phy_set_bits_mmd(phydev, MDIO_MMD_AN, QCA808X_MMD7_LED_POLARITY_CTRL, QCA808X_LED_ACTIVE_HIGH); @@ -603,6 +603,9 @@ static int qca808x_led_polarity_set(struct phy_device *phydev, int index, case PHY_LED_ACTIVE_LOW: active_low = true; break; + case PHY_LED_ACTIVE_HIGH: + active_low = false; + break; default: return -EINVAL; } -- 2.53.0