From: Jakub Kicinski <kuba@kernel.org>
To: Narcisa Vasile <narcisav.kernel@gmail.com>
Cc: netdev@vger.kernel.org, daniel.zahka@gmail.com,
andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@google.com,
pabeni@redhat.com, shuah@kernel.org, horms@kernel.org,
willemb@google.com, petrm@nvidia.com, anubhavsinggh@google.com,
richardbgobert@gmail.com, linux-kselftest@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next v2] selftests: drv-net: add BIG TCP test cases
Date: Sat, 12 Sep 2026 09:32:26 -0700 [thread overview]
Message-ID: <20260912093226.529ff414@kernel.org> (raw)
In-Reply-To: <20260912050327.20616-1-narcisav.kernel@gmail.com>
On Fri, 11 Sep 2026 22:03:27 -0700 Narcisa Vasile wrote:
> Add four new test cases that validate coalescing
> under increased size limits (BIG TCP):
>
> big_tcp_data_same
> - validates that equal-sized segments coalesce past
> the legacy IP_MAXPACKET limit.
> big_tcp_data_lrg_sml
> - validates that a smaller final segment coalesces into the
> previous chain of large-sized segments while crossing the
> IP_MAXPACKET limit.
> big_tcp_tcp_seq
> - validates that a packet with a wrong sequence number doesn't
> coalesce. The test uses a sequence number for which the low 16 bits
> correspond to the correct sequence number to validate against
> truncation bugs, since total aggregate length crosses over the
> legacy size limit for BIG TCP.
> big_tcp_large_max
> - validates that coalescing stops at the configured BIG TCP limit.
Still failing:
https://netdev-ctrl.bots.linux.dev/logs/vmksft/net-drv-dbg/results/819882/3-gro-sw-py/stdout
https://netdev-ctrl.bots.linux.dev/logs/vmksft/net-drv-dbg/results/819882/3-gro-sw-py-retry/stdout
Grep gro_lib.py for KSFT_MACHINE_SLOW
Then the 15x increase is probably unnecessary/too high as well, since
we GRO 64k 128k shouldn't need more than 2x ?
next prev parent reply other threads:[~2026-09-12 16:32 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-12 5:03 Narcisa Vasile
2026-09-12 16:32 ` Jakub Kicinski [this message]
2026-09-12 18:21 ` Narcisa Vasile
2026-09-12 18:40 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260912093226.529ff414@kernel.org \
--to=kuba@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=anubhavsinggh@google.com \
--cc=daniel.zahka@gmail.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=narcisav.kernel@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=petrm@nvidia.com \
--cc=richardbgobert@gmail.com \
--cc=shuah@kernel.org \
--cc=willemb@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®