From: SJ Park <sj@kernel.org>
Cc: SJ Park <sj@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
damon@lists.linux.dev, linux-kernel@vger.kernel.org,
linux-mm@kvack.org
Subject: [RFC PATCH 6/8] mm/damon/sysfs-schemes: use switch-case in add_scheme_filters()
Date: Sat, 12 Sep 2026 12:18:04 -0700 [thread overview]
Message-ID: <20260912191807.138502-7-sj@kernel.org> (raw)
In-Reply-To: <20260912191807.138502-1-sj@kernel.org>
damon_sysfs_add_scheeme_filters() has long if-else chains for DAMOS
filter types. Convert the code to use switch-case, which would be
cleaner and more efficient.
Signed-off-by: SJ Park <sj@kernel.org>
---
mm/damon/sysfs-schemes.c | 18 +++++++++++++-----
1 file changed, 13 insertions(+), 5 deletions(-)
diff --git a/mm/damon/sysfs-schemes.c b/mm/damon/sysfs-schemes.c
index a4ec5d54cfbd1..bfb6f0bc3f213 100644
--- a/mm/damon/sysfs-schemes.c
+++ b/mm/damon/sysfs-schemes.c
@@ -2822,7 +2822,8 @@ static int damon_sysfs_add_scheme_filters(struct damos *scheme,
if (!filter)
return -ENOMEM;
- if (filter->type == DAMOS_FILTER_TYPE_MEMCG) {
+ switch (filter->type) {
+ case DAMOS_FILTER_TYPE_MEMCG:
err = damon_sysfs_memcg_path_to_id(
sysfs_filter->memcg_path,
&filter->memcg_id);
@@ -2830,16 +2831,23 @@ static int damon_sysfs_add_scheme_filters(struct damos *scheme,
damos_destroy_filter(filter);
return err;
}
- } else if (filter->type == DAMOS_FILTER_TYPE_ADDR) {
+ break;
+ case DAMOS_FILTER_TYPE_ADDR:
filter->addr_range = sysfs_filter->addr_range;
- } else if (filter->type == DAMOS_FILTER_TYPE_TARGET) {
+ break;
+ case DAMOS_FILTER_TYPE_TARGET:
filter->target_idx = sysfs_filter->target_idx;
- } else if (filter->type == DAMOS_FILTER_TYPE_HUGEPAGE_SIZE) {
+ break;
+ case DAMOS_FILTER_TYPE_HUGEPAGE_SIZE:
filter->sz_range.min = sysfs_filter->range_min;
filter->sz_range.max = sysfs_filter->range_max;
- } else if (filter->type == DAMOS_FILTER_TYPE_PROBE_HITS_WSUM) {
+ break;
+ case DAMOS_FILTER_TYPE_PROBE_HITS_WSUM:
filter->range_min = sysfs_filter->range_min;
filter->range_max = sysfs_filter->range_max;
+ break;
+ default:
+ break;
}
damos_add_filter(scheme, filter);
--
2.47.3
next prev parent reply other threads:[~2026-09-12 19:18 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-12 19:17 [RFC PATCH 0/8] mm/damon: move damos filter range arguments validation to core SJ Park
2026-09-12 19:17 ` [RFC PATCH 1/8] mm/damon/sysfs-schemes: read sysfs_filter->addr_range only once SJ Park
2026-09-12 19:18 ` [RFC PATCH 2/8] mm/damon/sysfs-schemes: read sysfs_filter->sz_range " SJ Park
2026-09-12 19:18 ` [RFC PATCH 3/8] mm/damon/core: return an error from damos_commit_filter_arg() SJ Park
2026-09-12 19:18 ` [RFC PATCH 4/8] mm/damon/core: disallow max < min damos filter range arguments commit SJ Park
2026-09-12 19:18 ` [RFC PATCH 5/8] mm/damon/sysfs-schemes: drop centralized filter range arg validations SJ Park
2026-09-12 19:18 ` SJ Park [this message]
2026-09-12 19:18 ` [RFC PATCH 7/8] mm/damon/core-kunit: extend damos_commit_filter_for() for wrong input SJ Park
2026-09-12 19:18 ` [RFC PATCH 8/8] mm/damon/core-kunit: test invalid damos filter commits SJ Park
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260912191807.138502-7-sj@kernel.org \
--to=sj@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=damon@lists.linux.dev \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®