Re: [PATCH] dt-bindings: display: panel: mipi-dbi-spi: add st7789v-tft28

[Krzysztof Kozlowski <krzk@kernel.org>]

On Fri, Sep 11, 2026 at 05:19:20PM -0300, Enzo Frese wrote:
> This is a generic 2.8" 240x320 RGB LCD panel with a MIPI DBI compatible
> SPI interface, based on the Sitronix ST7789V controller. It is commonly
> sold by various resellers without an identifiable original manufacturer
> name printed on the PCB.
> 
> A basic mipi-dbi-cmd[1] script to get the display running looks like
> this:
> 
> $ cat st7789v-tft28.txt
> command 0x11
> delay 120
> command 0x3a 0x55
> command 0xb2 0x05 0x05 0x00 0x33 0x33
> command 0xb7 0x75
> command 0xc2 0x01 0xff
> command 0xc3 0x13
> command 0xc4 0x20
> command 0xbb 0x22
> command 0xc5 0x20
> command 0xd0 0xa4 0xa1
> command 0xe0 0xd0 0x05 0x0a 0x09 0x08 0x05 0x2e 0x44 0x45 0x0f 0x17 0x16 0x2b 0x33
> command 0xe1 0xd0 0x05 0x0a 0x09 0x08 0x05 0x2e 0x43 0x45 0x0f 0x16 0x16 0x2b 0x33
> command 0x36 0x00
> command 0x29
> command 0x21
> 
> $ mipi-dbi-cmd st7789v-tft28.bin st7789v-tft28.txt
> 
> Tested on a Raspberry Pi 4B using the panel-mipi-dbi driver.
> 
> [1]: https://github.com/notro/panel-mipi-dbi
> 
> Signed-off-by: Enzo Frese <freseenzo@gmail.com>
> ---
>  .../devicetree/bindings/display/panel/panel-mipi-dbi-spi.yaml    | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/Documentation/devicetree/bindings/display/panel/panel-mipi-dbi-spi.yaml b/Documentation/devicetree/bindings/display/panel/panel-mipi-dbi-spi.yaml
> index 6f0290c4e291..c28659bd05dc 100644
> --- a/Documentation/devicetree/bindings/display/panel/panel-mipi-dbi-spi.yaml
> +++ b/Documentation/devicetree/bindings/display/panel/panel-mipi-dbi-spi.yaml
> @@ -75,6 +75,7 @@ properties:
>            - saef,sftc154b
>            - sainsmart18
>            - shineworld,lh133k
> +          - st7789v-tft28

1. Where is any user of this? Why are you sending binding alone?
2. Does not follow compatible style at all - missing vendor prefix.

Best regards,
Krzysztof