From: Mateusz Guzik <mjguzik@gmail.com>
To: brauner@kernel.org
Cc: viro@zeniv.linux.org.uk, jack@suse.cz,
linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org,
Mateusz Guzik <mjguzik@gmail.com>
Subject: [PATCH 03/10] fs: use path_clone() in path_init()
Date: Sun, 13 Sep 2026 16:49:10 +0200 [thread overview]
Message-ID: <20260913144918.1606123-4-mjguzik@gmail.com> (raw)
In-Reply-To: <20260913144918.1606123-1-mjguzik@gmail.com>
No functional changes.
Signed-off-by: Mateusz Guzik <mjguzik@gmail.com>
---
fs/namei.c | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/fs/namei.c b/fs/namei.c
index c8754c7ba8be..11937cfa8c7f 100644
--- a/fs/namei.c
+++ b/fs/namei.c
@@ -2745,13 +2745,13 @@ static const char *path_init(struct nameidata *nd, unsigned flags)
struct inode *inode = root->d_inode;
if (*s && unlikely(!d_can_lookup(root)))
return ERR_PTR(-ENOTDIR);
- nd->path = nd->root;
nd->inode = inode;
if (flags & LOOKUP_RCU) {
+ nd->path = nd->root;
nd->seq = read_seqcount_begin(&nd->path.dentry->d_seq);
nd->root_seq = nd->seq;
} else {
- path_get(&nd->path);
+ path_clone(&nd->root, &nd->path);
}
return s;
}
@@ -2801,23 +2801,23 @@ static const char *path_init(struct nameidata *nd, unsigned flags)
if (*s && unlikely(!d_can_lookup(dentry)))
return ERR_PTR(-ENOTDIR);
- nd->path = fd_file(f)->f_path;
if (flags & LOOKUP_RCU) {
+ nd->path = fd_file(f)->f_path;
nd->inode = nd->path.dentry->d_inode;
nd->seq = read_seqcount_begin(&nd->path.dentry->d_seq);
} else {
- path_get(&nd->path);
+ path_clone(&fd_file(f)->f_path, &nd->path);
nd->inode = nd->path.dentry->d_inode;
}
}
/* For scoped-lookups we need to set the root to the dirfd as well. */
if (unlikely(flags & LOOKUP_IS_SCOPED)) {
- nd->root = nd->path;
if (flags & LOOKUP_RCU) {
+ nd->root = nd->path;
nd->root_seq = nd->seq;
} else {
- path_get(&nd->root);
+ path_clone(&nd->path, &nd->root);
nd->state |= ND_ROOT_GRABBED;
}
}
--
2.53.0
next prev parent reply other threads:[~2026-09-13 14:49 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-13 14:49 [PATCH 00/10] Towards safer path_* API Mateusz Guzik
2026-09-13 14:49 ` [PATCH 01/10] fs: unexport backing_file_set_user_path() and make it take the ref on its own Mateusz Guzik
2026-09-14 8:33 ` Jan Kara
2026-09-14 23:41 ` NeilBrown
2026-09-13 14:49 ` [PATCH 02/10] fs: add path_create(), path_move() and path_clone() Mateusz Guzik
2026-09-13 14:51 ` Mateusz Guzik
2026-09-14 23:46 ` NeilBrown
2026-09-15 0:05 ` NeilBrown
2026-09-15 0:10 ` NeilBrown
2026-09-13 14:49 ` Mateusz Guzik [this message]
2026-09-14 23:52 ` [PATCH 03/10] fs: use path_clone() in path_init() NeilBrown
2026-09-13 14:49 ` [PATCH 04/10] fs: use path_clone() and path_move() in vfs_open* Mateusz Guzik
2026-09-14 8:56 ` Jan Kara
2026-09-13 14:49 ` [PATCH 05/10] fs: use path_clone() in backing_file_set_user_path() Mateusz Guzik
2026-09-14 8:57 ` Jan Kara
2026-09-13 14:49 ` [PATCH 06/10] Coccinelle-based conversion of path_* consumers to use the new primitives Mateusz Guzik
2026-09-14 8:57 ` Jan Kara
2026-09-13 14:49 ` [PATCH 07/10] autofs: use path_create() Mateusz Guzik
2026-09-14 8:58 ` Jan Kara
2026-09-13 14:49 ` [PATCH 08/10] fsnotify: use path_clone() Mateusz Guzik
2026-09-14 8:36 ` Jan Kara
2026-09-13 14:49 ` [PATCH 09/10] proc: " Mateusz Guzik
2026-09-14 8:58 ` Jan Kara
2026-09-13 14:49 ` [PATCH 10/10] nfsd: " Mateusz Guzik
2026-09-14 9:01 ` Jan Kara
2026-09-14 8:53 ` [PATCH 00/10] Towards safer path_* API Jan Kara
2026-09-14 23:36 ` NeilBrown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260913144918.1606123-4-mjguzik@gmail.com \
--to=mjguzik@gmail.com \
--cc=brauner@kernel.org \
--cc=jack@suse.cz \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®