From: Anand Moon <linux.amoon@gmail.com>
To: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>,
Krzysztof Kozlowski <krzk@kernel.org>,
"Rafael J. Wysocki" <rafael@kernel.org>,
Daniel Lezcano <daniel.lezcano@kernel.org>,
Zhang Rui <rui.zhang@intel.com>,
Lukasz Luba <lukasz.luba@arm.com>,
Peter Griffin <peter.griffin@linaro.org>,
Alim Akhtar <alim.akhtar@samsung.com>,
linux-samsung-soc@vger.kernel.org (open list:SAMSUNG THERMAL
DRIVER), linux-pm@vger.kernel.org (open list:THERMAL),
linux-kernel@vger.kernel.org (open list),
linux-arm-kernel@lists.infradead.org (moderated list:ARM/SAMSUNG
S3C, S5P AND EXYNOS ARM ARCHITECTURES)
Cc: Anand Moon <linux.amoon@gmail.com>
Subject: [PATCH v9 7/9] thermal/drivers/exynos: Move thermal zone ops to variant data
Date: Sun, 13 Sep 2026 20:28:35 +0530 [thread overview]
Message-ID: <20260913145905.9404-8-linux.amoon@gmail.com> (raw)
In-Reply-To: <20260913145905.9404-1-linux.amoon@gmail.com>
Move the thermal zone device operations into the SoC-specific variant
data and use the variant when registering the thermal zone.
Store a thermal_zone_device_ops pointer in struct exynos_tmu_variant
so that each supported SoC can provide its own thermal zone operations.
This allows thermal zone registration to be selected together with the
other SoC-specific TMU configuration through the device tree match data.
Signed-off-by: Anand Moon <linux.amoon@gmail.com>
---
drivers/thermal/samsung/exynos_tmu.c | 69 ++++++++++++++++------------
1 file changed, 40 insertions(+), 29 deletions(-)
diff --git a/drivers/thermal/samsung/exynos_tmu.c b/drivers/thermal/samsung/exynos_tmu.c
index a689c6a40b67..0e7b92035850 100644
--- a/drivers/thermal/samsung/exynos_tmu.c
+++ b/drivers/thermal/samsung/exynos_tmu.c
@@ -186,6 +186,7 @@ struct exynos_tmu_data {
* @tmu_read: SoC-specific TMU temperature read method.
* @tmu_set_emulation: SoC-specific TMU emulation setting method.
* @tmu_clear_irqs: SoC-specific TMU interrupt clearing method.
+ * @tmu_ops: SoC-specific thermal zone device operations.
*/
struct exynos_tmu_variant {
enum soc_type soc;
@@ -205,6 +206,7 @@ struct exynos_tmu_variant {
int (*tmu_read)(struct exynos_tmu_data *data);
void (*tmu_set_emulation)(struct exynos_tmu_data *data, int temp);
void (*tmu_clear_irqs)(struct exynos_tmu_data *data);
+ const struct thermal_zone_device_ops *tmu_ops;
};
/*
@@ -809,6 +811,34 @@ static void exynos4210_tmu_clear_irqs(struct exynos_tmu_data *data)
writel(val_irq, data->base + tmu_intclear);
}
+static int exynos_set_trips(struct thermal_zone_device *tz, int low, int high)
+{
+ struct exynos_tmu_data *data = thermal_zone_device_priv(tz);
+
+ mutex_lock(&data->lock);
+ clk_enable(data->clk);
+
+ if (low > INT_MIN)
+ data->variant->tmu_set_low_temp(data, low / MCELSIUS);
+ else
+ data->variant->tmu_disable_low(data);
+ if (high < INT_MAX)
+ data->variant->tmu_set_high_temp(data, high / MCELSIUS);
+ else
+ data->variant->tmu_disable_high(data);
+
+ clk_disable(data->clk);
+ mutex_unlock(&data->lock);
+
+ return 0;
+}
+
+static const struct thermal_zone_device_ops exynos_sensor_ops = {
+ .get_temp = exynos_get_temp,
+ .set_emul_temp = exynos_tmu_set_emulation,
+ .set_trips = exynos_set_trips,
+};
+
static const struct exynos_tmu_variant exynos3250_data = {
.soc = SOC_ARCH_EXYNOS3250,
.gain = 8,
@@ -826,6 +856,7 @@ static const struct exynos_tmu_variant exynos3250_data = {
.tmu_read = exynos4412_tmu_read,
.tmu_set_emulation = exynos4412_tmu_set_emulation,
.tmu_clear_irqs = exynos4210_tmu_clear_irqs,
+ .tmu_ops = &exynos_sensor_ops,
};
static const struct exynos_tmu_variant exynos4210_data = {
@@ -844,6 +875,7 @@ static const struct exynos_tmu_variant exynos4210_data = {
.tmu_control = exynos4210_tmu_control,
.tmu_read = exynos4210_tmu_read,
.tmu_clear_irqs = exynos4210_tmu_clear_irqs,
+ .tmu_ops = &exynos_sensor_ops,
};
static const struct exynos_tmu_variant exynos4412_data = {
@@ -863,6 +895,7 @@ static const struct exynos_tmu_variant exynos4412_data = {
.tmu_read = exynos4412_tmu_read,
.tmu_set_emulation = exynos4412_tmu_set_emulation,
.tmu_clear_irqs = exynos4210_tmu_clear_irqs,
+ .tmu_ops = &exynos_sensor_ops,
};
static const struct exynos_tmu_variant exynos5250_data = {
@@ -882,6 +915,7 @@ static const struct exynos_tmu_variant exynos5250_data = {
.tmu_read = exynos4412_tmu_read,
.tmu_set_emulation = exynos4412_tmu_set_emulation,
.tmu_clear_irqs = exynos4210_tmu_clear_irqs,
+ .tmu_ops = &exynos_sensor_ops,
};
static const struct exynos_tmu_variant exynos5260_data = {
@@ -901,6 +935,7 @@ static const struct exynos_tmu_variant exynos5260_data = {
.tmu_read = exynos4412_tmu_read,
.tmu_set_emulation = exynos4412_tmu_set_emulation,
.tmu_clear_irqs = exynos4210_tmu_clear_irqs,
+ .tmu_ops = &exynos_sensor_ops,
};
static const struct exynos_tmu_variant exynos5420_data = {
@@ -920,6 +955,7 @@ static const struct exynos_tmu_variant exynos5420_data = {
.tmu_read = exynos4412_tmu_read,
.tmu_set_emulation = exynos4412_tmu_set_emulation,
.tmu_clear_irqs = exynos4210_tmu_clear_irqs,
+ .tmu_ops = &exynos_sensor_ops,
};
static const struct exynos_tmu_variant exynos5420_triminfo_data = {
@@ -939,6 +975,7 @@ static const struct exynos_tmu_variant exynos5420_triminfo_data = {
.tmu_read = exynos4412_tmu_read,
.tmu_set_emulation = exynos4412_tmu_set_emulation,
.tmu_clear_irqs = exynos4210_tmu_clear_irqs,
+ .tmu_ops = &exynos_sensor_ops,
};
static const struct exynos_tmu_variant exynos5433_data = {
@@ -958,6 +995,7 @@ static const struct exynos_tmu_variant exynos5433_data = {
.tmu_read = exynos4412_tmu_read,
.tmu_set_emulation = exynos4412_tmu_set_emulation,
.tmu_clear_irqs = exynos4210_tmu_clear_irqs,
+ .tmu_ops = &exynos_sensor_ops,
};
static const struct exynos_tmu_variant exynos7_data = {
@@ -977,6 +1015,7 @@ static const struct exynos_tmu_variant exynos7_data = {
.tmu_read = exynos7_tmu_read,
.tmu_set_emulation = exynos4412_tmu_set_emulation,
.tmu_clear_irqs = exynos4210_tmu_clear_irqs,
+ .tmu_ops = &exynos_sensor_ops,
};
static const struct of_device_id exynos_tmu_match[] = {
@@ -1052,34 +1091,6 @@ static int exynos_map_dt_data(struct platform_device *pdev)
return 0;
}
-static int exynos_set_trips(struct thermal_zone_device *tz, int low, int high)
-{
- struct exynos_tmu_data *data = thermal_zone_device_priv(tz);
-
- mutex_lock(&data->lock);
- clk_enable(data->clk);
-
- if (low > INT_MIN)
- data->variant->tmu_set_low_temp(data, low / MCELSIUS);
- else
- data->variant->tmu_disable_low(data);
- if (high < INT_MAX)
- data->variant->tmu_set_high_temp(data, high / MCELSIUS);
- else
- data->variant->tmu_disable_high(data);
-
- clk_disable(data->clk);
- mutex_unlock(&data->lock);
-
- return 0;
-}
-
-static const struct thermal_zone_device_ops exynos_sensor_ops = {
- .get_temp = exynos_get_temp,
- .set_emul_temp = exynos_tmu_set_emulation,
- .set_trips = exynos_set_trips,
-};
-
static int exynos_tmu_probe(struct platform_device *pdev)
{
struct device *dev = &pdev->dev;
@@ -1144,7 +1155,7 @@ static int exynos_tmu_probe(struct platform_device *pdev)
}
data->tzd = devm_thermal_of_zone_register(dev, 0, data,
- &exynos_sensor_ops);
+ data->variant->tmu_ops);
if (IS_ERR(data->tzd))
ret = dev_err_probe(dev, PTR_ERR(data->tzd), "Failed to register sensor\n");
--
2.55.0
next prev parent reply other threads:[~2026-09-13 15:00 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-13 14:58 [PATCH v9 0/9] Exynos Thermal code improvement Anand Moon
2026-09-13 14:58 ` [PATCH v9 1/9] thermal/drivers/exynos: Optimize clock lifecycle with devm helpers Anand Moon
2026-09-13 14:58 ` [PATCH v9 2/9] thermal/drivers/exynos: Drop invalid IRQF_SHARED flag from TMU interrupts Anand Moon
2026-09-13 14:58 ` [PATCH v9 3/9] thermal/drivers/exynos: Handle optional triminfo clock correctly Anand Moon
2026-09-14 7:07 ` Krzysztof Kozlowski
2026-09-13 14:58 ` [PATCH v9 4/9] thermal/drivers/exynos: Fixed the efuse min max value for exynos5420 Anand Moon
2026-09-13 14:58 ` [PATCH v9 5/9] thermal/drivers/exynos: Remove redundant base_second register resource Anand Moon
2026-09-14 7:05 ` Krzysztof Kozlowski
2026-09-13 14:58 ` [PATCH v9 6/9] thermal/drivers/exynos: Use SoC-specific variant data to TMU configuration Anand Moon
2026-09-13 14:58 ` Anand Moon [this message]
2026-09-13 14:58 ` [PATCH v9 8/9] thermal/drivers/exynos: Add missing drvdata assignment in Exynos TMU probe Anand Moon
2026-09-14 7:01 ` Krzysztof Kozlowski
2026-09-13 14:58 ` [PATCH v9 9/9] thermal/drivers/exynos: Select thermal emulation support Anand Moon
2026-09-14 7:00 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260913145905.9404-8-linux.amoon@gmail.com \
--to=linux.amoon@gmail.com \
--cc=alim.akhtar@samsung.com \
--cc=bzolnier@gmail.com \
--cc=daniel.lezcano@kernel.org \
--cc=krzk@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=lukasz.luba@arm.com \
--cc=peter.griffin@linaro.org \
--cc=rafael@kernel.org \
--cc=rui.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®