From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qk2-f12.google.com (mail-qk2-f12.google.com [74.125.230.204]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 33DCF78C9C for ; Sun, 13 Sep 2026 20:45:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.230.204 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789332351; cv=none; b=TW9UQRe70aUKLK7y/ki6kB0l04ag8OTLNTDjQaa1SdpnqiG4b/mxp5Lj+uEtt5WI1EkQKeHP778MPU2oKOzMTAA1J58UtH7cmrnpyHobiU1KBH3Ri7GjzP3uY6GxMjsg4hKvZHXrpneCA0V73zmch5mGDAeNBXb0mYxPujXqzXE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789332351; c=relaxed/simple; bh=xTPqnZu8meQr9zKYn6kU+Sjy+hM+55XIhd9WW3MwX/4=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=FKd0nVzugIWYHA/D+uoJ+YhNhPC8ieK737PBztp58SA1ys8VsVouKhhIdqMCJSQv3JQDe9HCNoFreQT3HfD7qR1709VftMsgJKZOdeIaVjUbwrnONwq09XsOIfHEclzHclrFqvtTxhKq8VmEngCKq8pi95p35+VAHl3A2V3uxLo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=pw94bZRs; arc=none smtp.client-ip=74.125.230.204 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="pw94bZRs" Received: by mail-qk2-f12.google.com with SMTP id af79cd13be357-93910cc46c4so102524885a.2 for ; Sun, 13 Sep 2026 13:45:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1789332349; x=1789937149; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=gIBMkVsQnc+d88IgxQtwbE3hp2eO368yzTFTV3ZCKw0=; b=pw94bZRs7MrpTRj5z9x8HjDKgq3ot412SACs5tnRdfms+dzJxAnPWXzhyZhGHzdML7 Qtd5q2dqE1V0Tt8EUFw/rvzxgUVL9Ch7jaPwcPV8LZmXWU8xyYzrcu8tTFCVOJMgHUyt aarW44CmHuQ744N3I4bzJTOHhdhN6oaG6dQwjHw8NVfQdLwEx/1e78jAVpwe1vcv1001 LiGqwj2VJSloFLMuyx2qAWtYVDZiblgF7B+fXX15s41XYoSnNL2jMcP4zxXotcB2P9ov i7fn6i1QqUmWomPo8l/3UvQis1VlVUwZmGAZoN/lHklpzGVtum/4ugacnmDnY520R5oX 0dhA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1789332349; x=1789937149; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=gIBMkVsQnc+d88IgxQtwbE3hp2eO368yzTFTV3ZCKw0=; b=BJSDCUcqNQJMccvMT5dI/Sq/ZYGc6jIUEIRvhsast6XVeYfrEoeScv286RGrpku0on zrh/NSrGx6O/yI+oPqhPty3STxG0qimI8bYckSyWy8vEQU49uvEhEPwGIan6sCXQ5U9o 33DxMWm8hjR85bmHY8cM2jr5lKildFmj1AkZ4b/nRMoEaLpXqmayVamZ1CGDWqaJXBWs vWy1YK7C/0znw7z1qW+iK9FcC80L8VFNRq6K42oCn3QR6LeKqU46LaVf+dvsB6oj/JFB vYY1r8hwy6y9kV8L6qFnK4yd/gqtvrHcN7AwMT5NaEDw5pJLZ5WTE2BzMjpgXPZ0aelo C4CQ== X-Forwarded-Encrypted: i=1; AKwUvBwcqPW6J6aJZuFX42JkEvg1SeDVaz+J81nM+R4IJFSnQoDob8s3vQkLrx/YK++7UGdnfRduRvQZ7rYLVyk=@vger.kernel.org X-Gm-Message-State: AFuF++mvaMMa9FlYMsAd5uECP1kwaOFhpkHrm1mxVtomUQal33rBf/Op FmR1KAvWuABLSvUYmal5tpNf3HHSVFVse1Xqp9aEMVvMIuT0urtbjO0= X-Gm-Gg: AYBFou1/ULxyhrGjzMRyGDprPH5Oova2+atBjKL0PMgFHarTQA37GsSZeuhEhctDE8f TieNAy4E7Iz44nTfYP/DytEFwh58UGpHAFxg3WMOMMMoPRzC2ETAIjUhg138jtwnYqwV175sVNC ZRE57rvzpoonsrW0NA4sZsCCSTqL8xQd+UlBIIrEtc1ncCHWvpjes6sazMYqFlFm4EtMHAIvwEy qksQXPK2Bc2WCjMK08CXHgb5rouWvSJLYSzLwz50kjUuJ2utpS8Ib0UhmxT/+OZvh672TvuGjMN 9YqkIB7vS2+zIITm/mjbEXcDVBqEokcCfdECNhMqlvSHmC0FERQlIGLqdshWnkBY9Wud6fFCJ8M qRcwPxmJNDTn0p/6Tainh2sjz/UoFaiev3hfnMF3icWP9j3+XQUG1mvkoezMBy9oAZ7LeFLHDbs 8Bi/BWZfDZibaJvwnR22hiq+fd+Lwwx54iRqAcK/weDfCIyCtvK4tzUrI0r4H0Lb325FVz9gwlR 56CQpnDnLDi5uSpj52/UETLmObu3AP87dwH6uwu5ULnCfytgxCl852DQLfbO3UsE0sYJVpCQyBY 1jLjjM+YGyaO3z4uj4p8PsiL58tyomah+g== X-Received: by 2002:a05:620a:288a:b0:939:ede4:a499 with SMTP id af79cd13be357-93a035f328dmr1218686885a.5.1789332349032; Sun, 13 Sep 2026 13:45:49 -0700 (PDT) Received: from localhost.localdomain ([104.39.73.78]) by smtp.gmail.com with ESMTPSA id af79cd13be357-939e7f19291sm837711585a.10.2026.09.13.13.45.46 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Sun, 13 Sep 2026 13:45:48 -0700 (PDT) From: Myeonghun Pak To: GR-Linux-NIC-Dev@marvell.com Cc: andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, ae878000@gmail.com, horms@kernel.org Subject: [PATCH net v2] net/qla3xxx: disable the PCI device on remove Date: Sun, 13 Sep 2026 16:45:34 -0400 Message-ID: <20260913204534.53825-1-mhun512@gmail.com> X-Mailer: git-send-email 2.50.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit ql3xxx_probe() enables the PCI device and balances that reference on probe failure. However, ql3xxx_remove() releases the mappings and PCI regions without disabling the device, leaving the enable reference held after unbind. Add pci_disable_device() at the end of ql3xxx_remove() to balance the successful probe's pci_enable_device() call. Keep the existing manual cleanup and probe error handling unchanged. This issue was identified during our ongoing static-analysis research while reviewing kernel code. Fixes: 5a4faa873782 ("[PATCH] qla3xxx NIC driver") Co-developed-by: Ijae Kim Signed-off-by: Ijae Kim Signed-off-by: Myeonghun Pak --- v2: - Add pci_disable_device() to ql3xxx_remove() instead of converting to pcim_enable_device(), as suggested by Simon Horman. v1: https://lore.kernel.org/netdev/20260911033219.34566-1-mhun512@gmail.com/ drivers/net/ethernet/qlogic/qla3xxx.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/ethernet/qlogic/qla3xxx.c b/drivers/net/ethernet/qlogic/qla3xxx.c --- a/drivers/net/ethernet/qlogic/qla3xxx.c +++ b/drivers/net/ethernet/qlogic/qla3xxx.c @@ -3916,6 +3916,7 @@ static void ql3xxx_remove(struct pci_dev *pdev) iounmap(qdev->mem_map_registers); pci_release_regions(pdev); free_netdev(ndev); + pci_disable_device(pdev); } static struct pci_driver ql3xxx_driver = { -- 2.53.0