From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj2-f13.google.com (mail-pj2-f13.google.com [74.125.227.141]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 21D6C2F28FC for ; Sun, 13 Sep 2026 21:47:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.227.141 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789336041; cv=none; b=LHY8tQIkjOtwDTsjpA5ZyjFQfUx8GGaPkX2ESo5LchfRLuw8OJTCI3+3E1LLOrahLxqYseMLUHBq7PsDOJ+jHSTjqDsGObF2QnkhSvGLv9Np4Ib1nz7RJ9tYyK1QZA4dybl4U5M3i1rPHV+k7tOtE1r0+bIi9su1vfEHU4zAJ04= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789336041; c=relaxed/simple; bh=UzW8n1UIqvlycxK3DIgwi9ka7lkaiEVYC5acDEsV6go=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=Jg0d1L3GdhRWxcWGtfFas4D7pYz+hVzTs3DBMmUMSIWFA5EeHICphG6cV4XFwWvHJZ3QR4SjuGroBnIn2w3ztR3NhFX513M5e/W2iRTtnaIG2FB7a0n8zFTDnvxHOw/tAiIvrK4x1zl5Nhx+CVeHC/lu6QB43g4zsk0PJ3ZMzWs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=hffu8BL9; arc=none smtp.client-ip=74.125.227.141 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="hffu8BL9" Received: by mail-pj2-f13.google.com with SMTP id 98e67ed59e1d1-39d67a9ae5bso317007a91.0 for ; Sun, 13 Sep 2026 14:47:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1789336039; x=1789940839; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=NUbAlL8/ncSi/xHkVdLyT8Bq19fax5BvNGFOBoCZR6E=; b=hffu8BL993S1vSrRFdRWGSfOl0VJOuGu8rrSvRd3bU93cGnert4UroTjV+20Poc7S3 catVXVP1hhkH86iWRHxCe4grz6WHcqRmSbjDIA+DpjqWdKoaramql/bpmnryC1TayQTg WXRf/gXKF0PjbIrmBxfXOWCL/ncaoreSnln/UIxrRRuii/cfQIpEMrLzItf83VA7SrsE bsma2aLL6V8niyTXyUgDpo/qGBiLhPDJiKcuItVRg1lR+jA/XnI5B0ux0bnspQUbJcBx +mXiScugXgsQGLY4VfnRek3EfaxMVS/qhjbVdBCM55tBxAFoSKMoxzBF/iC/0svukEln j6yA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1789336039; x=1789940839; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=NUbAlL8/ncSi/xHkVdLyT8Bq19fax5BvNGFOBoCZR6E=; b=Ymu1CKBzu3DypG/hCsU1g3ZaYN39GhAB2cgi9WKSP8GCcor9Aw9YqBYvEnh5YwzTH0 wCkbFR4n/IHlZfZ5RpgnFfoMavI6dKUOVSyOcDrohOxIilDexaGwKxVPNyOW+L+R1rNd UuCorC+BoguBNtFvFlv6HrJM1p5bPR357/r4l3Rzd1Ge9GC7bzjLIS69SBNsv/SGPUQG rCQadnUeDbJYWe7XypmT2nVvmkFQEa1GSp0NH3E6QXMzdSOO8axfpEMCtJLAfIJ0HHdH WXXWX6kEDdgVq1uHizDeLF7z8G3HJIRXTgIEM2fSSw1XKGgv46SagufjVsR13+JnFjLa 4RBw== X-Forwarded-Encrypted: i=1; AKwUvBwI9bGyWNekOt9nRo8nqY2nINnqz65FndO6eSmTyInTtO/WR1KmPqM141HS7t+V0sbQU8DwBKYZfS9Zohk=@vger.kernel.org X-Gm-Message-State: AFuF++mnXtuPEzNpyFR4AHo8swjZvrKZa2SB1VRy8T+T/DjYlhVXFW/s 22BpA8guDE6sR2uZfYOZzDcLQeSF0MmyS+0Wk/YRAS6RRSaM59s27Uqs X-Gm-Gg: AYBFou3NTcLJdgLKJBJBDXY6tqbloVZJD1hekmxj9uuuuG3CJIUvjDQ2S+J3TIM6oTO G+NnUTXO2txLThAPHcZSDdOiacs+NvUEjU0a73RKTEtALUfTBpgBfY+Xv+kmseYDHw4OY3twlGr SHpEk1cS8y34DNMjb+fFRoc3vR9gNIJzD2gwosl7Yh6Ev8ae3LJ/CV7CJNfHiitx1azAABt7wYX y+kFtlPDZsVQOERt1KZnBsmSzWpUNTi0EYm8+uaeafFBpFYt7Bbrtl9OVs2M4IghPpoUZqPTXkW mnolqBYTNybPPp+5NQhA2HC4WHVQ8zNxurL74bjTLCegOqOwZDpWa1x0E6wQvtv5EcuvzOUScyy Yx4jxxk/6fsXyPR0RaPOCcyP38XdWbuQfEjGkWLZaejefQx7t8vUOb136x8LCLfLcrcQMWBP02j 39rxChAD0kBJ4l7shaYvCeWDh+dcYKsQ7BiJ8+xgncAvkrfuCClz895LmcT5BU+MOlzH+0zXTmo 1bYC3MNW2JmgjKKv9zjQqabU5keVSx3HneKK9gwIXeg6YWsa/kv35PHYziN8zU0ThW1D2BweeAQ fqUSJf3ag01RADfh3LibRv4OdEqcxfY= X-Received: by 2002:a17:90b:4c08:b0:39b:3510:4af7 with SMTP id 98e67ed59e1d1-39d9bbbe877mr16153253a91.1.1789336039466; Sun, 13 Sep 2026 14:47:19 -0700 (PDT) Received: from cachyos-aura ([45.112.148.109]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-33bc03778c7sm11549002eec.9.2026.09.13.14.47.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 13 Sep 2026 14:47:18 -0700 (PDT) From: Navon John Lukose To: linux@roeck-us.net, sergiomelas@gmail.com Cc: linux-hwmon@vger.kernel.org, linux-kernel@vger.kernel.org, Navon John Lukose Subject: [PATCH] hwmon: (yogafan) Fix fan paths for Yoga Pro 7 14IAH10 Date: Mon, 14 Sep 2026 03:17:13 +0530 Message-ID: <20260913214713.205208-1-navonjohnlukose@gmail.com> X-Mailer: git-send-email 2.55.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The Yoga Pro 7 14IAH10 entry names \_SB.PC00.LPCB.EC0.FANS, which this machine's DSDT does not have, so probe matches on DMI, fails to resolve the path and returns -ENODEV. The EC exposes its two fan tachometers as FA1S and FA2S, and loq_15iax9_8bit_dual_cfg already describes that layout. Point the entry at it, and update the reference table row to match. Fixes: 9c110a467686 ("hwmon: (yogafan) Add support for new Lenovo models") Signed-off-by: Navon John Lukose --- Tested on a Lenovo Yoga Pro 7 14IAH10 (83KF), BIOS QGCN35WW. The EC field block declares FA1S at offset 0x104 and FA2S at 0x137, both 8 bits, and FANS does not appear anywhere in the table. Both fans report after the patch, 0 when stopped and 5600 RPM with the fans driven to maximum through the vendor WMI method. The multiplier stays at 100, and the AML agrees, reading the fields as (FA1S * 0x64) and (FA2S * 0x64). The table also lists the XiaoXinPro 13ARE as machine type 83KF, which is this machine's DMI product name. I left that row alone. Documentation/hwmon/yogafan.rst | 3 ++- drivers/hwmon/yogafan.c | 8 +------- 2 files changed, 3 insertions(+), 8 deletions(-) diff --git a/Documentation/hwmon/yogafan.rst b/Documentation/hwmon/yogafan.rst index 6395c94..84c5d2a 100644 --- a/Documentation/hwmon/yogafan.rst +++ b/Documentation/hwmon/yogafan.rst @@ -102,7 +102,8 @@ immediately to ensure the user knows the fan has stopped. 83KF | XiaoXinPro 13ARE | 0x06/0xFE | \_SB.PCI0.LPC0.EC0.FANS/FA2S | 8-bit | 100 82KU | IdeaPad 3 15ALC6 | 0x06 | \_SB.PCI0.LPC0.EC0.FAN0 | 8-bit | 100 83RU | Legion Pro 7 16 | 0x03/0x06 | \_SB.PCI0.LPC0.EC0.FANS/FA2S | 8-bit | 100 - 83KF | Yoga Pro 7 14IAH | 0x06 | \_SB.PC00.LPCB.EC0.FANS | 8-bit | 100 + 83KF | Yoga Pro 7 14IAH | 0x104 | \_SB.PC00.LPCB.EC0.FA1S (Fan1) | 8-bit | 100 + 83KF | Yoga Pro 7 14IAH | 0x137 | \_SB.PC00.LPCB.EC0.FA2S (Fan2) | 8-bit | 100 83BS | Yoga 7 16ARP8 | 0x03/0x06 | \_SB.PCI0.LPC0.EC0.FANS/FA2S | 8-bit | 100 *Legacy* | Pre-2020 Models | 0x06 | \_SB.PCI0.LPC.EC.FAN0 | 8-bit | 100 ---------------------------------------------------------------------------------------------------- diff --git a/drivers/hwmon/yogafan.c b/drivers/hwmon/yogafan.c index 278cb08..3fcad00 100644 --- a/drivers/hwmon/yogafan.c +++ b/drivers/hwmon/yogafan.c @@ -84,12 +84,6 @@ static const struct yogafan_config xiaoxin_8bit_dual_cfg = { .paths = { "\\_SB.PCI0.LPC0.EC0.FANS", "\\_SB.PCI0.LPC0.EC0.FA2S" } }; -static const struct yogafan_config yoga_pro_7_14iah10_cfg = { - .multiplier = 100, - .fan_count = 1, - .paths = { "\\_SB.PC00.LPCB.EC0.FANS", NULL } -}; - static void apply_rllag_filter(struct yoga_fan_data *data, int idx, long raw_rpm) { ktime_t now = ktime_get_boottime(); @@ -227,7 +221,7 @@ static const struct dmi_system_id yogafan_quirks[] = { DMI_MATCH(DMI_SYS_VENDOR, "LENOVO"), DMI_MATCH(DMI_PRODUCT_FAMILY, "Yoga Pro 7 14IAH10"), }, - .driver_data = (void *)&yoga_pro_7_14iah10_cfg, + .driver_data = (void *)&loq_15iax9_8bit_dual_cfg, }, { .ident = "Lenovo Yoga 7 16ARP8", base-commit: 22098763a10d9c13