From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 289DA3D0929; Sun, 13 Sep 2026 22:28:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789338542; cv=none; b=H7q9fkX5b2KzCHZIU+IpGoULcMCXHCyf1HKm4/w2pQ/2o5mCgqKTbO101axg53pfYS2+oWf0nbz0irCvpSdB7Lv28PZ+L57gFzF634orWSnzA3PDMr52VyOMAq7mMjU5QyfEK4jTJP7/YqHLDRmNdY3WA80OC/FxMaVAGTUj4u4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789338542; c=relaxed/simple; bh=apH6VZyAnmLAyezMqL9Ah7ks15w3tPV5R2LG2bJnac0=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=V5Hi39s1vas5iAoFQf1h21W3sZZlPbqy5nz67SZw6QA808v2AnPRmmJzQJxfo9c18gm8y/lkGYpoeMXNOviLs09y/DhZXWCtXWZ37OYTvY7B56dGahq0/AtX4uNpt+KigabLOe3gIElr4J8R21SDvT0v3c/9Raw4QQSpA3idH04= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=CwfFIu3j; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="CwfFIu3j" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 755001F00898; Sun, 13 Sep 2026 22:28:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1789338538; bh=TqR2Opoff9JKJPpDA+/gIuMlr5T0eNpJWAK21U2cxek=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=CwfFIu3jqqICnNoKmN4kymbYfVpL0kZ6KJh3pgECqXeD6p6ZDj76Om/FkZN/h6TpZ WvwBNmqcX73CCYePfsCVWZYkY5IzUzlqEqD4Vd/k9OEecOT1bUW3OLQzKVYBdw+mYW zT4q7WOrRVCOpNy9t4dVx+T7tsOVlgmQhJJO9ok8bTJ1Qc3zBcotkgD4YkcPR2m5cY eTEynS7FnUl1JChREfkD62i6P4YPF4F36q/5Fyb+6lsyGB+vdNsTF1w0zSEGeXYmiR eBBgTEC1Hkehp84Sib1uE0v6iDAFM9KfAc+ShZloLLsQEKQmTBlTNN4Da6dO/cPrRL 75OOiYnun3Rbg== From: Arnaldo Carvalho de Melo To: Namhyung Kim Cc: Ingo Molnar , Thomas Gleixner , James Clark , Jiri Olsa , Ian Rogers , Adrian Hunter , Clark Williams , linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org, Arnaldo Carvalho de Melo Subject: [PATCH 8/8] perf mem record: Request PERF_SAMPLE_CPU by default Date: Sun, 13 Sep 2026 19:28:20 -0300 Message-ID: <20260913222821.3353-9-acme@kernel.org> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260913222821.3353-1-acme@kernel.org> References: <20260913222821.3353-1-acme@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Arnaldo Carvalho de Melo The data-type profiling per-sample stream keys cross-CPU contention on sample->cpu: without PERF_SAMPLE_CPU the cpu field is the (u32)-1 "no CPU info" sentinel, documented as such in perf_session__deliver_event(), and same-instance reads and writes from different cores are indistinguishable from same-CPU traffic, so pahole's false-sharing detector cannot tell them apart. builtin-record.c already defines --sample-cpu and 'perf mem record' forwards unknown options to the record parser, so passing it explicitly works today; make it the default, next to the -d (addr) and -W (weight) the command already requests, documenting it in perf-mem(1). Assisted-by: LLM Signed-off-by: Arnaldo Carvalho de Melo --- tools/perf/Documentation/perf-mem.txt | 4 ++++ tools/perf/builtin-mem.c | 9 +++++++++ 2 files changed, 13 insertions(+) diff --git a/tools/perf/Documentation/perf-mem.txt b/tools/perf/Documentation/perf-mem.txt index 4d164836d0943119..fe51c5e3333dc4a0 100644 --- a/tools/perf/Documentation/perf-mem.txt +++ b/tools/perf/Documentation/perf-mem.txt @@ -14,6 +14,10 @@ DESCRIPTION ----------- "perf mem record" runs a command and gathers memory operation data from it, into perf.data. Perf record options are accepted and are passed through. +It also requests the address (-d), the weight (-W, where supported) and the +CPU id (--sample-cpu) of every sampled access by default; the CPU id is what +lets per-sample analysis tell reads and writes to the same data from +different cores apart from same-CPU traffic. "perf mem report" displays the result. It invokes perf report with the right set of options to display a memory access profile. By default, loads diff --git a/tools/perf/builtin-mem.c b/tools/perf/builtin-mem.c index 6101a26b3a781e69..a708e2549bae4ce7 100644 --- a/tools/perf/builtin-mem.c +++ b/tools/perf/builtin-mem.c @@ -135,6 +135,15 @@ static int __cmd_record(int argc, const char **argv, struct perf_mem *mem, rec_argv[i++] = "-d"; + /* + * The data-type profiling per-sample stream keys cross-CPU + * contention on sample->cpu (PERF_SAMPLE_CPU); without it the cpu + * field is the (u32)-1 'no CPU info' sentinel and same-instance + * reads and writes from different cores are indistinguishable + * from same-CPU traffic. + */ + rec_argv[i++] = "--sample-cpu"; + if (mem->phys_addr) rec_argv[i++] = "--phys-data"; -- 2.55.0